refactor: destructure repeated object property references across repo

Agent-Logs-Url: https://github.com/microsoft/rushstack/sessions/69ee967b-8010-4fce-9002-5746b3573f14

Co-authored-by: iclanton <5010588+iclanton@users.noreply.github.com>

Author: Copilot

apps/api-extractor/src/analyzer/AstSymbol.ts

@@ -117,12 +117,14 @@ export class AstSymbol extends AstEntity {
   public constructor(options: IAstSymbolOptions) {
     super();
 
-    this.followedSymbol = options.followedSymbol;
-    this.localName = options.localName;
-    this.isExternal = options.isExternal;
-    this.nominalAnalysis = options.nominalAnalysis;
-    this.parentAstSymbol = options.parentAstSymbol;
-    this.rootAstSymbol = options.rootAstSymbol || this;
+    const { followedSymbol, localName, isExternal, nominalAnalysis, parentAstSymbol, rootAstSymbol } =
+      options;
+    this.followedSymbol = followedSymbol;
+    this.localName = localName;
+    this.isExternal = isExternal;
+    this.nominalAnalysis = nominalAnalysis;
+    this.parentAstSymbol = parentAstSymbol;
+    this.rootAstSymbol = rootAstSymbol || this;
     this._astDeclarations = [];
   }
 

apps/api-extractor/src/api/Extractor.ts

@@ -153,12 +153,14 @@ export class ExtractorResult {
 
   /** @internal */
   public constructor(properties: ExtractorResult) {
-    this.compilerState = properties.compilerState;
-    this.extractorConfig = properties.extractorConfig;
-    this.succeeded = properties.succeeded;
-    this.apiReportChanged = properties.apiReportChanged;
-    this.errorCount = properties.errorCount;
-    this.warningCount = properties.warningCount;
+    const { compilerState, extractorConfig, succeeded, apiReportChanged, errorCount, warningCount } =
+      properties;
+    this.compilerState = compilerState;
+    this.extractorConfig = extractorConfig;
+    this.succeeded = succeeded;
+    this.apiReportChanged = apiReportChanged;
+    this.errorCount = errorCount;
+    this.warningCount = warningCount;
   }
 }
 

apps/api-extractor/src/api/ExtractorMessage.ts

@@ -132,16 +132,26 @@ export class ExtractorMessage {
 
   /** @internal */
   public constructor(options: IExtractorMessageOptions) {
-    this.category = options.category;
-    this.messageId = options.messageId;
-    this.text = options.text;
-    this.sourceFilePath = options.sourceFilePath;
-    this.sourceFileLine = options.sourceFileLine;
-    this.sourceFileColumn = options.sourceFileColumn;
-    this.properties = options.properties || {};
+    const {
+      category,
+      messageId,
+      text,
+      sourceFilePath,
+      sourceFileLine,
+      sourceFileColumn,
+      properties,
+      logLevel
+    } = options;
+    this.category = category;
+    this.messageId = messageId;
+    this.text = text;
+    this.sourceFilePath = sourceFilePath;
+    this.sourceFileLine = sourceFileLine;
+    this.sourceFileColumn = sourceFileColumn;
+    this.properties = properties || {};
 
     this._handled = false;
-    this._logLevel = options.logLevel || ExtractorLogLevel.None;
+    this._logLevel = logLevel || ExtractorLogLevel.None;
   }
 
   /**

apps/api-extractor/src/collector/ApiItemMetadata.ts

@@ -94,13 +94,23 @@ export class ApiItemMetadata {
   public docCommentEnhancerVisitorState: VisitorState = VisitorState.Unvisited;
 
   public constructor(options: IApiItemMetadataOptions) {
-    this.declaredReleaseTag = options.declaredReleaseTag;
-    this.effectiveReleaseTag = options.effectiveReleaseTag;
-    this.releaseTagSameAsParent = options.releaseTagSameAsParent;
-    this.isEventProperty = options.isEventProperty;
-    this.isOverride = options.isOverride;
-    this.isSealed = options.isSealed;
-    this.isVirtual = options.isVirtual;
-    this.isPreapproved = options.isPreapproved;
+    const {
+      declaredReleaseTag,
+      effectiveReleaseTag,
+      releaseTagSameAsParent,
+      isEventProperty,
+      isOverride,
+      isSealed,
+      isVirtual,
+      isPreapproved
+    } = options;
+    this.declaredReleaseTag = declaredReleaseTag;
+    this.effectiveReleaseTag = effectiveReleaseTag;
+    this.releaseTagSameAsParent = releaseTagSameAsParent;
+    this.isEventProperty = isEventProperty;
+    this.isOverride = isOverride;
+    this.isSealed = isSealed;
+    this.isVirtual = isVirtual;
+    this.isPreapproved = isPreapproved;
   }
 }

apps/api-extractor/src/collector/Collector.ts

@@ -107,11 +107,12 @@ export class Collector {
   public constructor(options: ICollectorOptions) {
     this.packageJsonLookup = new PackageJsonLookup();
 
-    this._program = options.program;
-    this.extractorConfig = options.extractorConfig;
-    this.sourceMapper = options.sourceMapper;
+    const { program, extractorConfig, sourceMapper, messageRouter } = options;
+    this._program = program;
+    this.extractorConfig = extractorConfig;
+    this.sourceMapper = sourceMapper;
 
-    const entryPointSourceFile: ts.SourceFile | undefined = options.program.getSourceFile(
+    const entryPointSourceFile: ts.SourceFile | undefined = program.getSourceFile(
       this.extractorConfig.mainEntryPointFilePath
     );
 
@@ -131,10 +132,10 @@ export class Collector {
       entryPointSourceFile
     });
 
-    this.messageRouter = options.messageRouter;
+    this.messageRouter = messageRouter;
 
-    this.program = options.program;
-    this.typeChecker = options.program.getTypeChecker();
+    this.program = program;
+    this.typeChecker = program.getTypeChecker();
     this.globalVariableAnalyzer = TypeScriptInternals.getGlobalVariableAnalyzer(this.program);
 
     this._tsdocParser = new tsdoc.TSDocParser(this.extractorConfig.tsdocConfiguration);

apps/api-extractor/src/collector/MessageRouter.ts

@@ -86,19 +86,28 @@ export class MessageRouter {
   public readonly showDiagnostics: boolean;
 
   public constructor(options: IMessageRouterOptions) {
-    this._workingPackageFolder = options.workingPackageFolder;
-    this._messageCallback = options.messageCallback;
+    const {
+      workingPackageFolder,
+      messageCallback,
+      sourceMapper,
+      tsdocConfiguration,
+      showVerboseMessages,
+      showDiagnostics,
+      messagesConfig
+    } = options;
+    this._workingPackageFolder = workingPackageFolder;
+    this._messageCallback = messageCallback;
 
     this._messages = [];
     this._associatedMessagesForAstDeclaration = new Map<AstDeclaration, ExtractorMessage[]>();
-    this._sourceMapper = options.sourceMapper;
-    this._tsdocConfiguration = options.tsdocConfiguration;
+    this._sourceMapper = sourceMapper;
+    this._tsdocConfiguration = tsdocConfiguration;
 
     // showDiagnostics implies showVerboseMessages
-    this.showVerboseMessages = options.showVerboseMessages || options.showDiagnostics;
-    this.showDiagnostics = options.showDiagnostics;
+    this.showVerboseMessages = showVerboseMessages || showDiagnostics;
+    this.showDiagnostics = showDiagnostics;
 
-    this._applyMessagesConfig(options.messagesConfig);
+    this._applyMessagesConfig(messagesConfig);
   }
 
   /**

apps/heft/src/cli/actions/PhaseAction.ts

@@ -20,19 +20,20 @@ export class PhaseAction extends CommandLineAction implements IHeftAction {
   private _selectedPhases: Set<HeftPhase> | undefined;
 
   public constructor(options: IPhaseActionOptions) {
+    const { phase, watch } = options;
     super({
-      actionName: `${options.phase.phaseName}${options.watch ? '-watch' : ''}`,
+      actionName: `${phase.phaseName}${watch ? '-watch' : ''}`,
       documentation:
-        `Runs to the ${options.phase.phaseName} phase, including all transitive dependencies` +
-        (options.watch ? ', in watch mode.' : '.') +
-        (options.phase.phaseDescription ? `  ${options.phase.phaseDescription}` : ''),
+        `Runs to the ${phase.phaseName} phase, including all transitive dependencies` +
+        (watch ? ', in watch mode.' : '.') +
+        (phase.phaseDescription ? `  ${phase.phaseDescription}` : ''),
       summary:
-        `Runs to the ${options.phase.phaseName} phase, including all transitive dependencies` +
-        (options.watch ? ', in watch mode.' : '.')
+        `Runs to the ${phase.phaseName} phase, including all transitive dependencies` +
+        (watch ? ', in watch mode.' : '.')
     });
 
-    this.watch = options.watch ?? false;
-    this._phase = options.phase;
+    this.watch = watch ?? false;
+    this._phase = phase;
     this._actionRunner = new HeftActionRunner({ action: this, ...options });
     this._actionRunner.defineParameters();
   }

apps/heft/src/pluginFramework/HeftLifecycleSession.ts

@@ -230,20 +230,22 @@ export class HeftLifecycleSession implements IHeftLifecycleSession {
 
   public constructor(options: IHeftLifecycleSessionOptions) {
     this._options = options;
-    this.logger = options.logger;
-    this.metricsCollector = options.metricsCollector;
-    this.hooks = options.lifecycleHooks;
-    this.parameters = options.lifecycleParameters;
-    this.debug = options.debug;
+    const { logger, metricsCollector, lifecycleHooks, lifecycleParameters, debug, pluginDefinition, heftConfiguration, pluginHost } =
+      options;
+    this.logger = logger;
+    this.metricsCollector = metricsCollector;
+    this.hooks = lifecycleHooks;
+    this.parameters = lifecycleParameters;
+    this.debug = debug;
 
     // Guranteed to be unique since phases are forbidden from using the name 'lifecycle'
     // and lifecycle plugin names are enforced to be unique.
-    const uniquePluginFolderName: string = `lifecycle.${options.pluginDefinition.pluginName}`;
+    const uniquePluginFolderName: string = `lifecycle.${pluginDefinition.pluginName}`;
 
     // <projectFolder>/temp/<phaseName>.<taskName>
-    this.tempFolderPath = path.join(options.heftConfiguration.tempFolderPath, uniquePluginFolderName);
+    this.tempFolderPath = path.join(heftConfiguration.tempFolderPath, uniquePluginFolderName);
 
-    this._pluginHost = options.pluginHost;
+    this._pluginHost = pluginHost;
   }
 
   public requestAccessToPluginByName<T extends object>(

apps/lockfile-explorer-web/src/packlets/lfx-shared/LfxGraph.ts

@@ -67,14 +67,16 @@ export class LfxGraphDependency {
   public resolvedEntry: LfxGraphEntry | undefined = undefined;
 
   public constructor(options: ILfxGraphDependencyOptions) {
-    this.name = options.name;
-    this.versionPath = options.versionPath;
-    this.entryId = options.entryId;
-    this.originalSpecifier = options.originalSpecifier;
-    this.dependencyKind = options.dependencyKind;
-    this.peerDependencyMeta = options.peerDependencyMeta;
-
-    this.containingEntry = options.containingEntry;
+    const { name, versionPath, entryId, originalSpecifier, dependencyKind, peerDependencyMeta, containingEntry } =
+      options;
+    this.name = name;
+    this.versionPath = versionPath;
+    this.entryId = entryId;
+    this.originalSpecifier = originalSpecifier;
+    this.dependencyKind = dependencyKind;
+    this.peerDependencyMeta = peerDependencyMeta;
+
+    this.containingEntry = containingEntry;
   }
 }
 
@@ -154,14 +156,24 @@ export class LfxGraphEntry {
   public readonly referrers: LfxGraphEntry[] = [];
 
   public constructor(options: ILfxGraphEntryOptions) {
-    this.kind = options.kind;
-    this.entryId = options.entryId;
-    this.rawEntryId = options.rawEntryId;
-    this.packageJsonFolderPath = options.packageJsonFolderPath;
-    this.entryPackageName = options.entryPackageName;
-    this.displayText = options.displayText;
-    this.entryPackageVersion = options.entryPackageVersion;
-    this.entrySuffix = options.entrySuffix;
+    const {
+      kind,
+      entryId,
+      rawEntryId,
+      packageJsonFolderPath,
+      entryPackageName,
+      displayText,
+      entryPackageVersion,
+      entrySuffix
+    } = options;
+    this.kind = kind;
+    this.entryId = entryId;
+    this.rawEntryId = rawEntryId;
+    this.packageJsonFolderPath = packageJsonFolderPath;
+    this.entryPackageName = entryPackageName;
+    this.displayText = displayText;
+    this.entryPackageVersion = entryPackageVersion;
+    this.entrySuffix = entrySuffix;
   }
 }
 

libraries/api-extractor-model/src/model/DeserializerContext.ts

@@ -143,10 +143,11 @@ export class DeserializerContext {
   public readonly tsdocConfiguration: TSDocConfiguration;
 
   public constructor(options: DeserializerContext) {
-    this.apiJsonFilename = options.apiJsonFilename;
-    this.toolPackage = options.toolPackage;
-    this.toolVersion = options.toolVersion;
-    this.versionToDeserialize = options.versionToDeserialize;
-    this.tsdocConfiguration = options.tsdocConfiguration;
+    const { apiJsonFilename, toolPackage, toolVersion, versionToDeserialize, tsdocConfiguration } = options;
+    this.apiJsonFilename = apiJsonFilename;
+    this.toolPackage = toolPackage;
+    this.toolVersion = toolVersion;
+    this.versionToDeserialize = versionToDeserialize;
+    this.tsdocConfiguration = tsdocConfiguration;
   }
 }