Fix CI to run pylint/mypy/pyright on generated SDK code (#10336)

Author: msyyc

.chronus/changes/python-fix-ci-2026-3-10-2-43-42.md

@@ -0,0 +1,7 @@
+---
+changeKind: internal
+packages:
+  - "@typespec/http-client-python"
+---
+
+fix ci to add lint check for generated sdk code

packages/http-client-python/eng/scripts/Test-Packages.ps1

@@ -74,6 +74,17 @@ try {
 
         Invoke-LoggedCommand "npm run ci"
         Write-Host "All tests passed." -ForegroundColor Green
+
+        # Linux specific: check mypy/lint/pyright on generated code
+        if ($IsLinux) {
+            Write-Host "`n=== Running lint on generated code ===" -ForegroundColor Cyan
+            Invoke-LoggedCommand "npm run lint:generated"
+            Write-Host "Generated code checks passed." -ForegroundColor Green
+
+            Write-Host "`n=== Running mypy/pyright on generated code ===" -ForegroundColor Cyan
+            Invoke-LoggedCommand "npm run typecheck:generated"
+            Write-Host "Generated code mypy/pyright checks passed." -ForegroundColor Green
+        }    
     }
 }
 finally {

packages/http-client-python/eng/scripts/ci/regenerate-common.ts

@@ -3,7 +3,7 @@ import { dirname, join, relative, resolve } from "path";
 
 // ---- Shared constants ----
 
-export const SKIP_SPECS: string[] = ["type/file"];
+export const SKIP_SPECS: string[] = ["type/file", "service/multiple-services"];
 
 export const SpecialFlags: Record<string, Record<string, any>> = {
   azure: {
@@ -218,6 +218,7 @@ export const BASE_EMITTER_OPTIONS: Record<
       "package-name": "generation-subdir",
       namespace: "generation.subdir",
       "generation-subdir": "_generated",
+      "generate-test": "false",
       "clear-output-folder": "true",
     },
   ],
@@ -286,6 +287,7 @@ export const BASE_EMITTER_OPTIONS: Record<
     {
       "package-name": "generation-subdir2",
       namespace: "generation.subdir2",
+      "generate-test": "false",
       "generation-subdir": "_generated",
     },
   ],
@@ -313,11 +315,6 @@ export interface RegenerateFlags {
   pyodide?: boolean;
 }
 
-export interface ProcessedEmitterOption {
-  options: Record<string, string>;
-  outputDir: string;
-}
-
 export interface RegenerateConfig {
   azureHttpSpecs: string;
   httpSpecs: string;
@@ -400,48 +397,6 @@ export async function getSubdirectories(
   return subdirectories;
 }
 
-export function defaultPackageName(spec: string, config: RegenerateConfig): string {
-  const specDir = spec.includes("azure") ? config.azureHttpSpecs : config.httpSpecs;
-  return toPosix(relative(specDir, dirname(spec)))
-    .replace(/\//g, "-")
-    .toLowerCase();
-}
-
-export function buildOptions(
-  spec: string,
-  generatedFolder: string,
-  flags: RegenerateFlags,
-  config: RegenerateConfig,
-): ProcessedEmitterOption[] {
-  const results: ProcessedEmitterOption[] = [];
-  for (const emitterConfig of getEmitterOption(spec, flags.flavor, config)) {
-    const options: Record<string, string> = { ...emitterConfig };
-    if (flags.pyodide) {
-      options["use-pyodide"] = "true";
-    }
-    options["flavor"] = flags.flavor;
-    for (const [k, v] of Object.entries(SpecialFlags[flags.flavor] ?? {})) {
-      options[k] = v;
-    }
-    if (options["emitter-output-dir"] === undefined) {
-      const packageName = options["package-name"] || defaultPackageName(spec, config);
-      // Output to new tests/generated/<flavor>/<package> structure
-      options["emitter-output-dir"] = toPosix(
-        `${generatedFolder}/../tests/generated/${flags.flavor}/${packageName}`,
-      );
-    }
-    if (flags.debug) {
-      options["debug"] = "true";
-    }
-    options["examples-dir"] = toPosix(join(dirname(spec), "examples"));
-    results.push({
-      options,
-      outputDir: options["emitter-output-dir"],
-    });
-  }
-  return results;
-}
-
 export async function runTaskPool(
   tasks: Array<() => Promise<void>>,
   poolLimit: number,

packages/http-client-python/eng/scripts/ci/regenerate.ts

@@ -148,13 +148,15 @@ function buildTaskGroups(specs: string[], flags: RegenerateFlags): TaskGroup[] {
     const tasks: CompileTask[] = [];
 
     for (const emitterConfig of getEmitterOptions(spec, flags.flavor)) {
-      const options: Record<string, unknown> = { ...emitterConfig };
-
-      // Add flavor-specific options
-      options["flavor"] = flags.flavor;
+      // Apply flavor defaults first, then per-spec options so they can override (e.g., "generate-test": "false")
+      const options: Record<string, unknown> = {};
       for (const [k, v] of Object.entries(SpecialFlags[flags.flavor] ?? {})) {
         options[k] = v;
       }
+      Object.assign(options, emitterConfig);
+
+      // Add flavor
+      options["flavor"] = flags.flavor;
 
       // Set output directory - use tests/generated/<flavor>/<package> structure
       const packageName = (options["package-name"] as string) || defaultPackageName(spec);

packages/http-client-python/eng/scripts/ci/run_mypy.py

@@ -27,7 +27,9 @@ def get_config_file_location():
 
 
 def _single_dir_mypy(mod):
-    inner_class = next(d for d in mod.iterdir() if d.is_dir() and not str(d).endswith("egg-info"))
+    # Exclude "build" directories to avoid mypy "Duplicate module" errors caused by
+    # stale build/lib/ artifacts from previous setup.py builds.
+    inner_class = next(d for d in mod.iterdir() if d.is_dir() and not str(d).endswith("egg-info") and d.stem != "build")
     try:
         check_call(
             [

packages/http-client-python/eng/scripts/ci/run_pylint.py

@@ -27,22 +27,30 @@ def get_rfc_file_location():
 
 
 def _single_dir_pylint(mod):
-    inner_class = next(d for d in mod.iterdir() if d.is_dir() and not str(d).endswith("egg-info"))
+    # Exclude "build" directories created by pip install / setup.py build.
+    # Without this, "build" may be picked first alphabetically and pylint would
+    # lint stale build artifacts instead of the actual source, causing false
+    # positives (e.g. modules named "json", "xml", "datetime" shadow the stdlib).
+    inner_class = next(d for d in mod.iterdir() if d.is_dir() and not str(d).endswith("egg-info") and d.name != "build")
+    # Only load the Azure pylint guidelines checker plugin for azure packages.
+    # The plugin (azure-pylint-guidelines-checker) is only installed in the
+    # lint-azure tox environment and is not available for unbranded packages.
+    is_azure = "azure" in mod.parts
+    pylint_args = [
+        sys.executable,
+        "-m",
+        "pylint",
+        "--rcfile={}".format(get_rfc_file_location()),
+        "--evaluation=(max(0, 0 if fatal else 10.0 - ((float(5 * error + warning + refactor + convention + info)/ statement) * 10)))",
+        "--output-format=parseable",
+        "--recursive=y",
+        "--py-version=3.9",
+    ]
+    if is_azure:
+        pylint_args.append("--load-plugins=pylint_guidelines_checker")
+    pylint_args.append(str(inner_class.absolute()))
     try:
-        check_call(
-            [
-                sys.executable,
-                "-m",
-                "pylint",
-                "--rcfile={}".format(get_rfc_file_location()),
-                "--evaluation=(max(0, 0 if fatal else 10.0 - ((float(5 * error + warning + refactor + convention + info)/ statement) * 10)))",
-                "--load-plugins=pylint_guidelines_checker",
-                "--output-format=parseable",
-                "--recursive=y",
-                "--py-version=3.9",
-                str(inner_class.absolute()),
-            ]
-        )
+        check_call(pylint_args)
         return True
     except CalledProcessError as e:
         logging.error("{} exited with linting error {}".format(str(inner_class.absolute()), e.returncode))

packages/http-client-python/eng/scripts/ci/util.py

@@ -12,7 +12,7 @@
 
 logging.getLogger().setLevel(logging.INFO)
 
-ROOT_FOLDER = os.path.abspath(os.path.join(os.path.abspath(__file__), "..", "..", "..", "generator"))
+ROOT_FOLDER = os.path.abspath(os.path.join(os.path.abspath(__file__), "..", "..", "..", "..", "tests"))
 
 IGNORE_FOLDER = []
 
@@ -53,11 +53,12 @@ def run_check(name, call_back, log_info):
 
     args = parser.parse_args()
 
-    pkg_dir = Path(ROOT_FOLDER) / Path("test") / Path(args.test_folder)
-    if args.generator:
-        pkg_dir /= Path(args.generator)
+    pkg_dir = Path(ROOT_FOLDER)
     if args.subfolder:
         pkg_dir /= Path(args.subfolder)
+    pkg_dir /= Path(args.test_folder)
+    if args.generator:
+        pkg_dir /= Path(args.generator)
     dirs = [d for d in pkg_dir.iterdir() if d.is_dir() and not d.stem.startswith("_") and d.stem not in IGNORE_FOLDER]
     if args.file_name:
         dirs = [d for d in dirs if args.file_name.lower() in d.stem.lower()]