Skip to content

Commit 3d4938d

Browse files
committed
Merge branch 'main' into microbuild
2 parents 1632266 + 8f317e6 commit 3d4938d

2 files changed

Lines changed: 15 additions & 0 deletions

File tree

.github/prompts/template-release-notes.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,3 +2,11 @@
22

33
This file will describe significant changes in Library.Template as they are introduced, especially if they require special consideration when merging updates into existing repos.
44
This file is referenced by update-library-template.prompt.md and should remain in place to facilitate future merges, whether done manually or by AI.
5+
6+
## Solution rename
7+
8+
Never leave a Library.slnx file in the repository.
9+
You might even see one there even though this particular merge didn't bring it in.
10+
This can be an artifact of having renamed Library.sln to Library.slnx in the template repo, but ultimately the receiving repo should have only one .sln or .slnx file, with a better name than `Library`.
11+
If you can confidently do so, go ahead and migrate their `.sln` to an `.slnx` with their original name.
12+
If you can't, just delete `Library.slnx` anyway.

.github/prompts/update-library-template.prompt.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ For example the template uses MTPv2 for test projects, but a repo might have cho
2020
When resolving merge conflicts, consider whether it looks like the relevant code file is older than it should be given the changes the template is bringing in.
2121
Ask the user when in doubt as to whether the conflict should be resolved in favor of 'catching up' with the template or keeping the current changes.
2222

23+
Use #runSubagent to analyze and resolve merge conflicts across files in parallel.
24+
2325
### Keep Current files
2426

2527
Conflicts in the following files should always be resolved by keeping the current version (i.e. discard incoming changes):
@@ -47,6 +49,11 @@ Use #runSubagent for each step.
4749
While these validations are described using `dotnet` CLI commands, some repos require using full msbuild.exe.
4850
You can detect this by checking the `azure-pipelines/dotnet.yml` or `.github/workflows/build.yml` files for use of one or the other tool.
4951

52+
You are *not* responsible for fixing issues that the merge did not cause.
53+
If validation fails for reasons that seem unrelated to the changes brought in by the merge, advise the user and ask how they'd like you to proceed.
54+
That said, sometimes merges will bring in SDK or dependency updates that can cause breaks in seemingly unrelated areas.
55+
In such cases, you should investigate and solve the issues as needed.
56+
5057
## Committing your changes
5158

5259
If you have to make any changes for validations to pass, consider whether they qualify as a bad merge conflict resolution or more of a novel change that you're making to work with the Library.Template update.

0 commit comments

Comments
 (0)