Skip to content
This repository was archived by the owner on Dec 6, 2022. It is now read-only.

Commit 0aa3b15

Browse files
committed
Upgrade TypeMoq
1 parent da32da7 commit 0aa3b15

4 files changed

Lines changed: 60 additions & 36 deletions

File tree

package-lock.json

Lines changed: 37 additions & 18 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949
"tmp": "0.0.31",
5050
"ts-loader": "^1.0.0",
5151
"tslint": "^5.7.0",
52-
"typemoq": "^0.3.3",
52+
"typemoq": "^2.1.0",
5353
"typescript": "^2.7.2",
5454
"vsce": "^1.32.0",
5555
"vscode": "^1.0.3",

test/chromeDebugAdapter.test.ts

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,13 @@ import { chromeConnection, ISourceMapPathOverrides, telemetry } from 'vscode-chr
88
import * as mockery from 'mockery';
99
import { EventEmitter } from 'events';
1010
import * as assert from 'assert';
11-
import { Mock, MockBehavior, It } from 'typemoq';
11+
import { Mock, MockBehavior, It, IMock, Times } from 'typemoq';
1212

1313
import { getMockChromeConnectionApi, IMockChromeConnectionAPI } from './debugProtocolMocks';
1414
import * as testUtils from './testUtils';
1515

1616
/** Not mocked - use for type only */
1717
import {ChromeDebugAdapter as _ChromeDebugAdapter } from '../src/chromeDebugAdapter';
18-
import { StepProgressEventsEmitter } from 'vscode-chrome-debug-core/out/src/executionTimingsReporter';
1918

2019
class MockChromeDebugSession {
2120
public sendEvent(event: DebugProtocol.Event): void {
@@ -27,7 +26,7 @@ class MockChromeDebugSession {
2726

2827
const MODULE_UNDER_TEST = '../src/chromeDebugAdapter';
2928
suite('ChromeDebugAdapter', () => {
30-
let mockChromeConnection: Mock<chromeConnection.ChromeConnection>;
29+
let mockChromeConnection: IMock<chromeConnection.ChromeConnection>;
3130
let mockEventEmitter: EventEmitter;
3231
let mockChrome: IMockChromeConnectionAPI;
3332

@@ -44,21 +43,27 @@ suite('ChromeDebugAdapter', () => {
4443
mockEventEmitter = mockChrome.mockEventEmitter;
4544
mockChromeConnection
4645
.setup(x => x.api)
47-
.returns(() => mockChrome.apiObjects);
46+
.returns(() => mockChrome.apiObjects)
47+
.verifiable(Times.atLeast(0));
4848
mockChromeConnection
4949
.setup(x => x.attach(It.isValue(undefined), It.isAnyNumber(), It.isValue(undefined)))
50-
.returns(() => Promise.resolve());
50+
.returns(() => Promise.resolve())
51+
.verifiable(Times.atLeast(0));
5152
mockChromeConnection
5253
.setup(x => x.isAttached)
53-
.returns(() => false);
54+
.returns(() => false)
55+
.verifiable(Times.atLeast(0));
5456
mockChromeConnection
5557
.setup(x => x.run())
56-
.returns(() => Promise.resolve());
58+
.returns(() => Promise.resolve())
59+
.verifiable(Times.atLeast(0));
5760
mockChromeConnection
58-
.setup(x => x.onClose(It.isAny()));
61+
.setup(x => x.onClose(It.isAny()))
62+
.verifiable(Times.atLeast(0));
5963
mockChromeConnection
6064
.setup(x => x.events)
61-
.returns(x => new StepProgressEventsEmitter());
65+
.returns(x => null)
66+
.verifiable(Times.atLeast(0));
6267

6368
// Instantiate the ChromeDebugAdapter, injecting the mock ChromeConnection
6469
const cDAClass: typeof _ChromeDebugAdapter = require(MODULE_UNDER_TEST).ChromeDebugAdapter;

test/debugProtocolMocks.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,19 +5,19 @@
55
// Copied from -core because I don't want to include test stuff in the npm package
66

77
import { EventEmitter } from 'events';
8-
import { Mock, It } from 'typemoq';
8+
import { Mock, It, IMock } from 'typemoq';
99
import { Crdp } from 'vscode-chrome-debug-core';
1010

1111
export interface IMockChromeConnectionAPI {
1212
apiObjects: Crdp.CrdpClient;
1313

14-
Browser: Mock<Crdp.BrowserClient>;
15-
Console: Mock<Crdp.ConsoleClient>;
16-
Debugger: Mock<Crdp.DebuggerClient>;
17-
Runtime: Mock<Crdp.RuntimeClient>;
18-
Inspector: Mock<Crdp.InspectorClient>;
19-
Network: Mock<Crdp.NetworkClient>;
20-
Page: Mock<Crdp.PageClient>;
14+
Browser: IMock<Crdp.BrowserClient>;
15+
Console: IMock<Crdp.ConsoleClient>;
16+
Debugger: IMock<Crdp.DebuggerClient>;
17+
Runtime: IMock<Crdp.RuntimeClient>;
18+
Inspector: IMock<Crdp.InspectorClient>;
19+
Network: IMock<Crdp.NetworkClient>;
20+
Page: IMock<Crdp.PageClient>;
2121

2222
mockEventEmitter: EventEmitter;
2323
}

0 commit comments

Comments
 (0)