Respect forceBuildBeforeLaunch setting even if autobuild is disabled (#1380)

Author: testforstephen

README.md

@@ -129,7 +129,7 @@ Please also check the documentation of [Language Support for Java by Red Hat](ht
   - `auto` - Automatically apply the changes after compilation. This only works when `'java.autobuild.enabled'` is on.
   - `never` - Never apply the changes.
 - `java.debug.settings.enableRunDebugCodeLens`: enable the code lens provider for the run and debug buttons over main entry points, defaults to `true`.
-- `java.debug.settings.forceBuildBeforeLaunch`: force building the workspace before launching java program, defaults to `true`. If `'java.autobuild.enabled'` is disabled, this setting will be ignored and still force a build job before launching.
+- `java.debug.settings.forceBuildBeforeLaunch`: force building the workspace before launching java program, defaults to `true`.
 - `java.debug.settings.onBuildFailureProceed`: Force to proceed when build fails, defaults to false.
 - `java.debug.settings.console`: The specified console to launch Java program, defaults to `integratedTerminal`. If you want to customize the console for a specific debug session, please modify the 'console' config in launch.json.
   - `internalConsole` - VS Code debug console (input stream not supported).

package.nls.json

@@ -62,7 +62,7 @@
     "java.debugger.configuration.numericPrecision.description": "The precision when formatting doubles in \"Variables\" or \"Debug Console\" viewlet.",
     "java.debugger.configuration.hotCodeReplace.description": "Reload the changed Java classes during debugging.",
     "java.debugger.configuration.enableRunDebugCodeLens.description": "Enable the run and debug code lens providers over main methods.",
-    "java.debugger.configuration.forceBuildBeforeLaunch": "Force building the workspace before launching java program. If 'java.autobuild.enabled' is disabled, this setting will be ignored and still force a build job before launching.",
+    "java.debugger.configuration.forceBuildBeforeLaunch": "Force building the workspace before launching java program.",
     "java.debugger.configuration.onBuildFailureProceed": "Force to proceed when build fails",
     "java.debugger.configuration.console": "The specified console to launch Java program. If you want to customize the console for a specific debug session, please modify the 'console' config in launch.json.",
     "java.debugger.configuration.exceptionBreakpoint.exceptionTypes": "Specifies a set of exception types you want to break on, e.g. java.lang.NullPointerException. A specific exception type and its subclasses can be selected for caught exceptions, uncaught exceptions, or both can be selected.",

package.nls.zh-cn.json

@@ -60,7 +60,7 @@
     "java.debugger.configuration.maxStringLength.description": "设定“变量”或“调试控制台”视图中显示的字符串最大长度，长度超过部分将被剪掉。如果值为0，则不执行修剪。",
     "java.debugger.configuration.hotCodeReplace.description": "在调试期间重新加载已更改的Java类。",
     "java.debugger.configuration.enableRunDebugCodeLens.description": "在main方法上启用CodeLens标记。",
-    "java.debugger.configuration.forceBuildBeforeLaunch": "在启动java程序之前强制编译整个工作空间。如果“java.autobuild.enabled”被禁掉，则会忽略该设置，在运行之前强制执行一次编译。",
+    "java.debugger.configuration.forceBuildBeforeLaunch": "在启动java程序之前强制编译整个工作空间。",
     "java.debugger.configuration.console": "指定的控制台用于启动Java程序。如果要为特定的调试会话自定义控制台，请修改launch.json中的“console”配置。",
     "java.debugger.configuration.exceptionBreakpoint.exceptionTypes": "指定要中断的一组异常类型，例如 java.lang.NullPointerException。可以为捕获的异常、未捕获的异常或两者都选择一个特定的异常类型及其子类。",
     "java.debugger.configuration.exceptionBreakpoint.allowClasses": "指定允许异常断点中断的位置。支持通配符，例如 java.，.Foo",

src/configurationProvider.ts

@@ -814,7 +814,7 @@ async function updateDebugSettings(event?: vscode.ConfigurationChangeEvent) {
 
 function needsBuildWorkspace(): boolean {
     const javaConfig: vscode.WorkspaceConfiguration = vscode.workspace.getConfiguration("java");
-    return !javaConfig?.autobuild?.enabled || javaConfig?.debug?.settings?.forceBuildBeforeLaunch;
+    return javaConfig?.debug?.settings?.forceBuildBeforeLaunch;
 }
 
 function convertLogLevel(commonLogLevel: string) {