One more pass over reducing unnecessary refreshes of PRs view (#7359)

Fixes #7141

Author: alexr00

src/commands.ts

@@ -812,7 +812,6 @@ export function registerCommands(
 					if (value === yes) {
 						try {
 							isDraft = (await pullRequest.setReadyForReview()).isDraft;
-							vscode.commands.executeCommand('pr.refreshList');
 							return isDraft;
 						} catch (e) {
 							vscode.window.showErrorMessage(

src/github/activityBarViewProvider.ts

@@ -441,8 +441,6 @@ export class PullRequestViewProvider extends WebviewViewBase implements vscode.W
 		this._item
 			.setReadyForReview()
 			.then(result => {
-				vscode.commands.executeCommand('pr.refreshList');
-
 				this._replyMessage(message, result);
 			})
 			.catch(e => {

src/github/folderRepositoryManager.ts

@@ -1166,6 +1166,12 @@ export class FolderRepositoryManager extends Disposable {
 			Logger.debug(`Fetch pull request category ${categoryQuery} - enter`, this.id);
 			const { octokit, query, schema } = await githubRepository.ensure();
 
+			/* __GDPR__
+				"pr.search.category" : {
+				}
+			*/
+			this.telemetry.sendTelemetryEvent('pr.search.category');
+
 			const user = (await githubRepository.getAuthenticatedUser()).login;
 			// Search api will not try to resolve repo that redirects, so get full name first
 			repo = await githubRepository.getMetadata();
@@ -1203,7 +1209,7 @@ export class FolderRepositoryManager extends Disposable {
 					// Pull requests fetched with a query can be from any repo.
 					// We need to use the correct GitHubRepository for this PR.
 					return response.repo.createOrUpdatePullRequestModel(
-						await parseGraphQLPullRequest(response.data.repository.pullRequest, response.repo),
+						await parseGraphQLPullRequest(response.data.repository.pullRequest, response.repo), true
 					);
 				})))
 				.filter(item => item !== null) as PullRequestModel[];

src/github/githubRepository.ts

@@ -959,7 +959,7 @@ export class GitHubRepository extends Disposable {
 		}
 	}
 
-	createOrUpdatePullRequestModel(pullRequest: PullRequest): PullRequestModel {
+	createOrUpdatePullRequestModel(pullRequest: PullRequest, silent: boolean = false): PullRequestModel {
 		let model = this._pullRequestModelsByNumber.get(pullRequest.number)?.model;
 		if (model) {
 			model.update(pullRequest);
@@ -969,7 +969,9 @@ export class GitHubRepository extends Disposable {
 			const disposables: vscode.Disposable[] = [];
 			disposables.push(model.onDidChange(() => this._onPullRequestModelChanged(prModel)));
 			this._pullRequestModelsByNumber.set(pullRequest.number, { model, disposables });
-			this._onDidAddPullRequest.fire(model);
+			if (!silent) {
+				this._onDidAddPullRequest.fire(model);
+			}
 		}
 
 		return model;

src/github/pullRequestOverview.ts

@@ -630,8 +630,6 @@ export class PullRequestOverviewPanel extends IssueOverviewPanel<PullRequestMode
 		this._item
 			.setReadyForReview()
 			.then(result => {
-				vscode.commands.executeCommand('pr.refreshList');
-
 				this._replyMessage(message, result);
 			})
 			.catch(e => {