Skip to content

Commit 5594233

Browse files
author
Chris Blackburn
committed
Update README and remove un-necessary gem
1 parent 10c9f3a commit 5594233

4 files changed

Lines changed: 12 additions & 8 deletions

File tree

Gemfile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,3 @@ gem 'pry-nav'
55
gem 'rake'
66
gem 'rubyzip', '~> 1.2.1'
77
gem 'sqlite3'
8-
gem 'nokogiri'

Gemfile.lock

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,6 @@ GEM
55
method_source (0.8.2)
66
midwire_common (0.1.16)
77
thor (~> 0.19)
8-
mini_portile2 (2.3.0)
9-
nokogiri (1.8.1)
10-
mini_portile2 (~> 2.3.0)
118
pry (0.10.4)
129
coderay (~> 1.1.0)
1310
method_source (~> 0.8.1)
@@ -25,7 +22,6 @@ PLATFORMS
2522

2623
DEPENDENCIES
2724
midwire_common
28-
nokogiri
2925
pry-nav
3026
rake
3127
rubyzip (~> 1.2.1)

README.md

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ See the GeoNames [readme.txt](http://download.geonames.org/export/zip/readme.txt
2121
```bash
2222
$ git clone https://github.com/midwire/free_zipcode_data
2323
$ cd free_zipcode_data
24+
$ bundle install
2425
```
2526

2627
Determine the countries you want to use at [GeoNames](http://download.geonames.org/export/zip/), or just use the rake task without any `country` argument to get zipcode data for all countries...
@@ -39,7 +40,7 @@ $ rake data:build[country]
3940
```
4041

4142
```bash
42-
# populate_db will automatically download the zips and build the .csv files
43+
# populate_db will automatically download the zips and build the sqlite3 db
4344
$ rake data:populate_db[country]
4445
# rake data:populate_db - ALL countries - WARNING: takes a long time
4546
```
@@ -96,6 +97,15 @@ The zipcode data is licensed under a <a rel="license" href="http://creativecommo
9697

9798
## Errata
9899

100+
### 10/28/2017:
101+
102+
* Removed old .csv files
103+
* Add template files (CODE_OF_CONDUCT.md, CONTRIBUTING.md, ISSUE_TEMPLATE.md, LICENSE.md, PULL_REQUEST_TEMPLATE.md)
104+
* Use new data provider - [GeoNames](http://www.geonames.org)
105+
* Test USA
106+
* Started to test `allCountries.zip` but it takes too long. Let me know if there are any bugs.
107+
* Create `country_lookup_table.yml` for country code lookups
108+
99109
### 05/04/2011:
100110

101111
* Removed un-assigned zipcodes, which were not valid for today

lib/tasks/data.rake

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,9 @@ require 'sqlite3'
33
require 'csv'
44
require 'open-uri'
55
require 'zip'
6-
require 'nokogiri'
76
require 'yaml'
87
require 'midwire_common/string'
9-
require 'pry'
8+
# require 'pry'
109

1110
# rubocop:disable Metrics/BlockLength
1211
namespace :data do

0 commit comments

Comments
 (0)