fix: include schemas from all documents in dependency graph (#227)

previously schemas loaded from other documents like `$ref:
'./common.yaml#/components/schemas/FooBar'` were not always correctly
considered when building the schema dependency graph.

this meant that you could have schemas output in an ordering that would
not build, due to variables not having been initialized.

Author: mnahkies

integration-tests/typescript-koa/src/generated/todo-lists.yaml/schemas.ts

@@ -106,6 +106,7 @@ export function buildDependencyGraph(
    * Create an object mapping name -> Set(direct dependencies)
    */
   const dependencyGraph = Object.fromEntries(
+    // TODO: this may miss extracted in-line schemas
     Object.entries(input.allSchemas()).map(([name, schema]) => {
       return [
         getNameForRef({$ref: name}),

packages/openapi-code-generator/src/core/dependency-graph.ts

@@ -36,6 +36,7 @@ import {
 
 export type OperationGroup = {name: string; operations: IROperation[]}
 export type OperationGroupStrategy = "none" | "first-tag" | "first-slug"
+
 export class Input {
   constructor(
     readonly loader: OpenapiLoader,
@@ -47,7 +48,17 @@ export class Input {
   }
 
   allSchemas(): Record<string, IRModel> {
-    const schemas = this.loader.entryPoint.components?.schemas ?? {}
+    const allDocuments = this.loader.allDocuments()
+
+    const schemas = allDocuments.reduce(
+      (acc, it) => {
+        return Object.assign(acc, it.components?.schemas ?? {})
+      },
+      {} as {
+        [schemaName: string]: Schema | Reference
+      },
+    )
+
     return Object.fromEntries(
       Object.entries(schemas).map(([name, maybeSchema]) => {
         return [name, this.schema(normalizeSchemaObject(maybeSchema))]

packages/openapi-code-generator/src/core/input.ts

@@ -21,8 +21,7 @@ import type {OpenapiValidator} from "./openapi-validator"
 
 export class OpenapiLoader {
   private readonly virtualLibrary = new Map<string, VirtualDefinition>()
-  // biome-ignore lint/suspicious/noExplicitAny: <explanation>
-  private readonly library = new Map<string, any>()
+  private readonly library = new Map<string, OpenapiDocument>()
 
   private constructor(
     private readonly entryPointKey: string,
@@ -50,6 +49,10 @@ export class OpenapiLoader {
     return this.library.get(this.entryPointKey)!
   }
 
+  allDocuments(): OpenapiDocument[] {
+    return Array.from(this.library.values())
+  }
+
   paths(maybeRef: Reference | Path): Path {
     return isRef(maybeRef) ? this.$ref(maybeRef) : maybeRef
   }
@@ -81,7 +84,8 @@ export class OpenapiLoader {
   private $ref<T>({$ref}: Reference): T {
     const [key, objPath] = $ref.split("#")
 
-    const obj = key && this.library.get(key)
+    // biome-ignore lint/suspicious/noExplicitAny: <explanation>
+    const obj: any = key && this.library.get(key)
 
     if (!obj) {
       throw new Error(`could not load $ref, key not loaded. $ref: '${$ref}'`)