Skip to content

Commit 73ebaef

Browse files
author
Flavio Crisciani
committed
Avoid flakiness of TestLinkContainers
Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com>
1 parent f81e09a commit 73ebaef

2 files changed

Lines changed: 10 additions & 7 deletions

File tree

drivers/bridge/bridge_test.go

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,9 @@ func getIPv4Data(t *testing.T, iface string) []driverapi.IPAMData {
181181
}
182182

183183
func TestCreateFullOptions(t *testing.T) {
184-
defer testutils.SetupTestOSContext(t)()
184+
if !testutils.IsRunningInContainer() {
185+
defer testutils.SetupTestOSContext(t)()
186+
}
185187
d := newDriver()
186188

187189
config := &configuration{
@@ -604,8 +606,9 @@ func TestQueryEndpointInfoHairpin(t *testing.T) {
604606
}
605607

606608
func testQueryEndpointInfo(t *testing.T, ulPxyEnabled bool) {
607-
defer testutils.SetupTestOSContext(t)()
608-
609+
if !testutils.IsRunningInContainer() {
610+
defer testutils.SetupTestOSContext(t)()
611+
}
609612
d := newDriver()
610613

611614
config := &configuration{

iptables/iptables.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -151,11 +151,11 @@ func ProgramChain(c *ChainInfo, bridgeName string, hairpinMode, enable bool) err
151151
"-j", c.Name}
152152
if !Exists(Nat, "PREROUTING", preroute...) && enable {
153153
if err := c.Prerouting(Append, preroute...); err != nil {
154-
return fmt.Errorf("Failed to inject docker in PREROUTING chain: %s", err)
154+
return fmt.Errorf("Failed to inject %s in PREROUTING chain: %s", c.Name, err)
155155
}
156156
} else if Exists(Nat, "PREROUTING", preroute...) && !enable {
157157
if err := c.Prerouting(Delete, preroute...); err != nil {
158-
return fmt.Errorf("Failed to remove docker in PREROUTING chain: %s", err)
158+
return fmt.Errorf("Failed to remove %s in PREROUTING chain: %s", c.Name, err)
159159
}
160160
}
161161
output := []string{
@@ -167,11 +167,11 @@ func ProgramChain(c *ChainInfo, bridgeName string, hairpinMode, enable bool) err
167167
}
168168
if !Exists(Nat, "OUTPUT", output...) && enable {
169169
if err := c.Output(Append, output...); err != nil {
170-
return fmt.Errorf("Failed to inject docker in OUTPUT chain: %s", err)
170+
return fmt.Errorf("Failed to inject %s in OUTPUT chain: %s", c.Name, err)
171171
}
172172
} else if Exists(Nat, "OUTPUT", output...) && !enable {
173173
if err := c.Output(Delete, output...); err != nil {
174-
return fmt.Errorf("Failed to inject docker in OUTPUT chain: %s", err)
174+
return fmt.Errorf("Failed to inject %s in OUTPUT chain: %s", c.Name, err)
175175
}
176176
}
177177
case Filter:

0 commit comments

Comments
 (0)