Skip to content

Commit ac3dc76

Browse files
committed
Fix flakiness in dnet_exec
With docker 1.11 based dnet tests, the dnet_exec is sometimes exiting with exit code 129 because the process is getting a SIGHUP. Although the reason or source of the SIGHUP is unknown, it is making the tests flaky because non-zero exit code. Fixed it by trapping SIGHUP inside the container so that we can run the test code successfully. Signed-off-by: Jana Radhakrishnan <mrjana@docker.com>
1 parent 9120d4d commit ac3dc76

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

test/integration/dnet/helpers.bash

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,7 @@ function dnet_cmd() {
254254
}
255255

256256
function dnet_exec() {
257-
docker exec -it ${1} bash -c "$2"
257+
docker exec -it ${1} bash -c "trap \"echo SIGHUP\" SIGHUP; $2"
258258
}
259259

260260
function runc() {

0 commit comments

Comments
 (0)