Skip to content

Commit 283caf9

Browse files
Copilotericstjstephentoub
authored
Fix race condition in AutomaticInputRequiredStatusTests polling logic (#1223)
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: ericstj <8918108+ericstj@users.noreply.github.com> Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com>
1 parent f9dec13 commit 283caf9

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

tests/ModelContextProtocol.Tests/Server/AutomaticInputRequiredStatusTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ public async Task TaskStatus_TransitionsToInputRequired_DuringSampleAsync()
119119
finalStatus = await taskStore.GetTaskAsync(mcpTask.TaskId, cancellationToken: TestContext.Current.CancellationToken);
120120
maxAttempts--;
121121
}
122-
while (finalStatus?.Status == McpTaskStatus.Working && maxAttempts > 0);
122+
while (finalStatus?.Status is not McpTaskStatus.Completed && maxAttempts > 0);
123123

124124
// Assert - Status should have been InputRequired during sampling
125125
Assert.Contains(McpTaskStatus.InputRequired, statusesDuringSampling);
@@ -218,7 +218,7 @@ public async Task TaskStatus_TransitionsToInputRequired_DuringElicitAsync()
218218
finalStatus = await taskStore.GetTaskAsync(mcpTask.TaskId, cancellationToken: TestContext.Current.CancellationToken);
219219
maxAttempts--;
220220
}
221-
while (finalStatus?.Status == McpTaskStatus.Working && maxAttempts > 0);
221+
while (finalStatus?.Status is not McpTaskStatus.Completed && maxAttempts > 0);
222222

223223
// Assert - Status should have been InputRequired during elicitation
224224
Assert.Contains(McpTaskStatus.InputRequired, statusesDuringElicitation);

0 commit comments

Comments
 (0)