Merge branch 'master' into stylelint

Author: Miodec

.github/workflows/monkey-ci.yml

@@ -7,8 +7,6 @@ env:
 
 permissions:
   contents: read
-  issues: write
-  pull-requests: write
 
 on:
   pull_request:
@@ -39,7 +37,7 @@ jobs:
         if: github.event_name != 'pull_request'
 
       - name: Detect changes
-        uses: dorny/paths-filter@v3
+        uses: dorny/paths-filter@v4
         id: filter
         with:
           filters: |
@@ -56,8 +54,6 @@ jobs:
               - 'packages/**/*'
             anti-cheat:
               - 'backend/**/anticheat/**'
-            workflows:
-              - '.github/workflows/**/*'
 
       - name: Check Anti-cheat
         if: steps.filter.outputs.anti-cheat == 'true' && !contains(github.event.pull_request.labels.*.name, 'force-ci') && !contains(github.event.pull_request.labels.*.name, 'force-full-ci')
@@ -229,7 +225,7 @@ jobs:
             frontend
             packages
 
-      - uses: dorny/paths-filter@v3
+      - uses: dorny/paths-filter@v4
         id: filter
         with:
           filters: |
@@ -342,7 +338,6 @@ jobs:
         run: npm run test-pkg
 
   on-failure:
-    permissions: write-all
     name: on-failure
     runs-on: ubuntu-latest
     needs: [ci-be, ci-fe, ci-assets, ci-pkg]

backend/package.json

@@ -45,7 +45,7 @@
     "mjml": "4.15.0",
     "mongodb": "6.3.0",
     "mustache": "4.2.0",
-    "nodemailer": "7.0.11",
+    "nodemailer": "8.0.4",
     "object-hash": "3.0.0",
     "prom-client": "15.1.3",
     "rate-limiter-flexible": "5.0.3",
@@ -80,8 +80,8 @@
     "@vitest/coverage-v8": "4.0.15",
     "concurrently": "8.2.2",
     "openapi3-ts": "2.0.2",
-    "oxlint": "1.57.0",
-    "oxlint-tsgolint": "0.17.3",
+    "oxlint": "1.59.0",
+    "oxlint-tsgolint": "0.20.0",
     "readline-sync": "1.4.10",
     "supertest": "7.1.4",
     "testcontainers": "11.11.0",

frontend/__tests__/__harness__/mock-firebase.ts

@@ -2,5 +2,4 @@ import { vi } from "vitest";
 vi.mock("../../src/ts/firebase", () => ({
   app: undefined,
   Auth: undefined,
-  isAuthenticated: () => false,
 }));

frontend/__tests__/components/common/AsyncContent.spec.tsx

@@ -56,6 +56,17 @@ describe("AsyncContent", () => {
       expect(preloader).not.toBeInTheDocument();
     });
 
+    it("renders on resolve with object containing null", async () => {
+      const { container } = renderWithQuery({
+        result: { text: "Test Data", extra: null } as any,
+      });
+
+      await waitFor(() => {
+        expect(screen.getByTestId("content")).toBeVisible();
+      });
+      expect(container.innerHTML).toContain("static content");
+    });
+
     it("renders default error message on fail", async () => {
       const error = new Error("Test error");
       renderWithQuery({ result: error });
@@ -152,7 +163,7 @@ describe("AsyncContent", () => {
           <AsyncContent query={myQuery} {...(options as Props<string>)}>
             {(data: string | undefined) => (
               <>
-                foo
+                static content
                 <Show when={data !== undefined} fallback={<div>no data</div>}>
                   <div data-testid="content">{data}</div>
                 </Show>

frontend/__tests__/components/common/Conditional.spec.tsx

@@ -119,7 +119,7 @@ describe("Conditional", () => {
 
   describe("reactivity", () => {
     it("switches from else to then when if becomes truthy", async () => {
-      const [condition, setCondition] = createSignal<boolean>(false);
+      const [condition, setCondition] = createSignal(false);
 
       render(() => (
         <Conditional
@@ -139,7 +139,7 @@ describe("Conditional", () => {
     });
 
     it("switches from then to else when if becomes falsy", async () => {
-      const [condition, setCondition] = createSignal<boolean>(true);
+      const [condition, setCondition] = createSignal(true);
 
       render(() => (
         <Conditional

frontend/__tests__/components/common/anime/AnimeConditional.spec.tsx

@@ -71,7 +71,7 @@ describe("AnimeConditional", () => {
   });
 
   it("switches reactively from `then` to `else`", () => {
-    const [condition, setCondition] = createSignal<boolean>(true);
+    const [condition, setCondition] = createSignal(true);
 
     render(() => (
       <AnimeConditional
@@ -90,7 +90,7 @@ describe("AnimeConditional", () => {
   });
 
   it("switches reactively from `else` to `then`", () => {
-    const [condition, setCondition] = createSignal<boolean>(false);
+    const [condition, setCondition] = createSignal(false);
 
     render(() => (
       <AnimeConditional
@@ -134,7 +134,7 @@ describe("AnimeConditional", () => {
   });
 
   it("does not throw on mount/unmount", () => {
-    const [show, setShow] = createSignal<boolean>(true);
+    const [show, setShow] = createSignal(true);
 
     expect(() => {
       render(() => (

frontend/__tests__/components/ui/form/InputField.spec.tsx

@@ -23,13 +23,6 @@ function makeField(name: string, value = "") {
 }
 
 describe("InputField", () => {
-  it("uses field name as default placeholder", () => {
-    const field = makeField("username");
-    render(() => <InputField field={() => field} />);
-
-    expect(screen.getByPlaceholderText("username")).toBeInTheDocument();
-  });
-
   it("uses custom placeholder when provided", () => {
     const field = makeField("email");
     render(() => <InputField field={() => field} placeholder="Enter email" />);

frontend/package.json

@@ -108,8 +108,8 @@
     "madge": "8.0.0",
     "magic-string": "0.30.17",
     "normalize.css": "8.0.1",
-    "oxlint": "1.57.0",
-    "oxlint-tsgolint": "0.17.3",
+    "oxlint": "1.59.0",
+    "oxlint-tsgolint": "0.20.0",
     "postcss": "8.5.8",
     "sass": "1.70.0",
     "solid-devtools": "0.34.5",
@@ -119,7 +119,7 @@
     "tsx": "4.21.0",
     "typescript": "6.0.2",
     "unplugin-inject-preload": "3.0.0",
-    "vite": "8.0.1",
+    "vite": "8.0.5",
     "vite-bundle-visualizer": "1.2.1",
     "vite-plugin-html-inject": "1.1.2",
     "vite-plugin-inspect": "11.3.3",

frontend/src/styles/caret.scss

@@ -75,6 +75,7 @@
     background: transparent;
     border: 0.05em solid var(--caret-color);
     border-radius: 0.05em;
+    outline-style: none !important; // override tailwind class of the same name
   }
 
   &.underline {

frontend/src/ts/ape/config.ts

@@ -1,5 +1,5 @@
 import { Config } from "@monkeytype/schemas/configs";
-import { isAuthenticated } from "../firebase";
+import { isAuthenticated } from "../states/core";
 import { showErrorNotification } from "../states/notifications";
 import Ape from ".";