Rebase on Github revision support

Author: vrigal

bot/code_review_bot/revisions/github.py

@@ -2,6 +2,8 @@
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
+from urllib.parse import urlparse
+
 import requests
 import structlog
 
@@ -32,6 +34,13 @@ def __str__(self):
     def __repr__(self):
         return f"GithubRevision repo_url={self.repo_url} branch={self.branch} pull_number={self.pull_number} sha={self.pull_head_sha}"
 
+    @property
+    def repo_name(self):
+        """
+        Extract the name of the repository from its URL
+        """
+        return urlparse(self.repo_url).path.strip("/")
+
     def load_patch(self):
         """
         Load the patch content for the current pull request HEAD

bot/code_review_bot/sources/github.py

@@ -8,7 +8,7 @@
 from github.PullRequest import ReviewComment
 
 from code_review_bot import Issue
-from code_review_bot.revisions.base import Revision
+from code_review_bot.revisions import GithubRevision
 
 
 class GithubClient:
@@ -41,14 +41,16 @@ def _build_review_comment(self, issue):
             body=issue.message,
         )
 
-    def publish_review(self, issues: list[Issue], revision: Revision, message: str):
+    def publish_review(
+        self, issues: list[Issue], revision: GithubRevision, message: str
+    ):
         """
         Publish a review from a list of publishable issues, requesting changes to the author.
         """
-        repo = self.api.get_repo(revision.repository)
-        pull_request = repo.get_pull(revision.pull_id)
+        repo = self.api.get_repo(revision.repo_name)
+        pull_request = repo.get_pull(revision.pull_number)
         pull_request.create_review(
-            commit=repo.get_commit(revision.commit),
+            commit=repo.get_commit(revision.pull_head_sha),
             body=message,
             comments=[self._build_review_comment(issue) for issue in issues],
             # https://docs.github.com/en/rest/pulls/reviews?apiVersion=2022-11-28#create-a-review-for-a-pull-request

bot/github_comment.py

@@ -2,7 +2,7 @@
 import sys
 
 from code_review_bot.report.github import GithubReporter
-from code_review_bot.revisions.base import Revision
+from code_review_bot.revisions import GithubRevision
 from code_review_bot.tasks.clang_tidy import ClangTidyIssue, ClangTidyTask
 
 
@@ -52,12 +52,12 @@ def main():
     Initialize a Github reporter and publish issues
     """
     reporter = GithubReporter(get_configuration())
-    revision = Revision()
-
-    # Add the attributes that will be supported by GithubRevision
-    revision.repository = "vrigal/test-dev-mozilla"
-    revision.commit = "da4ed2eccaff01034c1c2091d2797d55bc0c57cf"
-    revision.pull_id = 3
+    revision = GithubRevision(
+        repo_url="https://github.com/vrigal/test-dev-mozilla",
+        branch="reporter-demo",
+        pull_head_sha="da4ed2eccaff01034c1c2091d2797d55bc0c57cf",
+        pull_number=3,
+    )
 
     analyzer = mock_task(ClangTidyTask, "source-test-clang-tidy")
     issue1 = ClangTidyIssue(