Fix clang-tidy warnings and update config

Author: mphe

.clang-tidy

@@ -10,6 +10,8 @@ Checks:
   - -cppcoreguidelines-avoid-non-const-global-variables
   - -cppcoreguidelines-owning-memory
   - -cppcoreguidelines-non-private-member-variables-in-classes
+  - -cppcoreguidelines-pro-type-union-access  # False positives when accessing Vector2 coordinates
+  - -cppcoreguidelines-use-default-member-init
   - misc-*
   - -misc-non-private-member-variables-in-classes
   - -misc-use-anonymous-namespace
@@ -24,3 +26,5 @@ Checks:
   - -readability-implicit-bool-conversion
   - -readability-math-missing-parentheses
   - -readability-avoid-unconditional-preprocessor-if
+CheckOptions:
+  performance-unnecessary-value-param.AllowedTypes: Ref

.clangd

@@ -4,3 +4,6 @@ CompileFlags:
   Add:
     - -Wall
     - -Wextra
+Diagnostics:
+  ClangTidy:
+    FastCheckFilter: None

run_clang_tidy.sh

@@ -2,4 +2,10 @@
 
 cd "$(dirname "$(readlink -f "$0")")" || exit 1
 
-clang-tidy src/*.cpp --config-file .clang-tidy -p .
+echo "Checks: '-*'" > ./godot-cpp/.clang-tidy
+
+if [ -t 0 ]; then
+    run-clang-tidy -header-filter=src/ -allow-no-checks -use-color 1 -quiet "$@"
+else
+    run-clang-tidy -header-filter=src/ -allow-no-checks -quiet "$@"
+fi

src/NativeRopeServer.cpp

@@ -59,7 +59,7 @@ void NativeRopeServer::register_rope(Node2D* rope)
 
 void NativeRopeServer::unregister_rope(Node2D* rope)
 {
-    const int idx = _ropes.find(rope);
+    const int64_t idx = _ropes.find(rope);
 
     if (idx < 0)
     {
@@ -68,7 +68,7 @@ void NativeRopeServer::unregister_rope(Node2D* rope)
     }
 
     // Swap and pop
-    const int last_idx = _ropes.size() - 1;
+    const int64_t last_idx = _ropes.size() - 1;
     _ropes.set(idx, _ropes[last_idx]);
     _ropes.remove_at(last_idx);
 
@@ -151,7 +151,7 @@ float NativeRopeServer::get_computation_time() const
     return _last_time;
 }
 
-int NativeRopeServer::get_num_ropes() const
+int64_t NativeRopeServer::get_num_ropes() const
 {
     return _ropes.size();
 }

src/NativeRopeServer.hpp

@@ -8,7 +8,7 @@
 
 namespace godot
 {
-    class NativeRopeServer : public Object
+    class NativeRopeServer : public Object  // NOLINT(cppcoreguidelines-special-member-functions)
     {
         GDCLASS(NativeRopeServer, Object)  // NOLINT
 
@@ -24,7 +24,7 @@ namespace godot
             void set_update_in_editor(bool value);
             bool get_update_in_editor() const;
 
-            int get_num_ropes() const;
+            int64_t get_num_ropes() const;
             float get_computation_time() const;
 
         protected:

src/RopeWindParameters.hpp

@@ -6,7 +6,7 @@
 
 namespace godot
 {
-    class RopeWindParameters : public Resource
+    class RopeWindParameters : public Resource  // NOLINT(cppcoreguidelines-special-member-functions)
     {
         GDCLASS(RopeWindParameters, Resource) // NOLINT
 
@@ -36,4 +36,4 @@ namespace godot
     };
 }
 
-#endif
+#endif

src/gdlibrary.cpp

@@ -35,6 +35,7 @@ void uninitialize_libropesim(ModuleInitializationLevel p_level) {
 
 extern "C" {
     // Initialization.
+    // NOLINTNEXTLINE(misc-misplaced-const)
     GDExtensionBool GDE_EXPORT libropesim_init(GDExtensionInterfaceGetProcAddress p_get_proc_address, const GDExtensionClassLibraryPtr p_library, GDExtensionInitialization *r_initialization) {
         const godot::GDExtensionBinding::InitObject init_obj(p_get_proc_address, p_library, r_initialization);