Skip to content

Commit a38e01b

Browse files
committed
ci: fix developer id release signing
1 parent ec11381 commit a38e01b

1 file changed

Lines changed: 4 additions & 5 deletions

File tree

.github/workflows/build.yml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,6 @@ jobs:
6767
archive \
6868
MARKETING_VERSION="${{ steps.version.outputs.marketing_version }}" \
6969
CURRENT_PROJECT_VERSION="${{ steps.version.outputs.marketing_version }}" \
70-
CODE_SIGN_IDENTITY="Developer ID Application" \
71-
OTHER_CODE_SIGN_FLAGS="--keychain $RUNNER_TEMP/app-signing.keychain-db" \
7270
STRIP_INSTALLED_PRODUCT=YES \
7371
DEAD_CODE_STRIPPING=YES \
7472
DEBUG_INFORMATION_FORMAT=dwarf-with-dsym \
@@ -101,8 +99,7 @@ jobs:
10199
-exportArchive \
102100
-archivePath build/Wave.xcarchive \
103101
-exportPath build/export \
104-
-exportOptionsPlist "$RUNNER_TEMP/ExportOptions.plist" \
105-
OTHER_CODE_SIGN_FLAGS="--keychain $RUNNER_TEMP/app-signing.keychain-db"
102+
-exportOptionsPlist "$RUNNER_TEMP/ExportOptions.plist"
106103
107104
- name: Debug app size
108105
run: |
@@ -193,7 +190,9 @@ jobs:
193190
- name: Sign DMG
194191
run: |
195192
DMG_NAME="${{ steps.dmg.outputs.dmg_name }}"
196-
codesign --force --sign "Developer ID Application" --keychain "$RUNNER_TEMP/app-signing.keychain-db" "$DMG_NAME"
193+
SIGNING_IDENTITY=$(security find-identity -v -p codesigning "$RUNNER_TEMP/app-signing.keychain-db" | awk -F '"' '/Developer ID Application/ { print $2; exit }')
194+
test -n "$SIGNING_IDENTITY"
195+
codesign --force --sign "$SIGNING_IDENTITY" --keychain "$RUNNER_TEMP/app-signing.keychain-db" "$DMG_NAME"
197196
codesign --verify --verbose=2 "$DMG_NAME"
198197
199198
- name: Notarize and staple DMG

0 commit comments

Comments
 (0)