feat: more tests for getter/setter detections

Author: AvarianKnight

tests/NativeCodeGen.Tests/Generation/GetterProxyTests.cs

@@ -0,0 +1,112 @@
+using NativeCodeGen.Core.Generation;
+using NativeCodeGen.Core.Models;
+using NativeCodeGen.Core.Utilities;
+using NativeCodeGen.TypeScript;
+
+namespace NativeCodeGen.Tests.Generation;
+
+public class GetterProxyTests
+{
+    [Fact]
+    public void GetterProxy_GeneratedWhenAllParamsOptional()
+    {
+        var emitter = new TypeScriptEmitter();
+        var generator = new SharedClassGenerator(emitter);
+
+        // Create a native with optional parameters
+        var native = new NativeDefinition
+        {
+            Name = "GET_COORDS",
+            Hash = "0x12345678",
+            Parameters =
+            [
+                new NativeParameter
+                {
+                    Name = "alive",
+                    Type = new TypeInfo { Name = "BOOL", Category = TypeCategory.Primitive },
+                    DefaultValue = "false"  // Has default value
+                },
+                new NativeParameter
+                {
+                    Name = "realCoords",
+                    Type = new TypeInfo { Name = "BOOL", Category = TypeCategory.Primitive },
+                    DefaultValue = "false"  // Has default value
+                }
+            ],
+            ReturnType = new TypeInfo { Name = "Vector3", Category = TypeCategory.Struct }
+        };
+
+        var result = generator.GenerateHandleClass("Entity", null, [native]);
+
+        // Should have both the function and the getter proxy
+        Assert.Contains("getCoords(alive?: boolean, realCoords?: boolean): Vector3", result);
+        Assert.Contains("get Coords(): Vector3 {", result);
+        Assert.Contains("return this.getCoords();", result);
+    }
+
+    [Fact]
+    public void GetterProxy_NotGeneratedWhenParamsRequired()
+    {
+        var emitter = new TypeScriptEmitter();
+        var generator = new SharedClassGenerator(emitter);
+
+        // Create a native with required parameters (no defaults)
+        var native = new NativeDefinition
+        {
+            Name = "GET_COORDS",
+            Hash = "0x12345678",
+            Parameters =
+            [
+                new NativeParameter
+                {
+                    Name = "alive",
+                    Type = new TypeInfo { Name = "BOOL", Category = TypeCategory.Primitive }
+                    // No DefaultValue - required param
+                }
+            ],
+            ReturnType = new TypeInfo { Name = "Vector3", Category = TypeCategory.Struct }
+        };
+
+        var result = generator.GenerateHandleClass("Entity", null, [native]);
+
+        // Should have the function but NOT the getter proxy
+        Assert.Contains("getCoords(alive: boolean): Vector3", result);
+        Assert.DoesNotContain("get Coords()", result);
+    }
+
+    [Fact]
+    public void GetterProxy_NotGeneratedWhenMixedParams()
+    {
+        var emitter = new TypeScriptEmitter();
+        var generator = new SharedClassGenerator(emitter);
+
+        // Create a native with mixed params (one required, one optional)
+        var native = new NativeDefinition
+        {
+            Name = "GET_DATA",
+            Hash = "0x12345678",
+            Parameters =
+            [
+                new NativeParameter
+                {
+                    Name = "id",
+                    Type = new TypeInfo { Name = "int", Category = TypeCategory.Primitive }
+                    // Required
+                },
+                new NativeParameter
+                {
+                    Name = "includeExtra",
+                    Type = new TypeInfo { Name = "BOOL", Category = TypeCategory.Primitive },
+                    DefaultValue = "true"  // Optional
+                }
+            ],
+            ReturnType = new TypeInfo { Name = "int", Category = TypeCategory.Primitive }
+        };
+
+        var result = generator.GenerateHandleClass("Test", null, [native]);
+
+        // Should have the function but NOT the getter proxy (not all params optional)
+        Assert.Contains("getData(", result);
+        Assert.DoesNotContain("get Data()", result);
+    }
+}

tests/NativeCodeGen.Tests/Utilities/NameConverterGetterTests.cs

@@ -0,0 +1,36 @@
+using NativeCodeGen.Core.Utilities;
+
+namespace NativeCodeGen.Tests.Utilities;
+
+public class NameConverterGetterTests
+{
+    [Theory]
+    [InlineData("getHealth", true, "Health")]
+    [InlineData("getName", true, "Name")]
+    [InlineData("getTeam", true, "Team")]
+    [InlineData("isMale", true, "IsMale")]
+    [InlineData("isAttached", true, "IsAttached")]
+    [InlineData("isAttachedToAnyObject", true, "IsAttachedToAnyObject")]
+    [InlineData("setHealth", false, "setHealth")]
+    [InlineData("get", false, "get")]
+    [InlineData("getA", true, "A")]
+    [InlineData("is", false, "is")]
+    [InlineData("isA", true, "IsA")]
+    public void IsGetterName_DetectsGettersCorrectly(string methodName, bool expectedIsGetter, string expectedPropertyName)
+    {
+        Assert.Equal(expectedIsGetter, NameConverter.IsGetterName(methodName));
+        Assert.Equal(expectedPropertyName, NameConverter.GetterToPropertyName(methodName));
+    }
+
+    [Theory]
+    [InlineData("setHealth", true, "Health")]
+    [InlineData("setName", true, "Name")]
+    [InlineData("getHealth", false, "getHealth")]
+    [InlineData("set", false, "set")]
+    [InlineData("setA", true, "A")]
+    public void IsSetterName_DetectsSettersCorrectly(string methodName, bool expectedIsSetter, string expectedPropertyName)
+    {
+        Assert.Equal(expectedIsSetter, NameConverter.IsSetterName(methodName));
+        Assert.Equal(expectedPropertyName, NameConverter.SetterToPropertyName(methodName));
+    }
+}