refactor: extract flagged save facade

Author: ndycode

lib/storage.ts

@@ -31,11 +31,9 @@ import {
 } from "./storage/backup-paths.js";
 import { restoreAccountsFromBackupPath } from "./storage/backup-restore.js";
 import { looksLikeSyntheticFixtureStorage } from "./storage/fixture-guards.js";
-import {
-	clearFlaggedAccountsEntry,
-	saveFlaggedAccountsEntry,
-} from "./storage/flagged-entry.js";
+import { clearFlaggedAccountsEntry } from "./storage/flagged-entry.js";
 import { loadFlaggedAccountsEntry } from "./storage/flagged-load-entry.js";
+import { saveFlaggedAccountsEntry } from "./storage/flagged-save-entry.js";
 import { normalizeFlaggedStorage } from "./storage/flagged-storage.js";
 import {
 	clearFlaggedAccountsOnDisk,

lib/storage/flagged-save-entry.ts

@@ -0,0 +1,11 @@
+import type { FlaggedAccountStorageV1 } from "../storage.js";
+
+export async function saveFlaggedAccountsEntry(params: {
+	storage: FlaggedAccountStorageV1;
+	withStorageLock: <T>(fn: () => Promise<T>) => Promise<T>;
+	saveUnlocked: (storage: FlaggedAccountStorageV1) => Promise<void>;
+}): Promise<void> {
+	return params.withStorageLock(async () => {
+		await params.saveUnlocked(params.storage);
+	});
+}

test/flagged-save-entry.test.ts

@@ -0,0 +1,15 @@
+import { describe, expect, it, vi } from "vitest";
+import { saveFlaggedAccountsEntry } from "../lib/storage/flagged-save-entry.js";
+
+describe("flagged save entry", () => {
+	it("delegates save through the storage lock", async () => {
+		const saveUnlocked = vi.fn(async () => undefined);
+		await saveFlaggedAccountsEntry({
+			storage: { version: 1, accounts: [] },
+			withStorageLock: async (fn) => fn(),
+			saveUnlocked,
+		});
+
+		expect(saveUnlocked).toHaveBeenCalledWith({ version: 1, accounts: [] });
+	});
+});