Skip to content

Commit 7cb4d4f

Browse files
committed
fix: guard cli refresh token hydration by freshness
1 parent 45a7ee6 commit 7cb4d4f

2 files changed

Lines changed: 6 additions & 2 deletions

File tree

lib/accounts.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,11 @@ export class AccountManager {
188188
changed = true;
189189
}
190190

191-
if (cached.refreshToken && cached.refreshToken !== account.refreshToken) {
191+
if (
192+
cachedAccessUsable &&
193+
cached.refreshToken &&
194+
cached.refreshToken !== account.refreshToken
195+
) {
192196
account.refreshToken = cached.refreshToken;
193197
changed = true;
194198
}

test/accounts-edge.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ describe("accounts edge branches", () => {
188188

189189
const expired = snapshot[1];
190190
expect(expired?.access).toBe("existing-access");
191-
expect(expired?.refreshToken).toBe("expired-refresh-updated");
191+
expect(expired?.refreshToken).toBe("refresh-2");
192192
expect(expired?.accountId).toBe("expired-id");
193193
expect(expired?.accountIdSource).toBe("token");
194194
});

0 commit comments

Comments
 (0)