Skip to content

Commit 37cbd9a

Browse files
committed
Dumper: removed dead code
1 parent 8674ce8 commit 37cbd9a

1 file changed

Lines changed: 6 additions & 7 deletions

File tree

src/PhpGenerator/Dumper.php

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ public function dump(mixed $var, int $column = 0): string
3535

3636

3737
/** @param array<mixed[]|object> $parents */
38-
private function dumpVar(mixed &$var, array $parents = [], int $level = 0, int $column = 0): string
38+
private function dumpVar(mixed $var, array $parents = [], int $level = 0, int $column = 0): string
3939
{
4040
if ($var === null) {
4141
return 'null';
@@ -101,7 +101,7 @@ private static function utf8Ord(string $c): int
101101
* @param mixed[] $var
102102
* @param array<mixed[]|object> $parents
103103
*/
104-
private function dumpArray(array &$var, array $parents, int $level, int $column): string
104+
private function dumpArray(array $var, array $parents, int $level, int $column): string
105105
{
106106
if (empty($var)) {
107107
return '[]';
@@ -117,7 +117,7 @@ private function dumpArray(array &$var, array $parents, int $level, int $column)
117117
$counter = 0;
118118
$hideKeys = is_int(($tmp = array_keys($var))[0]) && $tmp === range($tmp[0], $tmp[0] + count($var) - 1);
119119

120-
foreach ($var as $k => &$v) {
120+
foreach ($var as $k => $v) {
121121
$keyPart = $hideKeys && $k === $counter
122122
? ''
123123
: $this->dumpVar($k) . ' => ';
@@ -130,7 +130,6 @@ private function dumpArray(array &$var, array $parents, int $level, int $column)
130130
. ",\n$space";
131131
}
132132

133-
array_pop($parents);
134133
$wrap = str_contains($outInline, "\n") || $level * self::IndentLength + $column + strlen($outInline) + 3 > $this->wrapLength; // 3 = [],
135134
return '[' . ($wrap ? $outWrapped : $outInline) . ']';
136135
}
@@ -201,7 +200,7 @@ private function dumpCustomObject(object $var, array $parents, int $level): stri
201200
}
202201
}
203202

204-
foreach ($arr as $k => &$v) {
203+
foreach ($arr as $k => $v) {
205204
if (!isset($props) || isset($props[$k])) {
206205
$out .= $space . $this->indentation
207206
. ($keyPart = $this->dumpVar($k) . ' => ')
@@ -266,11 +265,11 @@ public function format(string $statement, mixed ...$args): string
266265

267266

268267
/** @param mixed[] $var */
269-
private function dumpArguments(array &$var, int $column, bool $named): string
268+
private function dumpArguments(array $var, int $column, bool $named): string
270269
{
271270
$outInline = $outWrapped = '';
272271

273-
foreach ($var as $k => &$v) {
272+
foreach ($var as $k => $v) {
274273
$k = !$named || is_int($k) ? '' : $k . ': ';
275274
$outInline .= $outInline === '' ? '' : ', ';
276275
$outInline .= $k . $this->dumpVar($v, [$var], 0, $column + strlen($outInline));

0 commit comments

Comments
 (0)