added PropertyLike

Author: dg

src/PhpGenerator/PromotedParameter.php

@@ -17,23 +17,7 @@
  */
 final class PromotedParameter extends Parameter
 {
-	use Traits\VisibilityAware;
-
-	private bool $readOnly = false;
-
-
-	public function setReadOnly(bool $state = true): static
-	{
-		$this->readOnly = $state;
-		return $this;
-	}
-
-
-	public function isReadOnly(): bool
-	{
-		return $this->readOnly;
-	}
-
+	use Traits\PropertyLike;
 
 	/** @throws Nette\InvalidStateException */
 	public function validate(): void

src/PhpGenerator/Property.php

@@ -19,7 +19,7 @@
 final class Property
 {
 	use Traits\NameAware;
-	use Traits\VisibilityAware;
+	use Traits\PropertyLike;
 	use Traits\CommentAware;
 	use Traits\AttributeAware;
 
@@ -28,7 +28,6 @@ final class Property
 	private ?string $type = null;
 	private bool $nullable = false;
 	private bool $initialized = false;
-	private bool $readOnly = false;
 
 
 	public function setValue(mixed $val): static
@@ -100,19 +99,6 @@ public function isInitialized(): bool
 	}
 
 
-	public function setReadOnly(bool $state = true): static
-	{
-		$this->readOnly = $state;
-		return $this;
-	}
-
-
-	public function isReadOnly(): bool
-	{
-		return $this->readOnly;
-	}
-
-
 	/** @throws Nette\InvalidStateException */
 	public function validate(): void
 	{

src/PhpGenerator/Traits/PropertyLike.php

@@ -0,0 +1,35 @@
+<?php
+
+/**
+ * This file is part of the Nette Framework (https://nette.org)
+ * Copyright (c) 2004 David Grudl (https://davidgrudl.com)
+ */
+
+declare(strict_types=1);
+
+namespace Nette\PhpGenerator\Traits;
+
+
+
+/**
+ * @internal
+ */
+trait PropertyLike
+{
+	use VisibilityAware;
+
+	private bool $readOnly = false;
+
+
+	public function setReadOnly(bool $state = true): static
+	{
+		$this->readOnly = $state;
+		return $this;
+	}
+
+
+	public function isReadOnly(): bool
+	{
+		return $this->readOnly;
+	}
+}

tests/PhpGenerator/PropertyLike.visiblity.phpt

@@ -0,0 +1,78 @@
+<?php
+
+/**
+ * Test: PropertyLike visibility
+ */
+
+declare(strict_types=1);
+
+use Nette\PhpGenerator\ClassType;
+use Tester\Assert;
+
+require __DIR__ . '/../bootstrap.php';
+
+
+$class = new ClassType('Demo');
+
+// Default visibility (public)
+$default = $class->addProperty('first')
+	->setType('string');
+Assert::true($default->isPublic());
+Assert::false($default->isProtected());
+Assert::false($default->isPrivate());
+Assert::null($default->getVisibility());
+
+// Explicit public
+$public = $class->addProperty('second')
+	->setType('string')
+	->setPublic();
+Assert::true($public->isPublic());
+Assert::false($public->isProtected());
+Assert::false($public->isPrivate());
+Assert::same('public', $public->getVisibility());
+
+// Protected
+$protected = $class->addProperty('third')
+	->setType('string')
+	->setProtected();
+Assert::false($protected->isPublic());
+Assert::true($protected->isProtected());
+Assert::false($protected->isPrivate());
+Assert::same('protected', $protected->getVisibility());
+
+// Private
+$private = $class->addProperty('fourth')
+	->setType('string')
+	->setPrivate();
+Assert::false($private->isPublic());
+Assert::false($private->isProtected());
+Assert::true($private->isPrivate());
+Assert::same('private', $private->getVisibility());
+
+// Change visibility
+$changing = $class->addProperty('fifth')
+	->setType('string')
+	->setPublic();
+$changing->setVisibility('protected');
+Assert::false($changing->isPublic());
+Assert::true($changing->isProtected());
+Assert::false($changing->isPrivate());
+
+// Test invalid visibility
+Assert::exception(
+	fn() => $changing->setVisibility('invalid'),
+	Nette\InvalidArgumentException::class,
+	'Argument must be public|protected|private.',
+);
+
+same(<<<'XX'
+	class Demo
+	{
+		public string $first;
+		public string $second;
+		protected string $third;
+		private string $fourth;
+		protected string $fifth;
+	}
+
+	XX, (string) $class);