fix: apply review suggestions

- merge ranking into grid condition in ApiController
- swap icon to IconSwapVertical
- fix copyright year to 2026
- use v-else for ranked list header
- simplify sort comparison in validation

Signed-off-by: paul bochtler <65470117+datapumpernickel@users.noreply.github.com>

Author: datapumpernickel

lib/Controller/ApiController.php

@@ -1720,23 +1720,7 @@ public function uploadFiles(int $formId, int $questionId, string $shareHash = ''
 	 * @param string[]|array<array{uploadedFileId: string, uploadedFileName: string}> $answerArray
 	 */
 	private function storeAnswersForQuestion(Form $form, $submissionId, array $question, array $answerArray): void {
-		if ($question['type'] === Constants::ANSWER_TYPE_GRID) {
-			if (!$answerArray) {
-				return;
-			}
-
-			$answerEntity = new Answer();
-			$answerEntity->setSubmissionId($submissionId);
-			$answerEntity->setQuestionId($question['id']);
-
-			$answerText = json_encode($answerArray);
-			$answerEntity->setText($answerText);
-			$this->answerMapper->insert($answerEntity);
-
-			return;
-		}
-
-		if ($question['type'] === Constants::ANSWER_TYPE_RANKING) {
+		if ($question['type'] === Constants::ANSWER_TYPE_GRID || $question['type'] === Constants::ANSWER_TYPE_RANKING) {
 			if (!$answerArray) {
 				return;
 			}

lib/Service/SubmissionService.php

@@ -585,11 +585,8 @@ public function validateSubmission(array $questions, array $answers, string $for
 			if ($question['type'] === Constants::ANSWER_TYPE_RANKING) {
 				$optionIds = array_map('intval', array_column($question['options'] ?? [], 'id'));
 				$rankedIds = array_map('intval', $answers[$questionId]);
-				$sortedRanked = $rankedIds;
-				$sortedOptions = $optionIds;
-				sort($sortedRanked);
-				sort($sortedOptions);
-				if ($sortedRanked !== $sortedOptions) {
+
+				if (sort($rankedIds) !== sort($optionIds)) {
 					throw new \InvalidArgumentException(sprintf('Ranking for question "%s" must include all options exactly once.', $question['text']));
 				}
 			}

src/models/AnswerTypes.js

@@ -12,7 +12,7 @@ import IconFile from 'vue-material-design-icons/FileOutline.vue'
 import IconGrid from 'vue-material-design-icons/Grid.vue'
 import IconNumeric from 'vue-material-design-icons/Numeric.vue'
 import IconRadioboxMarked from 'vue-material-design-icons/RadioboxMarked.vue'
-import IconReorderHorizontal from 'vue-material-design-icons/ReorderHorizontal.vue'
+import IconSwapVertical from 'vue-material-design-icons/SwapVertical.vue'
 import IconTextLong from 'vue-material-design-icons/TextLong.vue'
 import IconTextShort from 'vue-material-design-icons/TextShort.vue'
 import IconLinearScale from '../components/Icons/IconLinearScale.vue'
@@ -269,7 +269,7 @@ export default {
 
 	ranking: {
 		component: markRaw(QuestionRanking),
-		icon: markRaw(IconReorderHorizontal),
+		icon: markRaw(IconSwapVertical),		
 		label: t('forms', 'Ranking'),
 		predefined: true,
 		validate: (question) => question.options.length > 0,