fix(Util): getScripts also need to reorder core translations

Currently `core-common` and `core-main` are prepanded to the scripts,
as they provide the global state. But the script ordering logic does not
know about this and might sort core translations after they are used.

Meaning we need to register core translations as soon as the global
scope is initialized (so that `OC.L10N.register` is available).

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

Author: susnux

lib/public/Util.php

@@ -168,16 +168,21 @@ public static function getScripts(): array {
 		// Flatten array and remove duplicates
 		$sortedScripts = array_merge([self::$scriptsInit], $sortedScripts);
 		$sortedScripts = array_merge(...array_values($sortedScripts));
+		$sortedScripts = array_unique($sortedScripts);
 
 		// Override core-common and core-main order
-		if (in_array('core/js/main', $sortedScripts)) {
-			array_unshift($sortedScripts, 'core/js/main');
-		}
-		if (in_array('core/js/common', $sortedScripts)) {
-			array_unshift($sortedScripts, 'core/js/common');
+		function scriptOrder(string $name) {
+			return match($name) {
+				'core/js/common' => 3,
+				'core/js/main' => 2,
+				default => str_starts_with($name, 'core/l10n/')
+					? 1 // core translations have to be loaded directly after core-main
+					: 0, // other scripts should preserve their current order
+			};
 		}
 
-		return array_unique($sortedScripts);
+		usort($sortedScripts, fn (string $a, string $b) => scriptOrder($b) <=> scriptOrder($a));
+		return $sortedScripts;
 	}
 
 	/**