Skip to content

Commit b8c2944

Browse files
jaeyun-jungmyungjoo
authored andcommitted
[Android/CodeClean] name of class info
Code clean, update structure and function name for tensor info and data class. Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
1 parent c4bed3c commit b8c2944

2 files changed

Lines changed: 43 additions & 34 deletions

File tree

java/android/nnstreamer/src/main/jni/nnstreamer-native-api.c

Lines changed: 39 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,8 @@ nns_free_element_data (gpointer data)
107107
* @brief Construct TensorsData class info.
108108
*/
109109
static void
110-
nns_construct_tdata_class_info (JNIEnv * env, data_class_info_s * info)
110+
nns_construct_tensors_data_cls_info (JNIEnv * env,
111+
tensors_data_class_info_s * info)
111112
{
112113
jclass cls;
113114

@@ -129,7 +130,8 @@ nns_construct_tdata_class_info (JNIEnv * env, data_class_info_s * info)
129130
* @brief Destroy TensorsData class info.
130131
*/
131132
static void
132-
nns_destroy_tdata_class_info (JNIEnv * env, data_class_info_s * info)
133+
nns_destroy_tensors_data_cls_info (JNIEnv * env,
134+
tensors_data_class_info_s * info)
133135
{
134136
if (info->cls)
135137
(*env)->DeleteGlobalRef (env, info->cls);
@@ -139,7 +141,8 @@ nns_destroy_tdata_class_info (JNIEnv * env, data_class_info_s * info)
139141
* @brief Construct TensorsInfo class info.
140142
*/
141143
static void
142-
nns_construct_tinfo_class_info (JNIEnv * env, info_class_info_s * info)
144+
nns_construct_tensors_info_cls_info (JNIEnv * env,
145+
tensors_info_class_info_s * info)
143146
{
144147
jclass cls;
145148

@@ -168,7 +171,8 @@ nns_construct_tinfo_class_info (JNIEnv * env, info_class_info_s * info)
168171
* @brief Destroy TensorsInfo class info.
169172
*/
170173
static void
171-
nns_destroy_tinfo_class_info (JNIEnv * env, info_class_info_s * info)
174+
nns_destroy_tensors_info_cls_info (JNIEnv * env,
175+
tensors_info_class_info_s * info)
172176
{
173177
if (info->cls_info)
174178
(*env)->DeleteGlobalRef (env, info->cls_info);
@@ -207,8 +211,8 @@ nns_construct_pipe_info (JNIEnv * env, jobject thiz, gpointer handle,
207211
pipe_info->cls = (*env)->NewGlobalRef (env, cls);
208212
(*env)->DeleteLocalRef (env, cls);
209213

210-
nns_construct_tdata_class_info (env, &pipe_info->data_cls_info);
211-
nns_construct_tinfo_class_info (env, &pipe_info->info_cls_info);
214+
nns_construct_tensors_data_cls_info (env, &pipe_info->tensors_data_cls_info);
215+
nns_construct_tensors_info_cls_info (env, &pipe_info->tensors_info_cls_info);
212216

213217
return pipe_info;
214218
}
@@ -261,8 +265,9 @@ nns_destroy_pipe_info (pipeline_info_s * pipe_info, JNIEnv * env)
261265

262266
g_mutex_clear (&pipe_info->lock);
263267

264-
nns_destroy_tdata_class_info (env, &pipe_info->data_cls_info);
265-
nns_destroy_tinfo_class_info (env, &pipe_info->info_cls_info);
268+
nns_destroy_tensors_data_cls_info (env, &pipe_info->tensors_data_cls_info);
269+
nns_destroy_tensors_info_cls_info (env, &pipe_info->tensors_info_cls_info);
270+
266271
(*env)->DeleteGlobalRef (env, pipe_info->cls);
267272
(*env)->DeleteGlobalRef (env, pipe_info->instance);
268273

@@ -360,19 +365,19 @@ gboolean
360365
nns_create_tensors_data_object (pipeline_info_s * pipe_info, JNIEnv * env,
361366
jobject obj_info, jobject * result)
362367
{
363-
data_class_info_s *dcls_info;
368+
tensors_data_class_info_s *tensors_data_cls;
364369
jobject obj_data;
365370

366371
g_return_val_if_fail (pipe_info, FALSE);
367372
g_return_val_if_fail (env, FALSE);
368373
g_return_val_if_fail (result, FALSE);
369374
g_return_val_if_fail (obj_info, FALSE);
370375

371-
dcls_info = &pipe_info->data_cls_info;
376+
tensors_data_cls = &pipe_info->tensors_data_cls_info;
372377
*result = NULL;
373378

374-
obj_data = (*env)->CallStaticObjectMethod (env, dcls_info->cls,
375-
dcls_info->mid_alloc, obj_info);
379+
obj_data = (*env)->CallStaticObjectMethod (env, tensors_data_cls->cls,
380+
tensors_data_cls->mid_alloc, obj_info);
376381
if ((*env)->ExceptionCheck (env) || !obj_data) {
377382
_ml_loge ("Failed to allocate object for tensors data.");
378383
(*env)->ExceptionClear (env);
@@ -395,7 +400,7 @@ nns_convert_tensors_data (pipeline_info_s * pipe_info, JNIEnv * env,
395400
ml_tensors_data_h data_h, jobject obj_info, jobject * result)
396401
{
397402
guint i;
398-
data_class_info_s *dcls_info;
403+
tensors_data_class_info_s *tensors_data_cls;
399404
jobject obj_data = NULL;
400405
jobjectArray data_arr;
401406
ml_tensors_data_s *data;
@@ -406,14 +411,15 @@ nns_convert_tensors_data (pipeline_info_s * pipe_info, JNIEnv * env,
406411
g_return_val_if_fail (result, FALSE);
407412
g_return_val_if_fail (obj_info, FALSE);
408413

409-
dcls_info = &pipe_info->data_cls_info;
414+
tensors_data_cls = &pipe_info->tensors_data_cls_info;
410415
data = (ml_tensors_data_s *) data_h;
411416
*result = NULL;
412417

413418
if (!nns_create_tensors_data_object (pipe_info, env, obj_info, &obj_data))
414419
return FALSE;
415420

416-
data_arr = (*env)->CallObjectMethod (env, obj_data, dcls_info->mid_get_array);
421+
data_arr = (*env)->CallObjectMethod (env, obj_data,
422+
tensors_data_cls->mid_get_array);
417423

418424
for (i = 0; i < data->num_tensors; i++) {
419425
jobject tensor = (*env)->GetObjectArrayElement (env, data_arr, i);
@@ -438,7 +444,7 @@ nns_parse_tensors_data (pipeline_info_s * pipe_info, JNIEnv * env,
438444
ml_tensors_data_h * data_h)
439445
{
440446
guint i;
441-
data_class_info_s *dcls_info;
447+
tensors_data_class_info_s *tensors_data_cls;
442448
ml_tensors_data_s *data;
443449
jobjectArray data_arr;
444450
gboolean failed = FALSE;
@@ -450,16 +456,16 @@ nns_parse_tensors_data (pipeline_info_s * pipe_info, JNIEnv * env,
450456
g_return_val_if_fail (obj_data, FALSE);
451457
g_return_val_if_fail (data_h, FALSE);
452458

453-
dcls_info = &pipe_info->data_cls_info;
459+
tensors_data_cls = &pipe_info->tensors_data_cls_info;
454460

455461
/* if data is not allocated, create new handle. */
456462
if (*data_h == NULL) {
457463
ml_tensors_info_h _info = info_h;
458464

459465
/* parse tensors info in data class */
460466
if (_info == NULL) {
461-
jobject obj_info =
462-
(*env)->CallObjectMethod (env, obj_data, dcls_info->mid_get_info);
467+
jobject obj_info = (*env)->CallObjectMethod (env, obj_data,
468+
tensors_data_cls->mid_get_info);
463469

464470
if (obj_info) {
465471
nns_parse_tensors_info (pipe_info, env, obj_info, &_info);
@@ -480,7 +486,8 @@ nns_parse_tensors_data (pipeline_info_s * pipe_info, JNIEnv * env,
480486
}
481487

482488
data = (ml_tensors_data_s *) (*data_h);
483-
data_arr = (*env)->CallObjectMethod (env, obj_data, dcls_info->mid_get_array);
489+
data_arr = (*env)->CallObjectMethod (env, obj_data,
490+
tensors_data_cls->mid_get_array);
484491

485492
/* number of tensors data */
486493
data->num_tensors = (unsigned int) (*env)->GetArrayLength (env, data_arr);
@@ -531,7 +538,7 @@ nns_convert_tensors_info (pipeline_info_s * pipe_info, JNIEnv * env,
531538
ml_tensors_info_h info_h, jobject * result)
532539
{
533540
guint i;
534-
info_class_info_s *icls_info;
541+
tensors_info_class_info_s *tensors_info_cls;
535542
ml_tensors_info_s *info;
536543
GstTensorInfo *_info;
537544
jobject obj_info = NULL;
@@ -541,10 +548,11 @@ nns_convert_tensors_info (pipeline_info_s * pipe_info, JNIEnv * env,
541548
g_return_val_if_fail (info_h, FALSE);
542549
g_return_val_if_fail (result, FALSE);
543550

544-
icls_info = &pipe_info->info_cls_info;
551+
tensors_info_cls = &pipe_info->tensors_info_cls_info;
545552
info = (ml_tensors_info_s *) info_h;
546553

547-
obj_info = (*env)->NewObject (env, icls_info->cls, icls_info->mid_init);
554+
obj_info = (*env)->NewObject (env, tensors_info_cls->cls,
555+
tensors_info_cls->mid_init);
548556
if (!obj_info) {
549557
_ml_loge ("Failed to allocate object for tensors info.");
550558
goto done;
@@ -566,7 +574,7 @@ nns_convert_tensors_info (pipeline_info_s * pipe_info, JNIEnv * env,
566574
(*env)->SetIntArrayRegion (env, dimension, 0, ML_TENSOR_RANK_LIMIT,
567575
(jint *) _info->dimension);
568576

569-
(*env)->CallVoidMethod (env, obj_info, icls_info->mid_add_info,
577+
(*env)->CallVoidMethod (env, obj_info, tensors_info_cls->mid_add_info,
570578
name, type, dimension);
571579

572580
if (name)
@@ -587,7 +595,7 @@ nns_parse_tensors_info (pipeline_info_s * pipe_info, JNIEnv * env,
587595
jobject obj_info, ml_tensors_info_h * info_h)
588596
{
589597
guint i;
590-
info_class_info_s *icls_info;
598+
tensors_info_class_info_s *tensors_info_cls;
591599
ml_tensors_info_s *info;
592600
GstTensorInfo *_info;
593601
jobjectArray info_arr;
@@ -602,10 +610,11 @@ nns_parse_tensors_info (pipeline_info_s * pipe_info, JNIEnv * env,
602610
return FALSE;
603611
}
604612

605-
icls_info = &pipe_info->info_cls_info;
613+
tensors_info_cls = &pipe_info->tensors_info_cls_info;
606614
info = (ml_tensors_info_s *) (*info_h);
607615

608-
info_arr = (*env)->CallObjectMethod (env, obj_info, icls_info->mid_get_array);
616+
info_arr = (*env)->CallObjectMethod (env, obj_info,
617+
tensors_info_cls->mid_get_array);
609618

610619
/* number of tensors info */
611620
info->info.num_tensors = (unsigned int) (*env)->GetArrayLength (env, info_arr);
@@ -621,7 +630,7 @@ nns_parse_tensors_info (pipeline_info_s * pipe_info, JNIEnv * env,
621630

622631
/* tensor name */
623632
name_str = (jstring) (*env)->GetObjectField (env, item,
624-
icls_info->fid_info_name);
633+
tensors_info_cls->fid_info_name);
625634
if (name_str) {
626635
const gchar *name = (*env)->GetStringUTFChars (env, name_str, NULL);
627636

@@ -632,11 +641,11 @@ nns_parse_tensors_info (pipeline_info_s * pipe_info, JNIEnv * env,
632641

633642
/* tensor type */
634643
_info->type = (tensor_type) (*env)->GetIntField (env, item,
635-
icls_info->fid_info_type);
644+
tensors_info_cls->fid_info_type);
636645

637646
/* tensor dimension */
638647
dimension = (jintArray) (*env)->GetObjectField (env, item,
639-
icls_info->fid_info_dim);
648+
tensors_info_cls->fid_info_dim);
640649
(*env)->GetIntArrayRegion (env, dimension, 0, ML_TENSOR_RANK_LIMIT,
641650
(jint *) _info->dimension);
642651
(*env)->DeleteLocalRef (env, dimension);

java/android/nnstreamer/src/main/jni/nnstreamer-native-internal.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ typedef struct
111111
jmethodID mid_alloc;
112112
jmethodID mid_get_array;
113113
jmethodID mid_get_info;
114-
} data_class_info_s;
114+
} tensors_data_class_info_s;
115115

116116
/**
117117
* @brief Struct for TensorsInfo class info.
@@ -127,7 +127,7 @@ typedef struct
127127
jfieldID fid_info_name;
128128
jfieldID fid_info_type;
129129
jfieldID fid_info_dim;
130-
} info_class_info_s;
130+
} tensors_info_class_info_s;
131131

132132
/**
133133
* @brief Struct for constructed pipeline.
@@ -145,8 +145,8 @@ typedef struct
145145

146146
jobject instance;
147147
jclass cls;
148-
data_class_info_s data_cls_info;
149-
info_class_info_s info_cls_info;
148+
tensors_data_class_info_s tensors_data_cls_info;
149+
tensors_info_class_info_s tensors_info_cls_info;
150150

151151
gpointer priv_data;
152152
nns_priv_destroy priv_destroy_func;

0 commit comments

Comments
 (0)