Skip to content

Commit 85a3245

Browse files
committed
fix: web config
1 parent f1b7d56 commit 85a3245

6 files changed

Lines changed: 12 additions & 17 deletions

File tree

src/generators/jsx-ast/index.mjs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ export default createLazyGenerator({
1818

1919
defaultConfiguration: {
2020
ref: 'main',
21-
remoteConfig: 'https://nodejs.org/site.json',
2221
},
2322

2423
hasParallelProcessor: true,

src/generators/web/index.mjs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ export default createLazyGenerator({
3434
useAbsoluteURLs: false,
3535
editURL: `${GITHUB_EDIT_URL}/doc/api{path}.md`,
3636
pageURL: '{baseURL}/latest-{version}/api{path}.html',
37+
remoteConfig: 'https://nodejs.org/site.json',
3738
imports: {
3839
'#theme/Logo': '@node-core/ui-components/Common/NodejsLogo',
3940
'#theme/Navigation': join(import.meta.dirname, './ui/components/NavBar'),

src/generators/web/ui/components/AnnouncementBanner/index.jsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ const RemoteLoadableBanner = ({ remoteConfig, versionMajor }) => {
1919

2020
return { default: () => <AnnouncementBanner banners={active} /> };
2121
}),
22+
// eslint-disable-next-line react-x/exhaustive-deps
2223
[]
2324
);
2425

src/generators/web/ui/components/Layout/index.jsx

Lines changed: 7 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import Article from '@node-core/ui-components/Containers/Article';
33

44
import RemoteLoadableBanner from '../AnnouncementBanner';
55

6+
import { remoteConfig, versionMajor } from '#theme/config';
67
import Footer from '#theme/Footer';
78
import MetaBar from '#theme/Metabar';
89
import NavBar from '#theme/Navigation';
@@ -15,23 +16,14 @@ import SideBar from '#theme/Sidebar';
1516
* main content, meta bar, and footer. Override via `#theme/Layout` in your
1617
* configuration's `imports` to customize the entire page structure.
1718
*
18-
* @param {{
19-
* metadata: import('../../types').SerializedMetadata,
20-
* headings: Array,
21-
* readingTime: string,
22-
* children: import('preact').ComponentChildren,
23-
* announcementBannerProps: object
24-
* }} props
19+
* @param {{ metadata: import('../../types').SerializedMetadata, headings: Array, readingTime: string, children: import('preact').ComponentChildren }} props
2520
*/
26-
export default ({
27-
metadata,
28-
headings,
29-
readingTime,
30-
announcementBannerProps,
31-
children,
32-
}) => (
21+
export default ({ metadata, headings, readingTime, children }) => (
3322
<>
34-
<RemoteLoadableBanner {...announcementBannerProps} />
23+
<RemoteLoadableBanner
24+
remoteConfig={remoteConfig}
25+
versionMajor={versionMajor}
26+
/>
3527
<NavBar metadata={metadata} />
3628
<Article>
3729
<SideBar metadata={metadata} />

src/generators/web/ui/types.d.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ declare module '#theme/config' {
2424

2525
// From config generation
2626
export const version: string;
27+
export const versionMajor: number;
2728
export const versions: Array<{
2829
url: string;
2930
label: string;
@@ -32,6 +33,7 @@ declare module '#theme/config' {
3233
export const editURL: string;
3334
export const pages: Array<[string, string]>;
3435
export const languageDisplayNameMap: Map<string[], string>;
36+
export const remoteConfig: string;
3537
}
3638

3739
// Omit Primitives from Metadata

src/generators/web/utils/processing.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ async function executeServerCode(serverCodeMap, requireFn, virtualImports) {
8484
// Execute each bundled entry and collect dehydrated HTML results
8585
for (const chunk of entryChunks) {
8686
const executedFunction = new Function('require', chunk.code);
87-
pages.set(chunk.fileName, executedFunction(enhancedRequire));
87+
pages.set(chunk.fileName, await executedFunction(enhancedRequire));
8888
}
8989

9090
return { pages, css };

0 commit comments

Comments
 (0)