Skip to content

Commit 563f039

Browse files
rojiroji
committed
Make sync-to-latest-ef a skill
1 parent db5d68e commit 563f039

2 files changed

Lines changed: 42 additions & 36 deletions

File tree

‎.agent/skills/sync-to-latest-ef/SKILL.md‎

Lines changed: 41 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
1+
---
2+
name: sync-to-latest-ef
3+
description: Synchronizes EFCore.PG to use the latest EF daily build for the current preview being targeted. Bumps the dependency and ensures the provider builds and all tests pass.
4+
---
5+
6+
# Synchronize to latest EF
7+
8+
We're going to sync the EF Core PostgreSQL provider (EFCore.PG) in this repo to reference the latest daily build of EF Core, and make any necessary adjustment. Try your best to arrive at a fully 100% passing build after syncing, but even if you're unable to do so, submit a PR with whatever you did manage to do, as a basis for further manual work.
9+
10+
## 1. Find out and depend on the latest EF Core daily build of the current preview release
11+
12+
1. First, check what version the `main` branch represents, by looking at the `<VersionPrefix>` in `Directory.Build.props`.
13+
2. Then, find the latest EF Core daily build version **for that preview version**; we do not want to sync to a daily build that's for the next preview version. For example, if `main` has a `<VersionPrefix>` of `11.0.0-preview.2`, we want to update to the latest daily build for preview.2, and not to preview.3 even if packages already exist for that.
14+
3. Note that after preview.7, the naming switches to rc.1 and rc.2.
15+
4. Once you've found the latest daily build package we're syncing to, update the EF Core version in Directory.Packages.props to use it. The EF Core daily build nuget feed is https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet11/nuget/v3/index.json (note that you may need to update dotnet11 to dotnet12 depending on the major/minor version we're looking for).
16+
5. There's no need to switch to the latest daily build of the dotnet SDK though - only of EF; please just always use the latest released preview version of the dotnet SDK (not daily build), unless there's a specific issue requiring the very latest SDK (very rare/unlikely). Use the dotnet-install.sh script to install dotnet SDK.
17+
* If the filesystem is readonly (may be the case in CI), install the dotnet SDK to a temporarily location in /tmp and execute it from there.
18+
19+
## 2. Build
20+
21+
Build EFCore.PG and resolve any errors that are reported.
22+
23+
The EF Core source code can be found in https://github.com/dotnet/efcore - you can explore that repo to understand what changes happened there from the last version the EFCore.PG used to the version we're upgrading towards. Focus especially on changes that occured before the current daily build referenced by EFCore.PG (before your change), since everything is still working correctly with it.
24+
25+
Generally try to align EFCore.PG to whatever practices and patterns are in use within EF Core itself.
26+
27+
## 3. Run Tests
28+
29+
Once everything builds, run all the tests under test - both unit and functional tests - and make sure they all pass. You should have a PostgreSQL database available for running the functional tests - run them all, always, as a final validation for your changes - even if this takes a long time.
30+
31+
* If you get failures from Check_all_tests_overridden, that means that new tests have been added - or possibly that existing ones have been renamed. Find out if a rename occurred by finding missing overridden tests that resemble the new test, and explore the EF code base (including its git history) as needed.
32+
* When adding new test overrides, add them in the appropriate place in the source file, following their placement in the base class. Do not simply add them at the end of the file.
33+
* Also, always add AssertSql(), following the pattern for other tests in the class.
34+
* If you get failures from test NpgsqlComplianceTest.All_test_bases_must_be_implemented, that means that new test base classes have been added - or possibly that existing ones have been renamed. Find out if a rename occurred by finding missing base classes that resemble the new base class, and explore the EF code base (including its git history) as needed. Do not simply add the missing test suite to IgnoredTestBases.
35+
36+
## 4. Commit and submit PR
37+
38+
* Commit all changes in a single commit (no need for separate commits), calling it simply "Sync to EF 11.0.0-preview.1.26104.118" (substituting the actual version). No need for a commit body message.
39+
* Create a PR in https://github.com/npgsql/efcore.pg with all the changes.
40+
* Include a section in the PR body with a list of all PRs on the EF side that caused changes that required updates in EFCore.PG. You can find these by looking at the git history in the EF repo and finding all commits that occurred between the last version we were synced to and the new version we're syncing to, and then finding the PR associated with each commit (commits generally reference the PR in their title).
41+
* Once again, even if you've failed to arrive at a 100% passing build, submit whatever work you did do as a basis for further manual work.

‎.github/workflows/sync-to-latest-ef.md‎

Lines changed: 1 addition & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -58,39 +58,4 @@ env:
5858
Test__Npgsql__DefaultConnection: "Host=postgres;Username=postgres;Password=postgres"
5959
---
6060

61-
# Synchronize to latest EF
62-
63-
We're going to sync the EF Core PostgreSQL provider (EFCore.PG) in this repo to reference the latest daily build of EF Core, and make any necessary adjustment. Try your best to arrive at a fully 100% passing build after syncing, but even if you're unable to do so, submit a PR with whatever you did manage to do, as a basic for further manual work.
64-
65-
## 1. Find out and depend on the latest EF Core daily build of the current preview release
66-
67-
1. First, check what version the `main` branch represents, by looking at the `<VersionPrefix>` in `Directory.Build.props`.
68-
2. Then, find the latest EF Core daily build version **for that preview version**; we do not want to sync to a daily build that's for the next preview version. For example, if `main` has a `<VersionPrefix>` of `11.0.0-preview.2`, we want to update to the latest daily build for preview.2, and not to preview.3 even if packages already exist for that.
69-
3. Note that after preview.7, the naming switches to rc.1 and rc.2.
70-
4. Once you've found the latest daily build package we're syncing to, update the EF Core version in Directory.Packages.props to use it. The EF Core daily build nuget feed is https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet11/nuget/v3/index.json (note that you may need to update dotnet11 to dotnet12 depending on the version we're looking for).
71-
5. There's no need to switch to the latest daily build of the dotnet SDK though - only of EF; please just always use the latest released preview version of the dotnet SDK (not daily build), unless there's a specific issue requiring the very latest SDK (very rare/unlikely).
72-
* To get the appropriate dotnet sdk, use the dotnet-install.sh script, and install it to a temporarily location in /tmp, executing from there (as the filesystem is otherwise readonly).
73-
74-
## 2. Build
75-
76-
Build EFCore.PG and resolve any errors that are reported.
77-
78-
The EF Core source code can be found in https://github.com/dotnet/efcore - you can explore that repo to understand what changes happened there from the last version the EFCore.PG used to the version we're upgrading towards. Focus especially on changes that occured before the current daily build referenced by EFCore.PG (before your change), since everything is still working correctly with it.
79-
80-
Generally try to align EFCore.PG to whatever practices and patterns are in use within EF Core itself.
81-
82-
## 3. Run Tests
83-
84-
Once everything builds, run all the tests under test - both unit and functional tests - and make sure they all pass. You should have a PostgreSQL database available for running the functional tests - run them all, always, as a final validation for your changes - even if this takes a long time.
85-
86-
* If you get failures from Check_all_tests_overridden, that means that new tests have been added - or possibly that existing ones have been renamed. Find out if a rename occurred by finding missing overridden tests that resemble the new test, and explore the EF code base (including its git history) as needed.
87-
* When adding new test overrides, add them in the appropriate place in the source file, following their placement in the base class. Do not simply add them at the end of the file.
88-
* Also, always add AssertSql(), following the pattern for other tests in the class.
89-
* If you get failures from test NpgsqlComplianceTest.All_test_bases_must_be_implemented, that means that new test base classes have been added - or possibly that existing ones have been renamed. Find out if a rename occurred by finding missing base classes that resemble the new base class, and explore the EF code base (including its git history) as needed. Do not simply add the missing test suite to IgnoredTestBases.
90-
91-
## 4. Commit and submit PR
92-
93-
* Commit all changes in a single commit (no need for separate commits), calling it simply "Sync to EF 11.0.0-preview.1.26104.118" (substituting the actual version). No need for a commit body message.
94-
* Create a PR in https://github.com/npgsql/efcore.pg with all the changes.
95-
* Include a section in the PR body with a list of all PRs on the EF side that caused changes that required updates in EFCore.PG. You can find these by looking at the git history in the EF repo and finding all commits that occurred between the last version we were synced to and the new version we're syncing to, and then finding the PR associated with each commit (commits generally reference the PR in their title).
96-
* Once again, even if you've failed to arrive at a 100% passing build, submit whatever work you did do as a basis for further manual work.
61+
Synchronize EFCore.PG to the latest daily build of EF, using the sync-to-latest-ef skill in this repo.

0 commit comments

Comments
 (0)