Remove redundant casts (automated)

Author: roji

src/EFCore.PG.NodaTime/Storage/Internal/TimestampLocalDateTimeMapping.cs

@@ -69,7 +69,7 @@ internal static Expression GenerateCodeLiteral(LocalDateTime dateTime)
         var newExpr = ConstantNew(ConstructorWithSeconds, dateTime.Year, dateTime.Month, dateTime.Day, dateTime.Hour, dateTime.Minute, dateTime.Second);
 
         return dateTime.NanosecondOfSecond == 0
-            ? (Expression)newExpr
+            ? newExpr
             : Expression.Call(newExpr, PlusNanosecondsMethod, Expression.Constant((long)dateTime.NanosecondOfSecond));
     }
 }

src/EFCore.PG/Query/NpgsqlSqlExpressionFactory.cs

@@ -75,7 +75,7 @@ public virtual PostgresBinaryExpression AtTimeZone(
         // PostgreSQL AT TIME ZONE flips the given type from timestamptz to timestamp and vice versa
         // See https://www.postgresql.org/docs/current/functions-datetime.html#FUNCTIONS-DATETIME-ZONECONVERT
         typeMapping ??= FlipTimestampTypeMapping(
-            timestamp.TypeMapping ?? (RelationalTypeMapping?)_typeMappingSource.FindMapping(timestamp.Type, Dependencies.Model)!);
+            timestamp.TypeMapping ?? _typeMappingSource.FindMapping(timestamp.Type, Dependencies.Model)!);
 
         return new PostgresBinaryExpression(
             PostgresExpressionType.AtTimeZone,
@@ -613,7 +613,7 @@ private SqlExpression ApplyTypeMappingOnArrayIndex(
             postgresArrayIndexExpression.Array.TypeMapping is NpgsqlArrayTypeMapping arrayMapping
                 ? arrayMapping.ElementMapping
                 : typeMapping
-                ?? (RelationalTypeMapping?)_typeMappingSource.FindMapping(postgresArrayIndexExpression.Type, Dependencies.Model));
+                ?? _typeMappingSource.FindMapping(postgresArrayIndexExpression.Type, Dependencies.Model));
     }
 
     private SqlExpression ApplyTypeMappingOnILike(PostgresILikeExpression ilikeExpression)
@@ -624,7 +624,7 @@ private SqlExpression ApplyTypeMappingOnILike(PostgresILikeExpression ilikeExpre
                 : ExpressionExtensions.InferTypeMapping(
                     ilikeExpression.Match, ilikeExpression.Pattern,
                     ilikeExpression.EscapeChar))
-            ?? (RelationalTypeMapping?)_typeMappingSource.FindMapping(ilikeExpression.Match.Type, Dependencies.Model);
+            ?? _typeMappingSource.FindMapping(ilikeExpression.Match.Type, Dependencies.Model);
 
         return new PostgresILikeExpression(
             ApplyTypeMapping(ilikeExpression.Match, inferredTypeMapping),

src/EFCore.PG/Storage/Internal/NpgsqlTypeMappingSource.cs

@@ -613,7 +613,7 @@ protected virtual void SetupEnumMappings(ISqlGenerationHelper sqlGenerationHelpe
             var elementType = clrType.GetElementType();
             Debug.Assert(elementType is not null, "Detected array type but element type is null");
 
-            var elementMapping = (RelationalTypeMapping?)FindMapping(elementType);
+            var elementMapping = FindMapping(elementType);
 
             // If no mapping was found for the element, there's no mapping for the array.
             // Also, arrays of arrays aren't supported (as opposed to multidimensional arrays) by PostgreSQL
@@ -636,7 +636,7 @@ protected virtual void SetupEnumMappings(ISqlGenerationHelper sqlGenerationHelpe
             var elementType = clrType.GetGenericArguments()[0];
 
             // If an element isn't supported, neither is its array
-            var elementMapping = (RelationalTypeMapping?)FindMapping(elementType);
+            var elementMapping = FindMapping(elementType);
             if (elementMapping is null)
             {
                 return null;

test/EFCore.PG.NodaTime.FunctionalTests/LegacyNpgsqlNodaTimeTypeMappingTest.cs

@@ -72,7 +72,7 @@ public void GenerateSqlLiteral_returns_instant_range_in_legacy_mode()
 
         private static RelationalTypeMapping GetMapping(string storeType) => Mapper.FindMapping(storeType);
 
-        private static RelationalTypeMapping GetMapping(Type clrType) => (RelationalTypeMapping)Mapper.FindMapping(clrType);
+        private static RelationalTypeMapping GetMapping(Type clrType) => Mapper.FindMapping(clrType);
 
         private static RelationalTypeMapping GetMapping(Type clrType, string storeType)
             => Mapper.FindMapping(clrType, storeType);

test/EFCore.PG.NodaTime.FunctionalTests/NpgsqlNodaTimeTypeMappingTest.cs

@@ -602,7 +602,7 @@ public void GenerateCodeLiteral_returns_Duration_literal()
 
     private static RelationalTypeMapping GetMapping(string storeType) => Mapper.FindMapping(storeType);
 
-    private static RelationalTypeMapping GetMapping(Type clrType) => (RelationalTypeMapping)Mapper.FindMapping(clrType);
+    private static RelationalTypeMapping GetMapping(Type clrType) => Mapper.FindMapping(clrType);
 
     private static RelationalTypeMapping GetMapping(Type clrType, string storeType)
         => Mapper.FindMapping(clrType, storeType);

test/EFCore.PG.Tests/Storage/LegacyNpgsqlTypeMappingTest.cs

@@ -52,7 +52,7 @@ public void GenerateSqlLiteral_returns_timestamptz_datetime_literal()
 
         private static RelationalTypeMapping GetMapping(string storeType) => Mapper.FindMapping(storeType);
 
-        private static RelationalTypeMapping GetMapping(Type clrType) => (RelationalTypeMapping)Mapper.FindMapping(clrType);
+        private static RelationalTypeMapping GetMapping(Type clrType) => Mapper.FindMapping(clrType);
 
         public class LegacyNpgsqlTypeMappingFixture : IDisposable
         {

test/EFCore.PG.Tests/Storage/NpgsqlTypeMappingTest.cs

@@ -905,7 +905,7 @@ private static RelationalTypeMapping GetMapping(string storeType)
         => Mapper.FindMapping(storeType);
 
     private static RelationalTypeMapping GetMapping(Type clrType)
-        => (RelationalTypeMapping)Mapper.FindMapping(clrType);
+        => Mapper.FindMapping(clrType);
 
     private static RelationalTypeMapping GetMapping(Type clrType, string storeType)
         => Mapper.FindMapping(clrType, storeType);