Merge pull request #71 from elenabushneva/reservation-creation-named-args

fix reservation creation

Author: cbertinato

ns1/__init__.py

@@ -503,7 +503,11 @@ def createReservation(
         import ns1.ipam
 
         reservation = ns1.ipam.Reservation(
-            self.config, scopegroup_id, address_id, dhcp_options, mac
+            self.config,
+            scopegroup_id,
+            address_id,
+            options=dhcp_options,
+            mac=mac,
         )
 
         return reservation.create(callback=callback, errback=errback, **kwargs)

ns1/ipam.py

@@ -348,7 +348,7 @@ def reserve(
             raise ScopegroupException("Scope Group not loaded")
 
         reservation = Reservation(
-            self.config, scopegroup_id, self.id, options, mac
+            self.config, scopegroup_id, self.id, options=options, mac=mac
         )
 
         return reservation.create(callback=callback, errback=errback)

ns1/rest/monitoring.py

@@ -122,7 +122,10 @@ class JobTypes(resource.BaseResource):
 
     def list(self, callback=None, errback=None):
         return self._make_request(
-            "GET", self.ROOT, callback=callback, errback=errback,
+            "GET",
+            self.ROOT,
+            callback=callback,
+            errback=errback,
         )
 
 
@@ -133,5 +136,8 @@ class Regions(resource.BaseResource):
 
     def list(self, callback=None, errback=None):
         return self._make_request(
-            "GET", self.ROOT, callback=callback, errback=errback,
+            "GET",
+            self.ROOT,
+            callback=callback,
+            errback=errback,
         )

setup.py

@@ -22,8 +22,16 @@
     author_email="devteam@ns1.com",
     url="https://github.com/ns1/ns1-python",
     packages=find_packages(exclude=["tests", "examples"]),
-    setup_requires=["pytest-runner", "wheel",],
-    tests_require=["pytest", "pytest-pep8", "pytest-cov", "mock",],
+    setup_requires=[
+        "pytest-runner",
+        "wheel",
+    ],
+    tests_require=[
+        "pytest",
+        "pytest-pep8",
+        "pytest-cov",
+        "mock",
+    ],
     keywords="dns development rest sdk ns1 nsone",
     classifiers=[
         "Development Status :: 4 - Beta",