Skip to content

Commit 421d382

Browse files
lint format
1 parent 8cb5012 commit 421d382

4 files changed

Lines changed: 20 additions & 62 deletions

File tree

ns1/__init__.py

Lines changed: 4 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,7 @@ def _loadConfig(self, apiKey, configFile):
3636
if apiKey:
3737
self.config.createFromAPIKey(apiKey)
3838
else:
39-
configFile = (
40-
Config.DEFAULT_CONFIG_FILE if not configFile else configFile
41-
)
39+
configFile = Config.DEFAULT_CONFIG_FILE if not configFile else configFile
4240
self.config.loadFromFile(configFile)
4341

4442
# REST INTERFACE
@@ -300,13 +298,7 @@ def searchZone(
300298
return rest_zone.search(query, type, expand, max, callback, errback)
301299

302300
def createZone(
303-
self,
304-
zone,
305-
zoneFile=None,
306-
callback=None,
307-
errback=None,
308-
name=None,
309-
**kwargs
301+
self, zone, zoneFile=None, callback=None, errback=None, name=None, **kwargs
310302
):
311303
"""
312304
Create a new zone, and return an associated high level Zone object.
@@ -331,11 +323,7 @@ def createZone(
331323
zone = ns1.zones.Zone(self.config, zone)
332324

333325
return zone.create(
334-
zoneFile=zoneFile,
335-
name=name,
336-
callback=callback,
337-
errback=errback,
338-
**kwargs
326+
zoneFile=zoneFile, name=name, callback=callback, errback=errback, **kwargs
339327
)
340328

341329
def loadRecord(
@@ -367,9 +355,7 @@ def loadRecord(
367355
zone = ".".join(parts[1:])
368356
z = ns1.zones.Zone(self.config, zone)
369357

370-
return z.loadRecord(
371-
domain, type, callback=callback, errback=errback, **kwargs
372-
)
358+
return z.loadRecord(domain, type, callback=callback, errback=errback, **kwargs)
373359

374360
def loadMonitors(self, callback=None, errback=None, **kwargs):
375361
"""

ns1/rest/zones.py

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,7 @@ def _buildBody(self, zone, **kwargs):
3636
self._buildStdBody(body, kwargs)
3737
return body
3838

39-
def import_file(
40-
self, zone, zoneFile, callback=None, errback=None, **kwargs
41-
):
39+
def import_file(self, zone, zoneFile, callback=None, errback=None, **kwargs):
4240
files = [("zonefile", (zoneFile, open(zoneFile, "rb"), "text/plain"))]
4341
params = self._buildImportParams(kwargs)
4442
return self._make_request(
@@ -147,9 +145,7 @@ def list_versions(self, zone, callback=None, errback=None):
147145
errback=errback,
148146
)
149147

150-
def create_version(
151-
self, zone, force=False, callback=None, errback=None, name=None
152-
):
148+
def create_version(self, zone, force=False, callback=None, errback=None, name=None):
153149
if name is None:
154150
name = zone
155151
body = {}
@@ -167,9 +163,7 @@ def create_version(
167163
)
168164

169165
def activate_version(self, zone, version_id, callback=None, errback=None):
170-
request = "{}/{}/versions/{}/activate".format(
171-
self.ROOT, zone, str(version_id)
172-
)
166+
request = "{}/{}/versions/{}/activate".format(self.ROOT, zone, str(version_id))
173167
return self._make_request(
174168
"POST",
175169
request,
@@ -228,7 +222,7 @@ def get_zonefile_export(self, zone, callback=None, errback=None):
228222
# The transport layer will try to parse it as JSON and fail
229223
# We catch that exception and extract the raw body text
230224
from ns1.rest.errors import ResourceException
231-
225+
232226
try:
233227
return self._make_request(
234228
"GET",
@@ -240,7 +234,7 @@ def get_zonefile_export(self, zone, callback=None, errback=None):
240234
# If it's about invalid JSON, that's expected - extract the body
241235
if "invalid json in response" in str(e):
242236
# The body is the third argument in ResourceException
243-
if hasattr(e, 'args') and len(e.args) >= 3:
237+
if hasattr(e, "args") and len(e.args) >= 3:
244238
body = e.args[2]
245239
if callback:
246240
return callback(body)

ns1/zones.py

Lines changed: 8 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -61,9 +61,7 @@ def success(result, *args):
6161
else:
6262
return self
6363

64-
return self._rest.retrieve(
65-
self.zone, callback=success, errback=errback
66-
)
64+
return self._rest.retrieve(self.zone, callback=success, errback=errback)
6765

6866
def delete(self, callback=None, errback=None):
6967
"""
@@ -88,13 +86,9 @@ def success(result, *args):
8886
else:
8987
return self
9088

91-
return self._rest.update(
92-
self.zone, callback=success, errback=errback, **kwargs
93-
)
89+
return self._rest.update(self.zone, callback=success, errback=errback, **kwargs)
9490

95-
def create(
96-
self, zoneFile=None, callback=None, errback=None, name=None, **kwargs
97-
):
91+
def create(self, zoneFile=None, callback=None, errback=None, name=None, **kwargs):
9892
"""
9993
Create a new zone. Pass a list of keywords and their values to
10094
configure. For the list of keywords available for zone configuration,
@@ -150,9 +144,7 @@ def add_X(domain, answers, callback=None, errback=None, **kwargs):
150144

151145
return add_X
152146

153-
def createLinkToSelf(
154-
self, new_zone, callback=None, errback=None, **kwargs
155-
):
147+
def createLinkToSelf(self, new_zone, callback=None, errback=None, **kwargs):
156148
"""
157149
Create a new linked zone, linking to ourselves. All records in this
158150
zone will then be available as "linked records" in the new zone.
@@ -286,13 +278,9 @@ def usage(self, callback=None, errback=None, **kwargs):
286278
:return: usage information
287279
"""
288280
stats = Stats(self.config)
289-
return stats.usage(
290-
zone=self.zone, callback=callback, errback=errback, **kwargs
291-
)
281+
return stats.usage(zone=self.zone, callback=callback, errback=errback, **kwargs)
292282

293-
def export(
294-
self, callback=None, errback=None, timeout=300, poll_interval=2
295-
):
283+
def export(self, callback=None, errback=None, timeout=300, poll_interval=2):
296284
"""
297285
Export zone as a BIND-compatible zone file.
298286
@@ -309,18 +297,14 @@ def export(
309297
# Initiate the export
310298
init_response = self._rest.initiate_zonefile_export(self.zone)
311299
if not init_response or init_response.get("status") == "FAILED":
312-
error_msg = init_response.get(
313-
"message", "Failed to initiate export"
314-
)
300+
error_msg = init_response.get("message", "Failed to initiate export")
315301
raise ZoneException(f"Zone export initiation failed: {error_msg}")
316302

317303
# Poll the status until complete or failed
318304
start_time = time.time()
319305
while True:
320306
if time.time() - start_time > timeout:
321-
raise ZoneException(
322-
f"Zone export timed out after {timeout} seconds"
323-
)
307+
raise ZoneException(f"Zone export timed out after {timeout} seconds")
324308

325309
status_response = self._rest.status_zonefile_export(self.zone)
326310
status = status_response.get("status")

tests/unit/test_zone.py

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,7 @@ def test_rest_zone_retrieve(zones_config, zone, url):
5353
)
5454

5555

56-
@pytest.mark.parametrize(
57-
"zone, url", [("test.zone", "zones/test.zone/versions")]
58-
)
56+
@pytest.mark.parametrize("zone, url", [("test.zone", "zones/test.zone/versions")])
5957
def test_rest_zone_version_list(zones_config, zone, url):
6058
z = ns1.rest.zones.Zones(zones_config)
6159
z._make_request = mock.MagicMock()
@@ -253,9 +251,7 @@ def test_rest_zone_buildbody(zones_config):
253251
assert z._buildBody(zone, **kwargs) == body
254252

255253

256-
@pytest.mark.parametrize(
257-
"zone, url", [("test.zone", "export/zonefile/test.zone")]
258-
)
254+
@pytest.mark.parametrize("zone, url", [("test.zone", "export/zonefile/test.zone")])
259255
def test_rest_zone_get_zonefile_export(zones_config, zone, url):
260256
z = ns1.rest.zones.Zones(zones_config)
261257
z._make_request = mock.MagicMock()
@@ -268,9 +264,7 @@ def test_rest_zone_get_zonefile_export(zones_config, zone, url):
268264
)
269265

270266

271-
@pytest.mark.parametrize(
272-
"zone, url", [("test.zone", "export/zonefile/test.zone")]
273-
)
267+
@pytest.mark.parametrize("zone, url", [("test.zone", "export/zonefile/test.zone")])
274268
def test_rest_zone_initiate_zonefile_export(zones_config, zone, url):
275269
z = ns1.rest.zones.Zones(zones_config)
276270
z._make_request = mock.MagicMock()

0 commit comments

Comments
 (0)