Skip to content

Commit eb1c0e4

Browse files
Merge pull request #137 from ns1/fix/zone-create-version
fix(zone): create_version fix
2 parents 506c5ac + 6cbd0ef commit eb1c0e4

2 files changed

Lines changed: 14 additions & 6 deletions

File tree

ns1/rest/zones.py

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -147,14 +147,21 @@ def list_versions(self, zone, callback=None, errback=None):
147147
errback=errback,
148148
)
149149

150-
def create_version(self, zone, force=False, callback=None, errback=None):
150+
def create_version(
151+
self, zone, force=False, callback=None, errback=None, name=None
152+
):
153+
if name is None:
154+
name = zone
155+
body = {}
156+
body["name"] = name
157+
151158
request = "{}/{}/versions?force={}".format(
152159
self.ROOT, zone, str.lower(str(force))
153160
)
154161
return self._make_request(
155162
"PUT",
156163
request,
157-
params={},
164+
body=body,
158165
callback=callback,
159166
errback=errback,
160167
)

tests/unit/test_zone.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -193,14 +193,15 @@ def cb():
193193

194194

195195
@pytest.mark.parametrize(
196-
"zone, url", [("test.zone", "zones/test.zone/versions?force=false")]
196+
"zone, url, name",
197+
[("test.zone", "zones/test.zone/versions?force=false", "new.zone")],
197198
)
198-
def test_rest_zone_version_create(zones_config, zone, url):
199+
def test_rest_zone_version_create(zones_config, zone, url, name):
199200
z = ns1.rest.zones.Zones(zones_config)
200201
z._make_request = mock.MagicMock()
201-
z.create_version(zone)
202+
z.create_version(zone, name=name)
202203
z._make_request.assert_called_once_with(
203-
"PUT", url, params={}, callback=None, errback=None
204+
"PUT", url, body={"name": name}, callback=None, errback=None
204205
)
205206

206207

0 commit comments

Comments
 (0)