Skip to content

Video#empty? causes unexpected behaviour #411

@pavelbonda

Description

@pavelbonda

Recently I found that usage of #present? or #blank? methods on a video object causes additional status queries

This is because of ActiveSupport's definition of #blank? method

# @return [true, false]
def blank?
  respond_to?(:empty?) ? !!empty? : !self
end

It calls #empty? method on a video object

# @return [Boolean] whether the video failed to upload to YouTube because
#   the video file is empty.
def empty?
  status.failure_reason == 'emptyFile'
end

Which was quite quirky for me , I didn't expect such behaviour

As a quick fix I would overwrite #blank? for a Video

What do you think?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions