🚨 fix ruff ERA001 errors in the numpy-stubs tests

Author: jorenham

src/numpy-stubs/@test/runtime/legacy/ufuncs.py

@@ -7,10 +7,8 @@
 np.sin(1, out=np.empty(1))
 np.matmul(np.ones((2, 2, 2)), np.ones((2, 2, 2)), axes=[(0, 1), (0, 1), (0, 1)])
 np.sin(1, signature="D->D")
-# NOTE: `np.generic` subclasses are not guaranteed to support addition;
-# re-enable this we can infer the exact return type of `np.sin(...)`.
-#
-# np.sin(1) + np.sin(1)
+
+np.sin(1) + np.sin(1)
 np.sin.types[0]
 np.sin.__name__
 np.sin.__doc__

src/numpy-stubs/@test/runtime/test_ctype_assumptions.py

@@ -30,7 +30,6 @@ def test_longlong_64(char: str) -> None:
         ("long", "int32" if WIN32 else f"int{SIZE_P}"),
         ("intp", f"int{SIZE_P}"),
     ],
-    # ids="{} is {}".format,
 )
 def test_alias_integer(name_c: str, name_expect: str) -> None:
     signed_c: type[np.signedinteger] = getattr(np, name_c)
@@ -50,7 +49,6 @@ def test_alias_integer(name_c: str, name_expect: str) -> None:
         ("double", "float64"),
         ("longdouble", "float96" if WIN32 else f"float{SIZE_P + 64}"),
     ],
-    # ids="{} is {}".format,
 )
 def test_alias_floating(name_c: str, name_expect: str) -> None:
     floating_c: type[np.floating] = getattr(np, name_c)

src/numpy-stubs/@test/static/accept/constants.pyi

@@ -8,7 +8,7 @@ assert_type(np.inf, float)
 assert_type(np.nan, float)
 assert_type(np.pi, float)
 
-# assert_type(np.little_endian, bool)
+assert_type(np.little_endian, bool)
 
 assert_type(np.True_, np.bool[Literal[True]])
 assert_type(np.False_, np.bool[Literal[False]])

src/numpy-stubs/@test/static/accept/polynomial_polybase.pyi

@@ -90,8 +90,7 @@ assert_type(PS_all.has_samewindow(PS_all), bool)
 assert_type(PS_all.has_sametype(PS_all), bool)
 assert_type(PS_poly.has_sametype(PS_poly), bool)
 assert_type(PS_poly.has_sametype(PS_leg), bool)
-# different outcomes between mypy and pyright
-# assert_type(PS_poly.has_sametype(NotADirectoryError), L[False])
+assert_type(PS_poly.has_sametype(NotADirectoryError), bool)
 
 assert_type(PS_poly.copy(), npp.Polynomial)
 assert_type(PS_cheb.copy(), npp.Chebyshev)

src/numpy-stubs/@test/static/accept/polynomial_series.pyi

@@ -32,7 +32,6 @@ assert_type(npp.polynomial.polyfromroots(AR_f8), _Float64_1d)
 assert_type(npp.polynomial.polyfromroots(AR_c16), _Complex128_1d)
 assert_type(npp.polynomial.polyfromroots(AR_O), _Object_1d)
 
-# assert_type(npp.polynomial.polyadd(AR_b, AR_b), NoReturn)
 assert_type(npp.polynomial.polyadd(AR_u4, AR_b), _Float64_1d)
 assert_type(npp.polynomial.polyadd(AR_i8, AR_i8), _Float64_1d)
 assert_type(npp.polynomial.polyadd(AR_f8, AR_i8), _Float64_1d)
@@ -51,12 +50,10 @@ assert_type(npp.polynomial.polypow(AR_f8, 2), _Float64_1d)
 assert_type(npp.polynomial.polypow(AR_c16, 2), _Complex128_1d)
 assert_type(npp.polynomial.polypow(AR_O, 2), _Object_1d)
 
-# assert_type(npp.polynomial.polyder(PS_poly), _Object_nd)
 assert_type(npp.polynomial.polyder(AR_f8), _Float64_nd)
 assert_type(npp.polynomial.polyder(AR_c16), _Complex128_nd)
 assert_type(npp.polynomial.polyder(AR_O, m=2), _Object_nd)
 
-# assert_type(npp.polynomial.polyint(PS_poly), _Object_nd)
 assert_type(npp.polynomial.polyint(AR_f8), _Float64_nd)
 assert_type(npp.polynomial.polyint(AR_f8, k=AR_c16), _ComplexFloating_nd)
 assert_type(npp.polynomial.polyint(AR_O, m=2), _Object_nd)

src/numpy-stubs/@test/static/accept/scalars.pyi

@@ -164,6 +164,8 @@ assert_type(complex(O), complex)
 # According to the typing spec, the following statements are valid, see
 # https://typing.readthedocs.io/en/latest/spec/constructors.html#new-method
 
+# ruff: noqa: ERA001
+
 # assert_type(np.object_(), None)
 # assert_type(np.object_(None), None)
 # assert_type(np.object_(array_nd), np.ndarray[Any, np.dtype[np.object_]])

src/numpy-stubs/@test/static/accept/strings.pyi

@@ -42,8 +42,8 @@ assert_type(np.strings.less(AR_S, AR_S), _BoolArray)
 assert_type(np.strings.less(AR_T, AR_T), _BoolArray)
 assert_type(np.strings.less(AR_S, AR_U, dtype=np.bool_), _BoolArray)
 
-# TODO(jorenham)
-# https://github.com/numpy/numtype/issues/230
+# TODO(jorenham): https://github.com/numpy/numtype/issues/230
+# ruff: noqa: ERA001
 # assert_type(np.strings.add(AR_U, AR_U), _StrArray)
 # assert_type(np.strings.add(AR_S, AR_S), _BytesArray)
 # assert_type(np.strings.add(AR_T, AR_T), _nt.StringArray)

src/numpy-stubs/@test/static/accept/testing.pyi

@@ -77,12 +77,6 @@ assert_type(np.testing.HAS_LAPACK64, bool)
 assert_type(np.testing.assert_(1, msg="test"), None)
 assert_type(np.testing.assert_(2, msg=lambda: "test"), None)
 
-# cannot be tested on pyright
-# if sys.platform == "win32" or sys.platform == "cygwin":
-#     assert_type(np.testing.memusage(), int)
-# elif sys.platform == "linux":
-#     assert_type(np.testing.memusage(), int | None)
-
 assert_type(np.testing.jiffies(), int)
 
 assert_type(np.testing.build_err_msg([0, 1, 2], "test"), str)
@@ -190,3 +184,11 @@ assert_type(np.testing.assert_no_gc_cycles(), contextlib._GeneratorContextManage
 assert_type(np.testing.assert_no_gc_cycles(func3, 5), None)
 
 assert_type(np.testing.break_cycles(), None)
+
+# NOTE: Platform-dependent behavior cannot be tested on pyright
+# ruff: noqa: ERA001
+
+# if sys.platform == "win32" or sys.platform == "cygwin":
+#     assert_type(np.testing.memusage(), int)
+# elif sys.platform == "linux":
+#     assert_type(np.testing.memusage(), int | None)

src/numpy-stubs/@test/static/reject/char.pyi

@@ -5,6 +5,8 @@ AR_U: _nt.Array[np.str_]
 AR_S: _nt.Array[np.bytes_]
 
 # TODO(jorenham)
+# ruff: noqa: ERA001
+
 # np.char.equal(AR_U, AR_S)
 # np.char.not_equal(AR_U, AR_S)
 # np.char.greater_equal(AR_U, AR_S)

src/numpy-stubs/@test/static/reject/strings.pyi

@@ -5,6 +5,7 @@ AR_U: _nt.Array[np.str_]
 AR_S: _nt.Array[np.bytes_]
 
 # TODO(jorenham)
+# ruff: noqa: ERA001
 
 # np.strings.equal(AR_U, AR_S)
 # np.strings.not_equal(AR_U, AR_S)