SyncServerImpl: isRunning() should not throw if closed objectbox-java#252

greenrobot · greenrobot · commit 4926ccf288df · 2025-01-29T20:08:25.000+01:00
diff --git a/objectbox-java/src/main/java/io/objectbox/sync/server/SyncServerImpl.java b/objectbox-java/src/main/java/io/objectbox/sync/server/SyncServerImpl.java
@@ -80,7 +80,8 @@ public int getPort() {
 
     @Override
     public boolean isRunning() {
-        return nativeIsRunning(getHandle());
+        long handle = this.handle;  // Do not call getHandle() as it throws if handle is 0
+        return handle != 0 && nativeIsRunning(handle);
     }
 
     @Override

Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,8 @@ public int getPort() {`
`80`	`80`
`81`	`81`	`@Override`
`82`	`82`	`public boolean isRunning() {`
`83`		`- return nativeIsRunning(getHandle());`
	`83`	`+ long handle = this.handle; // Do not call getHandle() as it throws if handle is 0`
	`84`	`+ return handle != 0 && nativeIsRunning(handle);`
`84`	`85`	`}`
`85`	`86`
`86`	`87`	`@Override`