Skip to content

Commit b5795ec

Browse files
authored
[CI][Benchmarks] Correct no explicit_group warning (#19397)
It is fine that some benchmark metadata does not have explicit_group defined. Change a misleading warning. Example of a series of warnings on explicit_group missing: https://github.com/oneapi-src/unified-runtime/actions/runs/16182812320/job/45685586721#step:14:2048
1 parent 1eef212 commit b5795ec

1 file changed

Lines changed: 4 additions & 9 deletions

File tree

devops/scripts/benchmarks/output_markdown.py

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -115,18 +115,13 @@ def is_content_in_size_limit(content_size: int, current_markdown_size: int):
115115

116116

117117
def get_explicit_group_name(result: Result, metadata: dict[str, BenchmarkMetadata]):
118-
explicit_group_name = ""
119118
try:
120-
explicit_group_name = metadata[result.label].explicit_group
121-
except Exception as e:
122-
log.warning(
123-
f"Unexpected error when getting explicit_group for '{result.label}': {e}"
124-
)
119+
group_name = metadata[result.label].explicit_group
120+
return group_name if group_name else "Other"
121+
except Exception:
122+
log.debug(f"No explicit group found for {result.label}, using 'Other'")
125123
return "Other"
126124

127-
return explicit_group_name if explicit_group_name else "Other"
128-
129-
130125
# Function to generate the markdown collapsible sections for each variant
131126
def generate_markdown_details(
132127
results: list[Result], current_markdown_size: int, markdown_size: MarkdownSize

0 commit comments

Comments
 (0)