Skip to content

Commit a3fe9b7

Browse files
Remove constexpr from RecordComponent::visit() (#1582)
RecordComponent has a virtual base class, so it cannot be constexpr
1 parent 7296948 commit a3fe9b7

2 files changed

Lines changed: 3 additions & 4 deletions

File tree

include/openPMD/RecordComponent.hpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -476,9 +476,8 @@ class RecordComponent : public BaseRecordComponent
476476
* be implicitly converted.
477477
*/
478478
template <typename Visitor, typename... Args>
479-
constexpr auto visit(Args &&...args)
480-
-> decltype(Visitor::template call<char>(
481-
std::declval<RecordComponent &>(), std::forward<Args>(args)...));
479+
auto visit(Args &&...args) -> decltype(Visitor::template call<char>(
480+
std::declval<RecordComponent &>(), std::forward<Args>(args)...));
482481

483482
static constexpr char const *const SCALAR = "\vScalar";
484483

include/openPMD/RecordComponent.tpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -397,7 +397,7 @@ namespace detail
397397
} // namespace detail
398398

399399
template <typename Visitor, typename... Args>
400-
constexpr auto RecordComponent::visit(Args &&...args)
400+
auto RecordComponent::visit(Args &&...args)
401401
-> decltype(Visitor::template call<char>(
402402
std::declval<RecordComponent &>(), std::forward<Args>(args)...))
403403
{

0 commit comments

Comments
 (0)