Skip to content

Commit 3bd4661

Browse files
committed
chore: remove unimplemented --rollback and --resume flags
1 parent bbea2f0 commit 3bd4661

6 files changed

Lines changed: 0 additions & 33 deletions

File tree

README.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -186,8 +186,6 @@ openboot version # Print version
186186
-s, --silent Non-interactive mode (requires env vars)
187187
--dry-run Preview what would be installed
188188
--update Update Homebrew and packages
189-
--rollback Restore backed up files
190-
--resume Resume incomplete installation
191189
--shell MODE Shell setup: install, skip
192190
--macos MODE macOS prefs: configure, skip
193191
--dotfiles MODE Dotfiles: clone, link, skip

internal/cli/install.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,13 +64,11 @@ func init() {
6464
installCmd.Flags().StringVarP(&cfg.User, "user", "u", "", "install from openboot.dev/username config")
6565
installCmd.Flags().BoolVarP(&cfg.Silent, "silent", "s", false, "non-interactive mode (for CI/CD)")
6666
installCmd.Flags().BoolVar(&cfg.DryRun, "dry-run", false, "preview changes without installing")
67-
installCmd.Flags().BoolVar(&cfg.Resume, "resume", false, "resume an incomplete installation")
6867
installCmd.Flags().BoolVar(&cfg.PackagesOnly, "packages-only", false, "install packages only, skip system config")
6968

7069
installCmd.Flags().StringVar(&cfg.Shell, "shell", "", "shell setup: install, skip")
7170
installCmd.Flags().StringVar(&cfg.Macos, "macos", "", "macOS preferences: configure, skip")
7271
installCmd.Flags().StringVar(&cfg.Dotfiles, "dotfiles", "", "dotfiles: clone, link, skip")
7372

7473
installCmd.Flags().BoolVar(&cfg.Update, "update", false, "update Homebrew before installing")
75-
installCmd.Flags().BoolVar(&cfg.Rollback, "rollback", false, "restore backed-up config files")
7674
}

internal/cli/root.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,15 +87,13 @@ func init() {
8787
rootCmd.Flags().StringVarP(&cfg.User, "user", "u", "", "install from openboot.dev/username config")
8888
rootCmd.Flags().BoolVarP(&cfg.Silent, "silent", "s", false, "non-interactive mode (for CI/CD)")
8989
rootCmd.Flags().BoolVar(&cfg.DryRun, "dry-run", false, "preview changes without installing")
90-
rootCmd.Flags().BoolVar(&cfg.Resume, "resume", false, "resume an incomplete installation")
9190
rootCmd.Flags().BoolVar(&cfg.PackagesOnly, "packages-only", false, "install packages only, skip system config")
9291

9392
rootCmd.Flags().StringVar(&cfg.Shell, "shell", "", "shell setup: install, skip")
9493
rootCmd.Flags().StringVar(&cfg.Macos, "macos", "", "macOS preferences: configure, skip")
9594
rootCmd.Flags().StringVar(&cfg.Dotfiles, "dotfiles", "", "dotfiles: clone, link, skip")
9695

9796
rootCmd.Flags().BoolVar(&cfg.Update, "update", false, "update Homebrew before installing")
98-
rootCmd.Flags().BoolVar(&cfg.Rollback, "rollback", false, "restore backed-up config files")
9997

10098
rootCmd.AddCommand(installCmd)
10199
rootCmd.AddCommand(versionCmd)

internal/config/config.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,6 @@ type Config struct {
2929
Silent bool
3030
DryRun bool
3131
Update bool
32-
Rollback bool
33-
Resume bool
3432
Shell string
3533
Macos string
3634
Dotfiles string

internal/installer/installer.go

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,6 @@ func Run(cfg *config.Config) error {
3030
return runUpdate(cfg)
3131
}
3232

33-
if cfg.Rollback {
34-
return runRollback(cfg)
35-
}
36-
3733
return runInstall(cfg)
3834
}
3935

@@ -826,13 +822,6 @@ func runUpdate(cfg *config.Config) error {
826822
return nil
827823
}
828824

829-
func runRollback(cfg *config.Config) error {
830-
ui.Header("OpenBoot Rollback")
831-
fmt.Println()
832-
ui.Muted("Rollback functionality coming soon...")
833-
return nil
834-
}
835-
836825
func estimateInstallMinutes(formulaeCount, caskCount, npmCount int) int {
837826
totalSeconds := formulaeCount*estimatedSecondsPerFormula +
838827
caskCount*estimatedSecondsPerCask +

internal/installer/installer_test.go

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -110,14 +110,6 @@ func TestRun_UpdateRoute(t *testing.T) {
110110
assert.NoError(t, err)
111111
}
112112

113-
func TestRun_RollbackRoute(t *testing.T) {
114-
cfg := &config.Config{
115-
Rollback: true,
116-
}
117-
err := Run(cfg)
118-
assert.NoError(t, err)
119-
}
120-
121113
func TestCheckDependencies_DryRunSkipsEverything(t *testing.T) {
122114
cfg := &config.Config{
123115
DryRun: true,
@@ -360,12 +352,6 @@ func TestStepMacOS_Skip(t *testing.T) {
360352
assert.NoError(t, err)
361353
}
362354

363-
func TestRunRollback(t *testing.T) {
364-
cfg := &config.Config{}
365-
err := runRollback(cfg)
366-
assert.NoError(t, err)
367-
}
368-
369355
func TestInstallTimeConstants(t *testing.T) {
370356
assert.Equal(t, 15, estimatedSecondsPerFormula)
371357
assert.Equal(t, 30, estimatedSecondsPerCask)

0 commit comments

Comments
 (0)