refactor: remove ~45 low-value tests that can't meaningfully fail

Delete struct construction tests, constant assertions, type checks,
and embedded data validations. Keep tests with real logic, I/O, and
parsing behavior.

Author: fullstackjam

internal/brew/brew_command_test.go

@@ -203,15 +203,3 @@ func TestDoctorDiagnose_UnknownWarnings(t *testing.T) {
 	require.NoError(t, err)
 	assert.Contains(t, suggestions, "Run: brew doctor (to see full diagnostic output)")
 }
-
-func TestBrewInstallCmd_SetsNoAutoUpdate(t *testing.T) {
-	cmd := brewInstallCmd("install", "git")
-	assert.Equal(t, []string{"brew", "install", "git"}, cmd.Args)
-	found := false
-	for _, env := range cmd.Env {
-		if env == "HOMEBREW_NO_AUTO_UPDATE=1" {
-			found = true
-		}
-	}
-	assert.True(t, found, "expected HOMEBREW_NO_AUTO_UPDATE=1 in env")
-}

internal/brew/brew_test.go

@@ -4,7 +4,6 @@ import (
 	"strings"
 	"testing"
 
-	"github.com/openbootdotdev/openboot/internal/ui"
 	"github.com/stretchr/testify/assert"
 )
 
@@ -187,51 +186,10 @@ func TestCheckDiskSpace(t *testing.T) {
 	assert.Greater(t, gb, 0.0)
 }
 
-func TestOutdatedPackageStruct(t *testing.T) {
-	pkg := OutdatedPackage{
-		Name:    "git",
-		Current: "2.40.0",
-		Latest:  "2.42.0",
-	}
-	assert.Equal(t, "git", pkg.Name)
-	assert.Equal(t, "2.40.0", pkg.Current)
-	assert.Equal(t, "2.42.0", pkg.Latest)
-}
-
-func TestHandleFailedJobs_Empty(t *testing.T) {
-	handleFailedJobs(nil)
-	handleFailedJobs([]failedJob{})
-}
-
 func TestHandleFailedJobs_WithFailures(t *testing.T) {
 	failed := []failedJob{
 		{installJob: installJob{name: "pkg1", isCask: false}, errMsg: "not found"},
 		{installJob: installJob{name: "pkg2", isCask: true}, errMsg: ""},
 	}
 	handleFailedJobs(failed)
 }
-
-func TestRunParallelInstallWithProgress_EmptyPkgs(t *testing.T) {
-	result := runParallelInstallWithProgress(nil, nil)
-	assert.Nil(t, result)
-}
-
-func TestIsInstalled(t *testing.T) {
-	result := IsInstalled()
-	assert.IsType(t, true, result)
-}
-
-func TestMaxWorkersConstant(t *testing.T) {
-	assert.Equal(t, 1, maxWorkers)
-}
-
-func TestPrintBrewOutput_Lines(t *testing.T) {
-	p := ui.NewStickyProgress(1)
-	printBrewOutput("line one\nline two\n  line three  \n", p)
-}
-
-func TestPrintBrewOutput_Empty(t *testing.T) {
-	p := ui.NewStickyProgress(1)
-	printBrewOutput("", p)
-	printBrewOutput("   \n   ", p)
-}

internal/cli/sync_test.go

@@ -461,13 +461,6 @@ func TestPrintMissingExtraBothEmpty(t *testing.T) {
 	assert.Empty(t, output)
 }
 
-func TestPkgCategoryConstants(t *testing.T) {
-	assert.Equal(t, pkgCategory("formulae"), categoryFormulae)
-	assert.Equal(t, pkgCategory("casks"), categoryCasks)
-	assert.Equal(t, pkgCategory("npm"), categoryNpm)
-	assert.Equal(t, pkgCategory("taps"), categoryTaps)
-}
-
 func TestBuildDryRunPlan(t *testing.T) {
 	d := &syncpkg.SyncDiff{
 		MissingFormulae: []string{"ripgrep", "fd"},

internal/config/packages_test.go

@@ -161,13 +161,3 @@ func TestIsTapPackage(t *testing.T) {
 		})
 	}
 }
-
-func TestGetAllPackageNames(t *testing.T) {
-	names := GetAllPackageNames()
-
-	assert.Greater(t, len(names), 0)
-	assert.Contains(t, names, "curl")
-	assert.Contains(t, names, "node")
-	assert.Contains(t, names, "typescript")
-	assert.Contains(t, names, "visual-studio-code")
-}

internal/dotfiles/dotfiles_test.go

@@ -10,10 +10,6 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
-func TestDefaultDotfilesURL(t *testing.T) {
-	assert.Equal(t, "https://github.com/openbootdotdev/dotfiles", DefaultDotfilesURL)
-}
-
 func TestGetDotfilesURL_Empty(t *testing.T) {
 	t.Setenv("OPENBOOT_DOTFILES", "")
 	url := GetDotfilesURL()

internal/installer/installer_test.go

@@ -373,12 +373,6 @@ func TestStepMacOS_Silent_DryRun(t *testing.T) {
 	assert.NoError(t, err)
 }
 
-func TestInstallTimeConstants(t *testing.T) {
-	assert.Equal(t, 15, estimatedSecondsPerFormula)
-	assert.Equal(t, 30, estimatedSecondsPerCask)
-	assert.Equal(t, 5, estimatedSecondsPerNpm)
-}
-
 func TestInstallState_OnlySuccessfulPackagesMarked(t *testing.T) {
 	tmpDir := t.TempDir()
 	t.Setenv("HOME", tmpDir)

internal/macos/macos_test.go

@@ -88,32 +88,6 @@ func TestConfigure_DifferentTypes(t *testing.T) {
 	assert.NoError(t, err)
 }
 
-func TestDefaultPreferences_NotEmpty(t *testing.T) {
-	assert.Greater(t, len(DefaultPreferences), 0)
-}
-
-func TestDefaultPreferences_HasRequiredFields(t *testing.T) {
-	for _, pref := range DefaultPreferences {
-		assert.NotEmpty(t, pref.Domain, "Domain should not be empty")
-		assert.NotEmpty(t, pref.Key, "Key should not be empty")
-		assert.NotEmpty(t, pref.Type, "Type should not be empty")
-		assert.NotEmpty(t, pref.Desc, "Description should not be empty")
-	}
-}
-
-func TestDefaultPreferences_ValidTypes(t *testing.T) {
-	validTypes := map[string]bool{
-		"bool":   true,
-		"int":    true,
-		"float":  true,
-		"string": true,
-	}
-
-	for _, pref := range DefaultPreferences {
-		assert.True(t, validTypes[pref.Type], "Type %s is not valid", pref.Type)
-	}
-}
-
 func TestCreateScreenshotsDir_DryRun(t *testing.T) {
 	tmpHome := t.TempDir()
 	t.Setenv("HOME", tmpHome)
@@ -159,33 +133,3 @@ func TestRestartAffectedApps_DryRun(t *testing.T) {
 // TestRestartAffectedApps_NoDryRun kills real system processes (Finder, Dock, SystemUIServer),
 // so it must only run with the integration build tag.
 // See test/integration/ for the integration-tagged version.
-
-func TestDefaultPreferences_FinderPrefs(t *testing.T) {
-	finderPrefs := []Preference{}
-	for _, p := range DefaultPreferences {
-		if p.Domain == "com.apple.finder" {
-			finderPrefs = append(finderPrefs, p)
-		}
-	}
-	assert.Greater(t, len(finderPrefs), 0, "Should have Finder preferences")
-}
-
-func TestDefaultPreferences_DockPrefs(t *testing.T) {
-	dockPrefs := []Preference{}
-	for _, p := range DefaultPreferences {
-		if p.Domain == "com.apple.dock" {
-			dockPrefs = append(dockPrefs, p)
-		}
-	}
-	assert.Greater(t, len(dockPrefs), 0, "Should have Dock preferences")
-}
-
-func TestDefaultPreferences_ScreencapturePrefs(t *testing.T) {
-	screencapturePrefs := []Preference{}
-	for _, p := range DefaultPreferences {
-		if p.Domain == "com.apple.screencapture" {
-			screencapturePrefs = append(screencapturePrefs, p)
-		}
-	}
-	assert.Greater(t, len(screencapturePrefs), 0, "Should have Screencapture preferences")
-}

internal/npm/npm_test.go

@@ -96,16 +96,6 @@ func TestInstall_DryRun(t *testing.T) {
 	assert.NoError(t, err)
 }
 
-func TestInstall_DryRun_EmptyPackages(t *testing.T) {
-	err := Install([]string{}, true)
-	assert.NoError(t, err)
-}
-
-func TestIsAvailable(t *testing.T) {
-	result := IsAvailable()
-	assert.IsType(t, true, result)
-}
-
 func TestGetNodeVersion(t *testing.T) {
 	if !IsAvailable() {
 		t.Skip("node not available")

internal/snapshot/capture_test.go

@@ -178,139 +178,6 @@ func TestSanitizePath(t *testing.T) {
 	}
 }
 
-// TestCaptureFormulae tests that CaptureFormulae returns a slice.
-func TestCaptureFormulae(t *testing.T) {
-	formulae, err := CaptureFormulae()
-	// Should either succeed or fail gracefully
-	assert.True(t, err == nil || formulae != nil)
-	assert.IsType(t, []string{}, formulae)
-}
-
-// TestCaptureCasks tests that CaptureCasks returns a slice.
-func TestCaptureCasks(t *testing.T) {
-	casks, err := CaptureCasks()
-	// Should either succeed or fail gracefully
-	assert.True(t, err == nil || casks != nil)
-	assert.IsType(t, []string{}, casks)
-}
-
-// TestCaptureTaps tests that CaptureTaps returns a slice.
-func TestCaptureTaps(t *testing.T) {
-	taps, err := CaptureTaps()
-	// Should either succeed or fail gracefully
-	assert.True(t, err == nil || taps != nil)
-	assert.IsType(t, []string{}, taps)
-}
-
-// TestCaptureNpm tests that CaptureNpm returns a slice.
-func TestCaptureNpm(t *testing.T) {
-	npm, err := CaptureNpm()
-	// Should either succeed or fail gracefully
-	assert.True(t, err == nil || npm != nil)
-	assert.IsType(t, []string{}, npm)
-}
-
-// TestCaptureShell tests that CaptureShell returns a ShellSnapshot.
-func TestCaptureShell(t *testing.T) {
-	shell, err := CaptureShell()
-	assert.NoError(t, err)
-	assert.NotNil(t, shell)
-	assert.IsType(t, &ShellSnapshot{}, shell)
-}
-
-// TestCaptureGit tests that CaptureGit returns a GitSnapshot.
-func TestCaptureGit(t *testing.T) {
-	git, err := CaptureGit()
-	assert.NoError(t, err)
-	assert.NotNil(t, git)
-	assert.IsType(t, &GitSnapshot{}, git)
-}
-
-// TestCaptureDevTools tests that CaptureDevTools returns a slice.
-func TestCaptureDevTools(t *testing.T) {
-	tools, err := CaptureDevTools()
-	assert.NoError(t, err)
-	assert.NotNil(t, tools)
-	assert.IsType(t, []DevTool{}, tools)
-}
-
-// TestCaptureMacOSPrefs tests that CaptureMacOSPrefs returns a slice.
-func TestCaptureMacOSPrefs(t *testing.T) {
-	prefs, err := CaptureMacOSPrefs()
-	// Should either succeed or fail gracefully
-	assert.True(t, err == nil || prefs != nil)
-	assert.IsType(t, []MacOSPref{}, prefs)
-}
-
-// TestParseLines_EdgeCases tests parseLines with edge cases.
-func TestParseLines_EdgeCases(t *testing.T) {
-	tests := []struct {
-		name     string
-		input    string
-		minItems int
-		maxItems int
-	}{
-		{
-			name:     "only whitespace",
-			input:    "   \n   \n   ",
-			minItems: 0,
-			maxItems: 0,
-		},
-		{
-			name:     "mixed whitespace",
-			input:    " \t \n \t \n \t ",
-			minItems: 0,
-			maxItems: 0,
-		},
-		{
-			name:     "single item with spaces",
-			input:    "   git   ",
-			minItems: 1,
-			maxItems: 1,
-		},
-	}
-
-	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
-			result := parseLines(tt.input)
-			assert.GreaterOrEqual(t, len(result), tt.minItems)
-			assert.LessOrEqual(t, len(result), tt.maxItems)
-		})
-	}
-}
-
-// TestParseVersion_EdgeCases tests parseVersion with edge cases.
-func TestParseVersion_EdgeCases(t *testing.T) {
-	tests := []struct {
-		name     string
-		toolName string
-		output   string
-	}{
-		{
-			name:     "empty output",
-			toolName: "go",
-			output:   "",
-		},
-		{
-			name:     "whitespace only",
-			toolName: "node",
-			output:   "   ",
-		},
-		{
-			name:     "malformed output",
-			toolName: "go",
-			output:   "invalid output format",
-		},
-	}
-
-	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
-			result := parseVersion(tt.toolName, tt.output)
-			// Should not panic and return a string
-			assert.IsType(t, "", result)
-		})
-	}
-}
 
 func TestCaptureWithProgress_HealthTracksFailedSteps(t *testing.T) {
 	steps := []captureStep{