throw on reading oldms files (#436)

andiwand · web-flow · commit 7f8beb19247a · 2025-07-13T11:54:01.000+02:00
diff --git a/src/odr/internal/oldms/oldms_file.cpp b/src/odr/internal/oldms/oldms_file.cpp
@@ -80,11 +80,13 @@ EncryptionState LegacyMicrosoftFile::encryption_state() const noexcept {
 std::shared_ptr<abstract::DecodedFile>
 LegacyMicrosoftFile::decrypt(const std::string &password) const {
   (void)password;
-  return {}; // TODO throw
+  throw UnsupportedOperation(
+      "odrcore does not support decryption of legacy Microsoft files");
 }
 
 std::shared_ptr<abstract::Document> LegacyMicrosoftFile::document() const {
-  return {}; // TODO throw
+  throw UnsupportedOperation(
+      "odrcore does not support reading legacy Microsoft files");
 }
 
 } // namespace odr::internal::oldms

Original file line number	Diff line number	Diff line change
`@@ -80,11 +80,13 @@ EncryptionState LegacyMicrosoftFile::encryption_state() const noexcept {`
`80`	`80`	`std::shared_ptr<abstract::DecodedFile>`
`81`	`81`	`LegacyMicrosoftFile::decrypt(const std::string &password) const {`
`82`	`82`	`(void)password;`
`83`		`- return {}; // TODO throw`
	`83`	`+ throw UnsupportedOperation(`
	`84`	`+ "odrcore does not support decryption of legacy Microsoft files");`
`84`	`85`	`}`
`85`	`86`
`86`	`87`	`std::shared_ptr<abstract::Document> LegacyMicrosoftFile::document() const {`
`87`		`- return {}; // TODO throw`
	`88`	`+ throw UnsupportedOperation(`
	`89`	`+ "odrcore does not support reading legacy Microsoft files");`
`88`	`90`	`}`
`89`	`91`
`90`	`92`	`} // namespace odr::internal::oldms`