Add new configurations. Refactor.

Author: Artsem Lemiasheuski

OpenDocumentReader.xcodeproj/project.pbxproj

@@ -40,7 +40,7 @@
       </Testables>
    </TestAction>
    <LaunchAction
-      buildConfiguration = "Full"
+      buildConfiguration = "Debug"
       selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
       selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
       launchStyle = "0"
@@ -82,7 +82,7 @@
    </AnalyzeAction>
    <ArchiveAction
       buildConfiguration = "Release"
-      customArchiveName = "ODR Full"
+      customArchiveName = "OpenDocumentReader Full"
       revealArchiveInOrganizer = "YES">
    </ArchiveAction>
 </Scheme>

OpenDocumentReader.xcodeproj/xcshareddata/xcschemes/ODR Full.xcscheme

@@ -23,15 +23,15 @@
       </BuildActionEntries>
    </BuildAction>
    <TestAction
-      buildConfiguration = "Debug"
+      buildConfiguration = "Debug Lite"
       selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
       selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
       shouldUseLaunchSchemeArgsEnv = "YES">
       <Testables>
       </Testables>
    </TestAction>
    <LaunchAction
-      buildConfiguration = "Lite"
+      buildConfiguration = "Debug Lite"
       selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
       selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
       launchStyle = "0"
@@ -52,7 +52,7 @@
       </BuildableProductRunnable>
    </LaunchAction>
    <ProfileAction
-      buildConfiguration = "Release"
+      buildConfiguration = "Release Lite"
       shouldUseLaunchSchemeArgsEnv = "YES"
       savedToolIdentifier = ""
       useCustomWorkingDirectory = "NO"
@@ -69,11 +69,11 @@
       </BuildableProductRunnable>
    </ProfileAction>
    <AnalyzeAction
-      buildConfiguration = "Debug">
+      buildConfiguration = "Debug Lite">
    </AnalyzeAction>
    <ArchiveAction
-      buildConfiguration = "Release"
-      customArchiveName = "ODR Lite"
+      buildConfiguration = "Release Lite"
+      customArchiveName = "OpenDocumentReader Lite"
       revealArchiveInOrganizer = "YES">
    </ArchiveAction>
 </Scheme>

OpenDocumentReader.xcodeproj/xcshareddata/xcschemes/ODR Lite.xcscheme

@@ -0,0 +1,6 @@
+import Foundation
+
+enum AppType: String {
+    case full = "at.tomtasche.reader"
+    case lite = "at.tomtasche.reader.lite"
+}

OpenDocumentReader/AppType.swift

@@ -3,11 +3,12 @@ import Foundation
 struct ConfigurationManager {
     static let manager = ConfigurationManager()
 
-    private(set) var configuration: String!
+    private(set) var configuration: AppType!
 
     private init () {
-        if let configuration = Bundle.main.infoDictionary?["Configurations"] as? String {
-            self.configuration = configuration
-        } 
+        
+        if let productId = Bundle.main.bundleIdentifier {
+            configuration = AppType(rawValue: productId.lowercased()) ?? .lite
+        }
     }
 }

OpenDocumentReader/ConfigurationManager.swift

@@ -71,7 +71,7 @@ class DocumentViewController: UIViewController, DocumentDelegate {
     }
 
     func loadBannerAd() {
-        if ConfigurationManager.manager.configuration == Constants.configurationLite {
+        if ConfigurationManager.manager.configuration == .lite {
             let frame = { () -> CGRect in
               if #available(iOS 11.0, *) {
                 return view.frame.inset(by: view.safeAreaInsets)

OpenDocumentReader/DocumentViewController.swift

@@ -2,12 +2,8 @@
 <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
 <plist version="1.0">
 <dict>
-    <key>GADApplicationIdentifier</key>
-    <string>ca-app-pub-3940256099942544~1458002511</string>
 	<key>CFBundleDevelopmentRegion</key>
 	<string>$(DEVELOPMENT_LANGUAGE)</string>
-	<key>CFBundleDisplayName</key>
-	<string>OpenDocument Reader</string>
 	<key>CFBundleDocumentTypes</key>
 	<array>
 		<dict>
@@ -56,8 +52,8 @@
 	<string>$(MARKETING_VERSION)</string>
 	<key>CFBundleVersion</key>
 	<string>$(CURRENT_PROJECT_VERSION)</string>
-	<key>Configurations</key>
-	<string>$(CONFIGURATION)</string>
+	<key>GADApplicationIdentifier</key>
+	<string>ca-app-pub-3940256099942544~1458002511</string>
 	<key>LSRequiresIPhoneOS</key>
 	<true/>
 	<key>UILaunchStoryboardName</key>