improve analytics, raise version

Thomas Taschauer · Thomas Taschauer · commit 6f1124017ecf · 2019-04-27T14:37:51.000+02:00
diff --git a/OpenDocumentReader.xcodeproj/project.pbxproj b/OpenDocumentReader.xcodeproj/project.pbxproj
@@ -12,6 +12,7 @@
 		E22EB718226B633500053B86 /* Document.swift in Sources */ = {isa = PBXBuildFile; fileRef = E22EB717226B633500053B86 /* Document.swift */; };
 		E22EB71A226B65E300053B86 /* DocumentViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = E22EB719226B65E300053B86 /* DocumentViewController.swift */; };
 		E22EB71C226B66B300053B86 /* Main.storyboard in Resources */ = {isa = PBXBuildFile; fileRef = E22EB71B226B66B300053B86 /* Main.storyboard */; };
+		E23795302274844400BA7238 /* AdSupport.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = E237952F2274844400BA7238 /* AdSupport.framework */; };
 		E26C392C2250D926009C484A /* libglog.a in Frameworks */ = {isa = PBXBuildFile; fileRef = E26C39172250D91C009C484A /* libglog.a */; };
 		E26C392D2250D926009C484A /* libminiz.a in Frameworks */ = {isa = PBXBuildFile; fileRef = E26C391B2250D91C009C484A /* libminiz.a */; };
 		E26C392E2250D926009C484A /* libodrlib.a in Frameworks */ = {isa = PBXBuildFile; fileRef = E26C391D2250D91C009C484A /* libodrlib.a */; };
@@ -226,6 +227,7 @@
 		E22EB717226B633500053B86 /* Document.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = Document.swift; sourceTree = "<group>"; };
 		E22EB719226B65E300053B86 /* DocumentViewController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = DocumentViewController.swift; sourceTree = "<group>"; };
 		E22EB71B226B66B300053B86 /* Main.storyboard */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = file.storyboard; path = Main.storyboard; sourceTree = "<group>"; };
+		E237952F2274844400BA7238 /* AdSupport.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = AdSupport.framework; path = System/Library/Frameworks/AdSupport.framework; sourceTree = SDKROOT; };
 		E26C38EA2250D91C009C484A /* odr.xcodeproj */ = {isa = PBXFileReference; lastKnownFileType = "wrapper.pb-project"; name = odr.xcodeproj; path = build/odr.xcodeproj; sourceTree = "<group>"; };
 		E26C39382250DC6E009C484A /* WebKit.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = WebKit.framework; path = System/Library/Frameworks/WebKit.framework; sourceTree = SDKROOT; };
 		E29E4076225A4672002C06E6 /* GoogleService-Info.plist */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist.xml; path = "GoogleService-Info.plist"; sourceTree = "<group>"; };
@@ -247,6 +249,7 @@
 			isa = PBXFrameworksBuildPhase;
 			buildActionMask = 2147483647;
 			files = (
+				E23795302274844400BA7238 /* AdSupport.framework in Frameworks */,
 				E2D920F0226B1C7D0042A774 /* libcryptopp-object.a in Frameworks */,
 				E2A3EE742259FA3100511BD2 /* libtinyxml2.a in Frameworks */,
 				E26C39392250DC6E009C484A /* WebKit.framework in Frameworks */,
@@ -301,6 +304,7 @@
 		E2BB4B64220EF4F20056176B /* Frameworks */ = {
 			isa = PBXGroup;
 			children = (
+				E237952F2274844400BA7238 /* AdSupport.framework */,
 				E26C39382250DC6E009C484A /* WebKit.framework */,
 				E26C38EA2250D91C009C484A /* odr.xcodeproj */,
 				EF00F649A86477A6C27F07C0 /* Pods_OpenDocumentReader.framework */,
diff --git a/OpenDocumentReader/DocumentViewController.swift b/OpenDocumentReader/DocumentViewController.swift
@@ -196,6 +196,8 @@ class DocumentViewController: UIViewController, DocumentDelegate {
     
     func documentLoadingError(_ doc: Document) {
         self.webview.loadHTMLString("<html><h1>Error</h1>Failed to load given document. Please try another one while we are working hard to support as many documents as possible. Feel free to contact us via tomtasche@gmail.com for further questions.</html>", baseURL: nil)
+        
+        Analytics.logEvent("load_error", parameters: nil)
     }
     
     func documentLoadingStarted(_ doc: Document) {
@@ -205,6 +207,8 @@ class DocumentViewController: UIViewController, DocumentDelegate {
     
     func documentLoadingCompleted(_ doc: Document) {
         progressBar.isHidden = true
+        
+        Analytics.logEvent("load_success", parameters: nil)
     }
     
     func documentPagesChanged(_ doc: Document) {
diff --git a/OpenDocumentReader/Info.plist b/OpenDocumentReader/Info.plist
@@ -34,9 +34,9 @@
 	<key>CFBundlePackageType</key>
 	<string>APPL</string>
 	<key>CFBundleShortVersionString</key>
-	<string>1.2</string>
+	<string>1.3</string>
 	<key>CFBundleVersion</key>
-	<string>5</string>
+	<string>6</string>
 	<key>LSRequiresIPhoneOS</key>
 	<true/>
 	<key>UILaunchStoryboardName</key>

Original file line number	Diff line number	Diff line change
`@@ -196,6 +196,8 @@ class DocumentViewController: UIViewController, DocumentDelegate {`
`196`	`196`
`197`	`197`	`func documentLoadingError(_ doc: Document) {`
`198`	`198`	`self.webview.loadHTMLString("<html><h1>Error</h1>Failed to load given document. Please try another one while we are working hard to support as many documents as possible. Feel free to contact us via tomtasche@gmail.com for further questions.</html>", baseURL: nil)`
	`199`	`+`
	`200`	`+ Analytics.logEvent("load_error", parameters: nil)`
`199`	`201`	`}`
`200`	`202`
`201`	`203`	`func documentLoadingStarted(_ doc: Document) {`
`@@ -205,6 +207,8 @@ class DocumentViewController: UIViewController, DocumentDelegate {`
`205`	`207`
`206`	`208`	`func documentLoadingCompleted(_ doc: Document) {`
`207`	`209`	`progressBar.isHidden = true`
	`210`	`+`
	`211`	`+ Analytics.logEvent("load_success", parameters: nil)`
`208`	`212`	`}`
`209`	`213`
`210`	`214`	`func documentPagesChanged(_ doc: Document) {`