Skip to content

Commit 84f4939

Browse files
author
Thomas Taschauer
committed
fix app store icon, improve event names, fix edit after save
1 parent 0012654 commit 84f4939

3 files changed

Lines changed: 14 additions & 11 deletions

File tree

OpenDocumentReader.xcodeproj/project.pbxproj

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -160,28 +160,28 @@
160160
isa = PBXContainerItemProxy;
161161
containerPortal = E26C38EA2250D91C009C484A /* odr.xcodeproj */;
162162
proxyType = 1;
163-
remoteGlobalIDString = 68722AEF2DC64BF8AB2DF7D5;
163+
remoteGlobalIDString = 6EF4E076CF60433092E37E67;
164164
remoteInfo = glog;
165165
};
166166
E26C39322250D976009C484A /* PBXContainerItemProxy */ = {
167167
isa = PBXContainerItemProxy;
168168
containerPortal = E26C38EA2250D91C009C484A /* odr.xcodeproj */;
169169
proxyType = 1;
170-
remoteGlobalIDString = DBADB6840206443A97F2A76D;
170+
remoteGlobalIDString = 527B291C96804BA39CF2D5CC;
171171
remoteInfo = miniz;
172172
};
173173
E26C39342250D976009C484A /* PBXContainerItemProxy */ = {
174174
isa = PBXContainerItemProxy;
175175
containerPortal = E26C38EA2250D91C009C484A /* odr.xcodeproj */;
176176
proxyType = 1;
177-
remoteGlobalIDString = CD40E84D34284EF7A80FB402;
177+
remoteGlobalIDString = 753F6F499E954CF09FDDDB35;
178178
remoteInfo = odrlib;
179179
};
180180
E26C39362250D976009C484A /* PBXContainerItemProxy */ = {
181181
isa = PBXContainerItemProxy;
182182
containerPortal = E26C38EA2250D91C009C484A /* odr.xcodeproj */;
183183
proxyType = 1;
184-
remoteGlobalIDString = B382587C51824ECE8AB80585;
184+
remoteGlobalIDString = 0485BB4A08784DE785195780;
185185
remoteInfo = tinyxml2;
186186
};
187187
E29A02212365EF7800BD6A96 /* PBXContainerItemProxy */ = {
@@ -251,7 +251,7 @@
251251
isa = PBXContainerItemProxy;
252252
containerPortal = E26C38EA2250D91C009C484A /* odr.xcodeproj */;
253253
proxyType = 1;
254-
remoteGlobalIDString = E08901684B824F61ACF4B07B;
254+
remoteGlobalIDString = 0D80F2CF350D404897887FB1;
255255
remoteInfo = "cryptopp-object";
256256
};
257257
/* End PBXContainerItemProxy section */
@@ -930,7 +930,7 @@
930930
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
931931
CLANG_ENABLE_MODULES = YES;
932932
CODE_SIGN_STYLE = Automatic;
933-
CURRENT_PROJECT_VERSION = 14;
933+
CURRENT_PROJECT_VERSION = 15;
934934
DEVELOPMENT_TEAM = 5LS6X97G6J;
935935
HEADER_SEARCH_PATHS = (
936936
"$(inherited)",
@@ -943,7 +943,7 @@
943943
"@executable_path/Frameworks",
944944
);
945945
LIBRARY_SEARCH_PATHS = "$(inherited)";
946-
MARKETING_VERSION = 1.10;
946+
MARKETING_VERSION = 1.11;
947947
PRODUCT_BUNDLE_IDENTIFIER = at.tomtasche.reader;
948948
PRODUCT_NAME = "$(TARGET_NAME)";
949949
SWIFT_OBJC_BRIDGING_HEADER = OpenDocumentReader/BridgingHeader.h;
@@ -960,7 +960,7 @@
960960
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
961961
CLANG_ENABLE_MODULES = YES;
962962
CODE_SIGN_STYLE = Automatic;
963-
CURRENT_PROJECT_VERSION = 14;
963+
CURRENT_PROJECT_VERSION = 15;
964964
DEVELOPMENT_TEAM = 5LS6X97G6J;
965965
HEADER_SEARCH_PATHS = (
966966
"$(inherited)",
@@ -973,7 +973,7 @@
973973
"@executable_path/Frameworks",
974974
);
975975
LIBRARY_SEARCH_PATHS = "$(inherited)";
976-
MARKETING_VERSION = 1.10;
976+
MARKETING_VERSION = 1.11;
977977
PRODUCT_BUNDLE_IDENTIFIER = at.tomtasche.reader;
978978
PRODUCT_NAME = "$(TARGET_NAME)";
979979
SWIFT_OBJC_BRIDGING_HEADER = OpenDocumentReader/BridgingHeader.h;
3.6 KB
Loading

OpenDocumentReader/DocumentViewController.swift

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ class DocumentViewController: UIViewController, DocumentDelegate {
189189
}
190190

191191
func discardChanges() {
192-
Analytics.logEvent("menu_discard_changes", parameters: nil)
192+
Analytics.logEvent("menu_edit_discard", parameters: nil)
193193

194194
guard let doc = document else {
195195
Crashlytics.sharedInstance().throwException()
@@ -201,7 +201,7 @@ class DocumentViewController: UIViewController, DocumentDelegate {
201201
}
202202

203203
func saveContent() {
204-
Analytics.logEvent("menu_save_content", parameters: nil)
204+
Analytics.logEvent("menu_edit_save", parameters: nil)
205205

206206
guard let doc = document else {
207207
Crashlytics.sharedInstance().throwException()
@@ -212,6 +212,9 @@ class DocumentViewController: UIViewController, DocumentDelegate {
212212
doc.save(to: doc.fileURL, for: .forOverwriting) { success in
213213
if success {
214214
self.showToast(controller: self, message: "Successfully saved", seconds: 1.5, color: .green)
215+
216+
// makes sure UI stays in edit-mode
217+
self.document?.updateChangeCount(.done)
215218
} else {
216219
self.showToast(controller: self, message: "Error while saving", seconds: 1.5, color: .red)
217220
}

0 commit comments

Comments
 (0)