Skip to content

Commit b532e57

Browse files
committed
update dependencies
1 parent 2bdca21 commit b532e57

5 files changed

Lines changed: 150 additions & 122 deletions

File tree

OpenDocumentReader.xcodeproj/project.pbxproj

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -584,7 +584,7 @@
584584
CLANG_CXX_LANGUAGE_STANDARD = "gnu++17";
585585
CLANG_ENABLE_MODULES = YES;
586586
CODE_SIGN_STYLE = Automatic;
587-
CURRENT_PROJECT_VERSION = 33;
587+
CURRENT_PROJECT_VERSION = 35;
588588
DEFINES_MODULE = YES;
589589
DEVELOPMENT_TEAM = 5LS6X97G6J;
590590
HEADER_SEARCH_PATHS = "$(inherited)";
@@ -595,7 +595,7 @@
595595
"@executable_path/Frameworks",
596596
);
597597
LIBRARY_SEARCH_PATHS = "$(inherited)";
598-
MARKETING_VERSION = 1.26;
598+
MARKETING_VERSION = 1.28;
599599
PRODUCT_BUNDLE_IDENTIFIER = at.tomtasche.reader.lite1;
600600
PRODUCT_NAME = "$(BUNDLE_DISPLAY_NAME)";
601601
SWIFT_OBJC_BRIDGING_HEADER = OpenDocumentReader/BridgingHeader.h;
@@ -674,7 +674,7 @@
674674
CLANG_CXX_LANGUAGE_STANDARD = "gnu++17";
675675
CLANG_ENABLE_MODULES = YES;
676676
CODE_SIGN_STYLE = Automatic;
677-
CURRENT_PROJECT_VERSION = 33;
677+
CURRENT_PROJECT_VERSION = 35;
678678
DEFINES_MODULE = YES;
679679
DEVELOPMENT_TEAM = 5LS6X97G6J;
680680
HEADER_SEARCH_PATHS = "$(inherited)";
@@ -685,7 +685,7 @@
685685
"@executable_path/Frameworks",
686686
);
687687
LIBRARY_SEARCH_PATHS = "$(inherited)";
688-
MARKETING_VERSION = 1.26;
688+
MARKETING_VERSION = 1.28;
689689
PRODUCT_BUNDLE_IDENTIFIER = at.tomtasche.reader.lite1;
690690
PRODUCT_NAME = "$(BUNDLE_DISPLAY_NAME)";
691691
SWIFT_OBJC_BRIDGING_HEADER = OpenDocumentReader/BridgingHeader.h;
@@ -912,7 +912,7 @@
912912
CLANG_CXX_LANGUAGE_STANDARD = "gnu++17";
913913
CLANG_ENABLE_MODULES = YES;
914914
CODE_SIGN_STYLE = Automatic;
915-
CURRENT_PROJECT_VERSION = 33;
915+
CURRENT_PROJECT_VERSION = 35;
916916
DEFINES_MODULE = YES;
917917
DEVELOPMENT_TEAM = 5LS6X97G6J;
918918
HEADER_SEARCH_PATHS = "$(inherited)";
@@ -923,7 +923,7 @@
923923
"@executable_path/Frameworks",
924924
);
925925
LIBRARY_SEARCH_PATHS = "$(inherited)";
926-
MARKETING_VERSION = 1.26;
926+
MARKETING_VERSION = 1.28;
927927
PRODUCT_BUNDLE_IDENTIFIER = "at.tomtasche.reader$(BUNDLE_ID_SUFFIX)";
928928
PRODUCT_NAME = "$(BUNDLE_DISPLAY_NAME)";
929929
SWIFT_OBJC_BRIDGING_HEADER = OpenDocumentReader/BridgingHeader.h;
@@ -943,7 +943,7 @@
943943
CLANG_CXX_LANGUAGE_STANDARD = "gnu++17";
944944
CLANG_ENABLE_MODULES = YES;
945945
CODE_SIGN_STYLE = Automatic;
946-
CURRENT_PROJECT_VERSION = 33;
946+
CURRENT_PROJECT_VERSION = 35;
947947
DEFINES_MODULE = YES;
948948
DEVELOPMENT_TEAM = 5LS6X97G6J;
949949
HEADER_SEARCH_PATHS = "$(inherited)";
@@ -954,7 +954,7 @@
954954
"@executable_path/Frameworks",
955955
);
956956
LIBRARY_SEARCH_PATHS = "$(inherited)";
957-
MARKETING_VERSION = 1.26;
957+
MARKETING_VERSION = 1.28;
958958
PRODUCT_BUNDLE_IDENTIFIER = "at.tomtasche.reader$(BUNDLE_ID_SUFFIX)";
959959
PRODUCT_NAME = "$(BUNDLE_DISPLAY_NAME)";
960960
SWIFT_OBJC_BRIDGING_HEADER = OpenDocumentReader/BridgingHeader.h;

OpenDocumentReader/DocumentBrowserViewController.swift

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,15 @@ class DocumentBrowserViewController: UIDocumentBrowserViewController, UIDocument
1717
override func viewDidLoad() {
1818
super.viewDidLoad()
1919
delegate = self
20-
21-
StoreReviewHelper.checkAndAskForReview()
22-
20+
2321
allowsDocumentCreation = false
2422
allowsPickingMultipleItems = false
2523
}
2624

2725
override func viewDidAppear(_ animated: Bool) {
2826
super.viewDidAppear(animated)
27+
28+
StoreReviewHelper.checkAndAskForReview()
2929

3030
let userDefaults = UserDefaults.standard
3131
let wasIntroWatched = userDefaults.bool(forKey: Constants.key_was_intro_watched)
@@ -35,7 +35,6 @@ class DocumentBrowserViewController: UIDocumentBrowserViewController, UIDocument
3535
if let pageVC = storyboard?.instantiateViewController(withIdentifier: pageViewController) as? PageViewController {
3636
present(pageVC, animated: true, completion: nil)
3737
}
38-
3938
}
4039

4140
func documentBrowser(_ controller: UIDocumentBrowserViewController, didImportDocumentAt sourceURL: URL, toDestinationURL destinationURL: URL) {

OpenDocumentReader/StoreReviewHelper.swift

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,8 @@ struct StoreReviewHelper {
3434
return
3535
}
3636

37+
StoreReviewHelper().requestReview()
38+
3739
switch appOpenCount {
3840
case 3:
3941
StoreReviewHelper().requestReview()
@@ -46,9 +48,13 @@ struct StoreReviewHelper {
4648
}
4749

4850
fileprivate func requestReview() {
49-
if #available(iOS 10.3, *) {
50-
Analytics.logEvent("rating_show", parameters: nil)
51-
51+
Analytics.logEvent("rating_show", parameters: nil)
52+
53+
if #available(iOS 14.0, *) {
54+
if let scene = UIApplication.shared.connectedScenes.first(where: { $0.activationState == .foregroundActive }) as? UIWindowScene {
55+
SKStoreReviewController.requestReview(in: scene)
56+
}
57+
} else if #available(iOS 10.3, *) {
5258
SKStoreReviewController.requestReview()
5359
} else {
5460
// Fallback on earlier versions

0 commit comments

Comments
 (0)