add support for PDF

Thomas Taschauer · Thomas Taschauer · commit ba80eebfb291 · 2019-04-28T09:39:25.000+02:00
diff --git a/OpenDocumentReader/DocumentBrowserViewController.swift b/OpenDocumentReader/DocumentBrowserViewController.swift
@@ -82,8 +82,9 @@ class DocumentBrowserViewController: UIDocumentBrowserViewController, UIDocument
         
         documentViewController.document = doc
         
+        let shortenedDocumentUrl = documentURL.absoluteString.prefix(49) + ".." + documentURL.absoluteString.suffix(49)
         Analytics.logEvent(AnalyticsEventViewItem, parameters: [
-            AnalyticsParameterItemName: documentURL.absoluteString
+            AnalyticsParameterItemName: shortenedDocumentUrl
         ])
         
         doc.open { [weak self](success) in
diff --git a/OpenDocumentReader/DocumentViewController.swift b/OpenDocumentReader/DocumentViewController.swift
@@ -195,7 +195,17 @@ class DocumentViewController: UIViewController, DocumentDelegate {
     }
     
     func documentLoadingError(_ doc: Document) {
-        self.webview.loadHTMLString("<html><h1>Error</h1>Failed to load given document. Please try another one while we are working hard to support as many documents as possible. Feel free to contact us via tomtasche@gmail.com for further questions.</html>", baseURL: nil)
+        if (doc.fileURL.pathExtension == "pdf") {
+            self.webview.loadFileURL(doc.fileURL, allowingReadAccessTo: doc.fileURL)
+            
+            progressBar.isHidden = true
+            
+            Analytics.logEvent("load_pdf", parameters: nil)
+            
+            return;
+        }
+        
+        self.webview.loadHTMLString("<html><h1>Error</h1>Failed to load given document. Please try another one while we are working hard to support as many documents as possible. Feel free to contact us via support@opendocument.app for further questions.</html>", baseURL: nil)
         
         Analytics.logEvent("load_error", parameters: nil)
     }
diff --git a/OpenDocumentReader/Info.plist b/OpenDocumentReader/Info.plist
@@ -12,7 +12,7 @@
 			<key>CFBundleTypeIconFiles</key>
 			<array/>
 			<key>CFBundleTypeName</key>
-			<string>ODF</string>
+			<string>ODT</string>
 			<key>CFBundleTypeRole</key>
 			<string>Viewer</string>
 			<key>LSHandlerRank</key>
@@ -22,6 +22,20 @@
 				<string>public.zip-archive</string>
 			</array>
 		</dict>
+		<dict>
+			<key>CFBundleTypeIconFiles</key>
+			<array/>
+			<key>CFBundleTypeName</key>
+			<string>PDF</string>
+			<key>CFBundleTypeRole</key>
+			<string>Viewer</string>
+			<key>LSHandlerRank</key>
+			<string>Alternate</string>
+			<key>LSItemContentTypes</key>
+			<array>
+				<string>com.adobe.pdf</string>
+			</array>
+		</dict>
 	</array>
 	<key>CFBundleExecutable</key>
 	<string>$(EXECUTABLE_NAME)</string>
@@ -34,9 +48,9 @@
 	<key>CFBundlePackageType</key>
 	<string>APPL</string>
 	<key>CFBundleShortVersionString</key>
-	<string>1.3</string>
+	<string>1.4</string>
 	<key>CFBundleVersion</key>
-	<string>6</string>
+	<string>7</string>
 	<key>LSRequiresIPhoneOS</key>
 	<true/>
 	<key>UILaunchStoryboardName</key>
@@ -63,9 +77,5 @@
 	</array>
 	<key>UISupportsDocumentBrowser</key>
 	<true/>
-	<key>UTImportedTypeDeclarations</key>
-	<array>
-		<dict/>
-	</array>
 </dict>
 </plist>
