Merge pull request #27 from wdesimini/master

TomTasche · web-flow · commit be9fe7975916 · 2019-06-08T20:54:50.000+02:00
Added ContentType to Firebase Analytics logs for "load_success" and "load_error"
diff --git a/OpenDocumentReader/Document.swift b/OpenDocumentReader/Document.swift
@@ -104,3 +104,11 @@ class Document: UIDocument {
         parse()
     }
 }
+
+extension Document {
+    
+    var shortenedDocumentUrl: String {
+        return fileURL.absoluteString.prefix(49) + ".." + fileURL.absoluteString.suffix(49)
+    }
+    
+}
diff --git a/OpenDocumentReader/DocumentViewController.swift b/OpenDocumentReader/DocumentViewController.swift
@@ -214,7 +214,12 @@ class DocumentViewController: UIViewController, DocumentDelegate {
         
         self.webview.loadHTMLString("<html><h1>Error</h1>Failed to load given document. Please try another one while we are working hard to support as many documents as possible. Feel free to contact us via support@opendocument.app for further questions.</html>", baseURL: nil)
         
-        Analytics.logEvent("load_error", parameters: nil)
+        Analytics.logEvent(
+            "load_error",
+            parameters: [
+                AnalyticsParameterItemName: doc.shortenedDocumentUrl,
+                AnalyticsParameterContentType: fileType
+            ])
     }
     
     func documentLoadingStarted(_ doc: Document) {
@@ -225,7 +230,14 @@ class DocumentViewController: UIViewController, DocumentDelegate {
     func documentLoadingCompleted(_ doc: Document) {
         progressBar.isHidden = true
         
-        Analytics.logEvent("load_success", parameters: nil)
+        let fileType = doc.fileURL.pathExtension.lowercased()
+        
+        Analytics.logEvent(
+            "load_success",
+            parameters: [
+                AnalyticsParameterItemName: doc.shortenedDocumentUrl,
+                AnalyticsParameterContentType: fileType
+            ])
     }
     
     func documentPagesChanged(_ doc: Document) {

Original file line number	Diff line number	Diff line change
`@@ -104,3 +104,11 @@ class Document: UIDocument {`
`104`	`104`	`parse()`
`105`	`105`	`}`
`106`	`106`	`}`
	`107`	`+`
	`108`	`+extension Document {`
	`109`	`+`
	`110`	`+ var shortenedDocumentUrl: String {`
	`111`	`+ return fileURL.absoluteString.prefix(49) + ".." + fileURL.absoluteString.suffix(49)`
	`112`	`+ }`
	`113`	`+`
	`114`	`+}`