Skip to content

Commit cd93818

Browse files
authored
Merge pull request #62 from opendocument-app/fix/disable-search-button
Disable search button if the document is not supported.
2 parents ad25558 + ce84d5d commit cd93818

2 files changed

Lines changed: 9 additions & 6 deletions

File tree

OpenDocumentReader/DocumentViewController.swift

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ class DocumentViewController: UIViewController, DocumentDelegate, GADBannerViewD
4444
@IBOutlet weak var bannerView: GADBannerView!
4545
@IBOutlet weak var bannerViewHeight: NSLayoutConstraint!
4646
@IBOutlet weak var barButtonItem: UIBarButtonItem!
47+
@IBOutlet weak var searchButton: UIBarButtonItem!
4748

4849
private var searchBarHeightWhenShown: NSLayoutConstraint?
4950
private var searchBarHeightWhenHidden: NSLayoutConstraint?
@@ -443,6 +444,7 @@ class DocumentViewController: UIViewController, DocumentDelegate, GADBannerViewD
443444
self.webview.loadFileURL(doc.fileURL, allowingReadAccessTo: doc.fileURL)
444445

445446
progressBar.isHidden = true
447+
searchButton.isEnabled = false
446448

447449
Analytics.logEvent("load_success", parameters: [
448450
AnalyticsParameterItemName: doc.shortenedDocumentUrl,

OpenDocumentReader/Main.storyboard

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
<?xml version="1.0" encoding="UTF-8"?>
2-
<document type="com.apple.InterfaceBuilder3.CocoaTouch.Storyboard.XIB" version="3.0" toolsVersion="17132" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" useTraitCollections="YES" useSafeAreas="YES" colorMatched="YES" initialViewController="BYZ-38-t0r">
2+
<document type="com.apple.InterfaceBuilder3.CocoaTouch.Storyboard.XIB" version="3.0" toolsVersion="17154" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" useTraitCollections="YES" useSafeAreas="YES" colorMatched="YES" initialViewController="BYZ-38-t0r">
33
<device id="retina6_5" orientation="portrait" appearance="light"/>
44
<dependencies>
55
<deployment identifier="iOS"/>
6-
<plugIn identifier="com.apple.InterfaceBuilder.IBCocoaTouchPlugin" version="17105.1"/>
6+
<plugIn identifier="com.apple.InterfaceBuilder.IBCocoaTouchPlugin" version="17124"/>
77
<capability name="Safe area layout guides" minToolsVersion="9.0"/>
88
<capability name="System colors in document resources" minToolsVersion="11.0"/>
99
<capability name="documents saved in the Xcode 8 format" minToolsVersion="8.0"/>
@@ -118,6 +118,7 @@
118118
<outlet property="menuButton" destination="Vsd-IL-ujz" id="GoN-tp-egn"/>
119119
<outlet property="progressBar" destination="ePk-bQ-fV8" id="nz6-qw-ouf"/>
120120
<outlet property="searchBar" destination="A5V-8n-dvk" id="AIb-1s-JO6"/>
121+
<outlet property="searchButton" destination="fGi-i7-iOR" id="77J-cW-TAe"/>
121122
<outlet property="segmentedControl" destination="sIx-zo-9kG" id="pCn-x0-Z01"/>
122123
<outlet property="toolBar" destination="N1x-QM-Qks" id="db4-aA-GH6"/>
123124
<outlet property="webview" destination="VF5-Do-xh9" id="25W-hb-tHy"/>
@@ -144,10 +145,10 @@
144145
<autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
145146
<subviews>
146147
<stackView opaque="NO" contentMode="scaleToFill" distribution="fillEqually" spacing="83" translatesAutoresizingMaskIntoConstraints="NO" id="nfe-JJ-89b">
147-
<rect key="frame" x="-59.333333333333343" y="813" width="532.66666666666663" height="39"/>
148+
<rect key="frame" x="-72" y="813" width="558" height="39"/>
148149
<subviews>
149150
<button opaque="NO" contentMode="scaleToFill" contentHorizontalAlignment="center" contentVerticalAlignment="center" buttonType="system" lineBreakMode="middleTruncation" translatesAutoresizingMaskIntoConstraints="NO" id="uLV-WY-zIj">
150-
<rect key="frame" x="0.0" y="0.0" width="122.33333333333333" height="39"/>
151+
<rect key="frame" x="0.0" y="0.0" width="130.66666666666666" height="39"/>
151152
<fontDescription key="fontDescription" type="system" pointSize="22"/>
152153
<state key="normal" title="Skip">
153154
<color key="titleColor" white="0.66666666666666663" alpha="1" colorSpace="custom" customColorSpace="genericGamma22GrayColorSpace"/>
@@ -158,12 +159,12 @@
158159
</connections>
159160
</button>
160161
<pageControl opaque="NO" contentMode="scaleToFill" contentHorizontalAlignment="center" contentVerticalAlignment="center" numberOfPages="3" translatesAutoresizingMaskIntoConstraints="NO" id="Eq9-2L-Y0h">
161-
<rect key="frame" x="205.33333333333337" y="0.0" width="122" height="39"/>
162+
<rect key="frame" x="213.66666666666669" y="0.0" width="130.66666666666669" height="39"/>
162163
<color key="pageIndicatorTintColor" white="0.66666666666666663" alpha="1" colorSpace="custom" customColorSpace="genericGamma22GrayColorSpace"/>
163164
<color key="currentPageIndicatorTintColor" white="1" alpha="1" colorSpace="custom" customColorSpace="genericGamma22GrayColorSpace"/>
164165
</pageControl>
165166
<button opaque="NO" contentMode="scaleToFill" contentHorizontalAlignment="center" contentVerticalAlignment="center" buttonType="system" lineBreakMode="middleTruncation" translatesAutoresizingMaskIntoConstraints="NO" id="BJ9-WO-km9">
166-
<rect key="frame" x="410.33333333333331" y="0.0" width="122.33333333333331" height="39"/>
167+
<rect key="frame" x="427.33333333333331" y="0.0" width="130.66666666666669" height="39"/>
167168
<fontDescription key="fontDescription" type="system" pointSize="22"/>
168169
<state key="normal" title="Next">
169170
<color key="titleColor" white="1" alpha="1" colorSpace="custom" customColorSpace="genericGamma22GrayColorSpace"/>

0 commit comments

Comments
 (0)