improve error handling

Author: TomTasche

OpenDocumentReader/CoreWrapper.mm

@@ -63,10 +63,10 @@ - (bool)translate:(NSString *)inputPath into:(NSString *)outputPath with:(NSStri
 
             _pageNames = pageNames;
             _pagePaths = pagePaths;
-        } catch (odr::UnknownFileType) {
+        } catch (odr::UnknownFileType&) {
             _errorCode = @(-5);
             return false;
-        } catch (odr::WrongPassword) {
+        } catch (odr::WrongPassword&) {
             _errorCode = @(-2);
             return false;
         } catch (...) {

OpenDocumentReader/Document.swift

@@ -125,6 +125,10 @@ class Document: UIDocument {
         delegate?.documentLoadingCompleted(self)
     }
 
+    override func handleError(_ error: Error, userInteractionPermitted: Bool) {
+        Crashlytics.crashlytics().record(error: error)
+    }
+    
     override func writeContents(_ contents: Any, to url: URL, for saveOperation: UIDocument.SaveOperation, originalContentsURL: URL?) throws {
         var diff = ""
 

OpenDocumentReader/DocumentViewController.swift

@@ -233,7 +233,6 @@ class DocumentViewController: UIViewController, DocumentDelegate, GADBannerViewD
         webview?.evaluateJavaScript("odr.searchNext(\"" + searchText + "\")", completionHandler: { (value: Any!, error: Error!) -> Void in
             if error != nil {
                 Crashlytics.crashlytics().record(error: error)
-                fatalError("search failed")
             }
         })
     }
@@ -242,7 +241,6 @@ class DocumentViewController: UIViewController, DocumentDelegate, GADBannerViewD
         webview?.evaluateJavaScript("odr.search(\"" + searchText + "\")", completionHandler: { (value: Any!, error: Error!) -> Void in
             if error != nil {
                 Crashlytics.crashlytics().record(error: error)
-                fatalError("search failed")
             }
         })
     }