Commit 6e78858
authored
[BUG]
#### Metadata
* Reference Issue: Refer failures in #1579
* New Tests Added: No
* Documentation Updated: No
* Change Log Entry: Checks if the directory was created newly else doesn't remove.
### Details
* What does this PR implement/fix? Explain your changes.
`get_task` checks if the `tid_cache_dir` was already existing before removing it on `Exception`
* Why is this change necessary? What is the problem it solves?
`OpenMLServerException` causes `get_task` to remove the entire directory even if the directory was already existing and is used by other tests
* How can I reproduce the issue this PR is solving and its solution?
observe `exists assertion` errors for files under `tests/files/org/openml/test/task/1/` after running `pytest`
or look at failures in #1579get_task removes the dir even if was already existing (#1584)1 parent 6043686 commit 6e78858
2 files changed
Lines changed: 6 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
415 | 415 | | |
416 | 416 | | |
417 | 417 | | |
418 | | - | |
419 | | - | |
| 418 | + | |
| 419 | + | |
| 420 | + | |
420 | 421 | | |
421 | 422 | | |
422 | 423 | | |
| |||
430 | 431 | | |
431 | 432 | | |
432 | 433 | | |
433 | | - | |
| 434 | + | |
| 435 | + | |
434 | 436 | | |
435 | 437 | | |
436 | 438 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
815 | 815 | | |
816 | 816 | | |
817 | 817 | | |
| 818 | + | |
818 | 819 | | |
819 | 820 | | |
820 | 821 | | |
| |||
0 commit comments