Fix deb package missing bundled libraries (fixes #362)

The docker export tar extraction failed silently on Debian trixie/sid
because: (1) libsod was extracted from 'lib/libsod.so*' but usrmerge
maps /lib → /usr/lib, so the tar stores files under usr/lib/; (2)
docker export may prefix paths with './' which the old wildcards
didn't match. This left /usr/lib/lightnvr empty in the .deb package.

- Add both 'usr/lib/…' and './usr/lib/…' wildcard variants for all
  four bundled libraries (libuv, llhttp, sqlite3, libsod)
- Add post-extraction verification that fails the build if any
  expected library is missing
- Update Dockerfile to COPY libsod from /usr/lib/ consistently with
  the other libraries
- Clean up redundant symlink creation loop

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: matteius

.github/workflows/debian-package.yml

@@ -106,27 +106,36 @@ jobs:
           docker cp "${CID}:/bin/go2rtc"   "${PKG_DIR}/usr/bin/go2rtc"
 
           # Custom-built libraries (bundle to guarantee ABI compatibility)
+          # Include both 'usr/lib/…' and './usr/lib/…' variants because
+          # docker export may prefix paths with './' depending on version.
+          # All custom libs live under /usr/lib/ in the image (on usrmerge
+          # systems /lib is a symlink to /usr/lib, so libsod also lands there).
           mkdir -p /tmp/lightnvr_libs
           docker export "${CID}" | tar xf - --wildcards \
-            'usr/lib/libuv.so*' \
-            'usr/lib/libllhttp.so*' \
-            'usr/lib/libsqlite3.so*' \
-            'lib/libsod.so*' \
+            'usr/lib/libuv.so*' './usr/lib/libuv.so*' \
+            'usr/lib/libllhttp.so*' './usr/lib/libllhttp.so*' \
+            'usr/lib/libsqlite3.so*' './usr/lib/libsqlite3.so*' \
+            'usr/lib/libsod.so*' './usr/lib/libsod.so*' \
             -C /tmp/lightnvr_libs/ 2>/dev/null || true
 
           find /tmp/lightnvr_libs -type f -name '*.so*' ! -type l \
             -exec install -m 644 {} "${PKG_DIR}/usr/lib/lightnvr/" \;
 
-          # Recreate symlinks inside the package directory
+          # Verify that all expected libraries were extracted
+          for expected_lib in libuv libllhttp libsqlite3 libsod; do
+            if ! ls "${PKG_DIR}/usr/lib/lightnvr/${expected_lib}.so"* >/dev/null 2>&1; then
+              echo "ERROR: ${expected_lib} not found in extracted libraries!"
+              echo "Contents of /tmp/lightnvr_libs:"
+              find /tmp/lightnvr_libs -type f -name '*.so*' 2>/dev/null
+              exit 1
+            fi
+          done
+
+          # Recreate soname symlink chains inside the package directory
+          # (Docker COPY dereferences symlinks, so we must recreate them)
           (cd "${PKG_DIR}/usr/lib/lightnvr" && \
-            for f in libuv.so.1.0.0 libllhttp.so.9.3.1 libsod.so.1.1.9; do \
-              [ -f "$f" ] || continue; \
-              BASE="${f%%.*}"; \
-              SONAME=$(readlink -f /tmp/lightnvr_libs/usr/lib/${f} 2>/dev/null | xargs -I{} basename {} 2>/dev/null || echo ""); \
-              ln -sf "$f" "${BASE}.so" 2>/dev/null || true; \
-            done; \
-            [ -f libsod.so.1.1.9 ] && ln -sf libsod.so.1.1.9 libsod.so.1 && ln -sf libsod.so.1 libsod.so || true; \
-            [ -f libuv.so.1.0.0  ] && ln -sf libuv.so.1.0.0  libuv.so.1  && ln -sf libuv.so.1  libuv.so  || true; \
+            [ -f libsod.so.1.1.9 ]    && ln -sf libsod.so.1.1.9    libsod.so.1    && ln -sf libsod.so.1    libsod.so    || true; \
+            [ -f libuv.so.1.0.0  ]    && ln -sf libuv.so.1.0.0     libuv.so.1     && ln -sf libuv.so.1     libuv.so     || true; \
             [ -f libllhttp.so.9.3.1 ] && ln -sf libllhttp.so.9.3.1 libllhttp.so.9 && ln -sf libllhttp.so.9 libllhttp.so || true)
 
           # Find and symlink sqlite3 if extracted

Dockerfile

@@ -208,10 +208,8 @@ COPY --from=builder /usr/lib/libllhttp.so* /usr/lib/
 # Copy latest upstream SQLite shared library built in the builder stage
 COPY --from=builder /usr/lib/libsqlite3.so* /usr/lib/
 
-# Copy SOD libraries
-COPY --from=builder /lib/libsod.so.1.1.9 /lib/libsod.so.1.1.9
-COPY --from=builder /lib/libsod.so.1 /lib/libsod.so.1
-COPY --from=builder /lib/libsod.so /lib/libsod.so
+# Copy SOD libraries (use /usr/lib/ consistently; on usrmerge systems /lib → /usr/lib)
+COPY --from=builder /usr/lib/libsod.so* /usr/lib/
 
 # Copy web assets (copy CONTENTS of dist into /var/lib/lightnvr/www)
 COPY --from=builder /opt/web/dist/ /var/lib/lightnvr/www/