Skip to content

Commit 77cdfd7

Browse files
committed
Add regression test for strftime timezone mismatch
1 parent 0c32235 commit 77cdfd7

1 file changed

Lines changed: 97 additions & 0 deletions

File tree

  • graalpython/com.oracle.graal.python.test/src/com/oracle/graal/python/test/builtin/modules
Lines changed: 97 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,97 @@
1+
/*
2+
* Copyright (c) 2026, Oracle and/or its affiliates. All rights reserved.
3+
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
4+
*
5+
* The Universal Permissive License (UPL), Version 1.0
6+
*
7+
* Subject to the condition set forth below, permission is hereby granted to any
8+
* person obtaining a copy of this software, associated documentation and/or
9+
* data (collectively the "Software"), free of charge and under any and all
10+
* copyright rights in the Software, and any and all patent rights owned or
11+
* freely licensable by each licensor hereunder covering either (i) the
12+
* unmodified Software as contributed to or provided by such licensor, or (ii)
13+
* the Larger Works (as defined below), to deal in both
14+
*
15+
* (a) the Software, and
16+
*
17+
* (b) any piece of software and/or hardware listed in the lrgrwrks.txt file if
18+
* one is included with the Software each a "Larger Work" to which the Software
19+
* is contributed by such licensors),
20+
*
21+
* without restriction, including without limitation the rights to copy, create
22+
* derivative works of, display, perform, and distribute the Software and make,
23+
* use, sell, offer for sale, import, export, have made, and have sold the
24+
* Software and the Larger Work(s), and to sublicense the foregoing rights on
25+
* either these or other terms.
26+
*
27+
* This license is subject to the following condition:
28+
*
29+
* The above copyright notice and either this complete permission notice or at a
30+
* minimum a reference to the UPL must be included in all copies or substantial
31+
* portions of the Software.
32+
*
33+
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
34+
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
35+
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
36+
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
37+
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
38+
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
39+
* SOFTWARE.
40+
*/
41+
package com.oracle.graal.python.test.builtin.modules;
42+
43+
import static org.junit.Assert.assertEquals;
44+
45+
import java.util.LinkedHashMap;
46+
import java.util.Map;
47+
import java.util.TimeZone;
48+
49+
import org.graalvm.polyglot.Context;
50+
import org.graalvm.polyglot.Source;
51+
import org.junit.Test;
52+
53+
public class TimeModuleTests {
54+
55+
@Test
56+
public void strftimeTimezoneMatchesTzsetState() {
57+
TimeZone previousDefault = TimeZone.getDefault();
58+
try {
59+
TimeZone.setDefault(TimeZone.getTimeZone("Europe/Berlin"));
60+
String result;
61+
try (Context context = Context.newBuilder("python").allowAllAccess(true).build()) {
62+
result = context.eval(Source.create("python", """
63+
import os
64+
import time
65+
66+
os.environ["TZ"] = "UTC"
67+
time.tzset()
68+
tt = time.localtime()
69+
70+
"\\n".join((
71+
f"tm_zone={tt.tm_zone}",
72+
f"tzname={time.tzname[tt.tm_isdst > 0]}",
73+
f"strftime_tuple={time.strftime('%Z', tt)}",
74+
f"strftime_now={time.strftime('%Z')}",
75+
))
76+
""")).asString();
77+
}
78+
79+
Map<String, String> values = parseKeyValueLines(result);
80+
String details = values.toString();
81+
assertEquals(details, values.get("tm_zone"), values.get("tzname"));
82+
assertEquals(details, values.get("tm_zone"), values.get("strftime_tuple"));
83+
assertEquals(details, values.get("tm_zone"), values.get("strftime_now"));
84+
} finally {
85+
TimeZone.setDefault(previousDefault);
86+
}
87+
}
88+
89+
private static Map<String, String> parseKeyValueLines(String output) {
90+
Map<String, String> values = new LinkedHashMap<>();
91+
for (String line : output.split("\\R")) {
92+
int separator = line.indexOf('=');
93+
values.put(line.substring(0, separator), line.substring(separator + 1));
94+
}
95+
return values;
96+
}
97+
}

0 commit comments

Comments
 (0)