fixing time display

Author: orangecoding

client/src/components/cron/CronExplanation.jsx

@@ -1,4 +1,5 @@
 import { Clock, AlertCircle, Loader } from 'lucide-react'
+import { formatLocalDate } from '../../utils/date.js'
 
 export function CronExplanation({ validation }) {
   const { valid, human, next_runs, error, isLoading } = validation
@@ -34,7 +35,7 @@ export function CronExplanation({ validation }) {
           <span className="text-[#909090] font-medium">Next: </span>
           {next_runs.map((t, i) => (
             <span key={t}>
-              {new Date(t).toLocaleString()}
+              {formatLocalDate(t)}
               {i < next_runs.length - 1 ? <span className="text-[#383838]"> &bull; </span> : ''}
             </span>
           ))}

client/src/components/jobs/JobListItem.jsx

@@ -4,6 +4,7 @@ import { EnableToggle } from './EnableToggle.jsx'
 import { Button } from '../ui/Button.jsx'
 import { Tooltip } from '../ui/Tooltip.jsx'
 import { MarkdownDescription } from '../ui/MarkdownDescription.jsx'
+import { formatLocalDate } from '../../utils/date.js'
 
 function StatusBadge({ status }) {
   if (!status) return <Badge variant="neutral">Never run</Badge>
@@ -50,7 +51,7 @@ export function JobListItem({ job, onEdit, onDelete, onToggle, onTrigger, onHist
             <StatusBadge status={job.last_run_status} />
             {job.last_run_at && (
               <span className="text-xs text-[#505050]">
-                {new Date(job.last_run_at).toLocaleString()}
+                {formatLocalDate(job.last_run_at)}
               </span>
             )}
           </div>

client/src/components/runs/RunRecord.jsx

@@ -1,6 +1,7 @@
 import { useState } from 'react'
 import { ChevronDown, ChevronUp, CheckCircle, XCircle, Clock, Terminal } from 'lucide-react'
 import { Badge } from '../ui/Badge.jsx'
+import { formatLocalDate } from '../../utils/date.js'
 
 function formatDuration(ms) {
   if (!ms) return null
@@ -34,7 +35,7 @@ export function RunRecord({ run }) {
         </Badge>
         <div className="flex-1 min-w-0">
           <p className="text-xs text-[#909090]">
-            {new Date(run.started_at).toLocaleString()}
+            {formatLocalDate(run.started_at)}
             {run.duration_ms != null && (
               <span className="ml-2 text-[#505050]">{formatDuration(run.duration_ms)}</span>
             )}

package.json

@@ -1,6 +1,6 @@
 {
   "name": "cronpilot",
-  "version": "2.0.1",
+  "version": "2.0.2",
   "author": "Christian Kellner",
   "license": "Apache-2.0",
   "scripts": {

server/src/scheduler/executor.js

@@ -17,10 +17,6 @@ export function run(job, triggeredBy = 'scheduler') {
   const runId = runResult.lastInsertRowid
   logger.info({ jobId: job.id, runId, triggeredBy }, `Job "${job.name}" started`)
 
-  if (job.ntfy_enabled && job.ntfy_on_run) {
-    ntfySend(job, { status: 'running' }).catch(() => {})
-  }
-
   const child = job.command_type === 'inline'
     ? spawn('/bin/sh', ['-c', job.command], { stdio: ['ignore', 'pipe', 'pipe'] })
     : spawn(job.command, [], { shell: true, stdio: ['ignore', 'pipe', 'pipe'] })
@@ -74,13 +70,13 @@ export function run(job, triggeredBy = 'scheduler') {
       )
     `).run(job.id, job.id, maxRuns)
 
-    logger.info({ jobId: job.id, runId, status, exitCode, duration }, `Job "${job.name}" finished`)
-
     if (status === 'error' && job.ntfy_enabled && job.ntfy_on_error) {
       ntfySend(job, { status, exitCode, stderr }).catch(() => {})
     } else if (status === 'success' && job.ntfy_enabled && job.ntfy_on_run) {
       ntfySend(job, { status, exitCode }).catch(() => {})
     }
+
+    logger.info({ jobId: job.id, runId, status, exitCode, duration }, `Job "${job.name}" finished`)
   })
 
   return runId

server/src/services/ntfy.js

@@ -1,3 +1,4 @@
+import { logger } from '../logger.js'
 export async function send(job, context) {
   if (!job.ntfy_enabled || !job.ntfy_topic) return
   try {
@@ -19,7 +20,8 @@ export async function send(job, context) {
       },
       body
     })
-  } catch {
+  } catch (error) {
+    logger.error({error}, 'Failed to send notification to ntfy')
     // ntfy errors must never affect job execution
   }
 }