Skip to content

Commit 5148e94

Browse files
committed
Cleanup
1 parent 4f032e6 commit 5148e94

4 files changed

Lines changed: 6 additions & 10 deletions

File tree

scripts/download.sh

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,8 @@
1010
# (none)
1111

1212
echo "Downloading simulator if needed..."
13-
echo ""
1413

1514
# Capture output so it doesn't spam the console. In future this can optionally be printed to the console.
1615
LOG=$(xcodebuild -downloadPlatform "$SIMPLATFORM")
1716

1817
echo "Done downloading simulator."
19-
echo ""

scripts/id.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,10 +52,10 @@ else
5252
fi
5353

5454
# Exit out if no simulators matched the criteria.
55-
if [[ -z $DESTID ]]; then echo "Error: No matching simulators available."; exit 1; fi
55+
if [[ -z $DESTID ]]; then echo "⛔️ Error: No matching simulators available."; exit 1; fi
5656

5757
# Provide diagnostic output of selected devince simulator info.
58-
echo "Found device simulator: $DESTDESC"
58+
echo "🟢 Found device simulator: $DESTDESC"
5959

6060
# Set output variable.
6161
echo "id=$(echo $DESTID)" >> $GITHUB_OUTPUT

scripts/parse-inputs.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ echo "Using Xcode scheme: $SCHEME"
3434
# Setup OS version.
3535
OSVERSION_REGEX="$INPUT_OSVERSION"
3636

37-
# Provide diagnostic output of OS version.
38-
echo "Using OS version regex: $OSVERSION_REGEX"
37+
# Provide diagnostic output of OS version, but only if it's a non-empty string.
38+
if [[ -n $OSVERSION_REGEX ]]; then echo "Using OS version regex: $OSVERSION_REGEX"; fi
3939

4040
# Interpret platform and device criteria from input target identifier.
4141
# Convert target to lowercase to enable "case-insensitive" matching.
@@ -163,7 +163,7 @@ case $INPUT_TARGET_LOWERCASE in
163163

164164
*)
165165
# Check for empty string
166-
if [[ -z $INPUT_TARGET ]]; then echo "Error: No target specified."; exit 1; fi
166+
if [[ -z $INPUT_TARGET ]]; then echo "⛔️ Error: No target specified."; exit 1; fi
167167

168168
# Otherwise, use target string as device name regex.
169169
SIMDEVICE_REGEX="$INPUT_TARGET"

scripts/refresh.sh

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,8 @@
1010
# (none)
1111

1212
echo "Refreshing simulators..."
13-
echo ""
1413

1514
# Capture output so it doesn't spam the console. In future this can optionally be printed to the console.
1615
LIST=$(xcrun simctl list)
1716

18-
echo "Done refreshing simulators."
19-
echo ""
17+
echo "Done refreshing simulators."

0 commit comments

Comments
 (0)